From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4F24A0547; Fri, 12 Mar 2021 16:25:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30EB41608A1; Fri, 12 Mar 2021 16:25:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 7C339160863 for ; Fri, 12 Mar 2021 16:25:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615562722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TESzmfmsIPryteIfvnu5aG8FICX3DAm/0vLIZUYe0Pg=; b=C/bVbCQzE8xjxZgu3xzDj3GGLTPI/Q4IjoxATkz4ZSMdCbEs5cszA8qMjJILuQ+vBVALkr bGTkpjR/c1ZyPcMNkov6f5HfpnyGTf01SeomKccxTbxH7+MHLyZgVlJLRS22MjVFkjcKsm t6Z5r2/0MV2kNibs0ws2JwiM0UrHdh0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-7wEP7CxyOqift8m0CXcS9Q-1; Fri, 12 Mar 2021 10:25:21 -0500 X-MC-Unique: 7wEP7CxyOqift8m0CXcS9Q-1 Received: by mail-ua1-f72.google.com with SMTP id z24so4144057uao.0 for ; Fri, 12 Mar 2021 07:25:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TESzmfmsIPryteIfvnu5aG8FICX3DAm/0vLIZUYe0Pg=; b=P4k7Wr0aL62bGGSIsa4F1MwkobFfGn1g2jssgNsK8glDV5yCYtU+9Edf8Qc5D8fJHD RtA4DhRReKCj/kCe4/3uEyyQp3xA0BTjXXVgFiN41OXxyMRN7x4ArAl6t8CmGg98xqtC WTqQbnqQhFACkCgSDBaJ4gPWTIK79RE0OqfX4tqwy4Z1WNU8Qh18UEWx3LyNz+K627b3 uvVwTVkFUyDQe9iMbSlzmM8QPCBPnO5bannhuK7UNlGsUK0FYJeUtDh3lVDSIA4YAVgE PQHP3Lm4ela3NjifYvKXAnfzXja3wKiTU0Q/260iOketrKm1giCh3KvLPalhfx1mvbcc vXtA== X-Gm-Message-State: AOAM5312k4y03lRCgTNtmfAmDdmNz0wVPAH4PBAfQqI9Ns3XXBMEYtai pPbnjYnBekj7FFbUOSQGKqTAfgG70brHDf/sC3I9/Ib/0uD2jD1ONzHyBmLTFtjFUzMCGZlKo8+ FPoSMrKuXBd3D7rd0+Bk= X-Received: by 2002:ab0:2651:: with SMTP id q17mr8574102uao.87.1615562720768; Fri, 12 Mar 2021 07:25:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9e4ocsn9TDQr9c9NjKkPENkyc1Kpg1ykz8BcOjDo45wiqQz69kUGqcwFs8/P3IjubruzGnHZlHK923iXEBAs= X-Received: by 2002:ab0:2651:: with SMTP id q17mr8574089uao.87.1615562720505; Fri, 12 Mar 2021 07:25:20 -0800 (PST) MIME-Version: 1.0 References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <2da8b376-9016-11e6-8891-6db3957c7d79@intel.com> In-Reply-To: <2da8b376-9016-11e6-8891-6db3957c7d79@intel.com> From: David Marchand Date: Fri, 12 Mar 2021 16:25:09 +0100 Message-ID: To: Ferruh Yigit Cc: Tyler Retzlaff , dev , Thomas Monjalon , Andrew Rybchenko , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 12, 2021 at 4:20 PM Ferruh Yigit wrote: > > On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > > Introduce a meson option enable_driver_sdk when true installs internal > > driver headers for ethdev. this allows drivers that do not depend on > > stable api/abi to be built external to the dpdk source tree. > > > > Signed-off-by: Tyler Retzlaff > > --- > > > > it's still unclear to me if we should be renaming the headers: > > > > ethdev_driver.h -> rte_ethdev_driver.h > > ethdev_pci.h -> rte_ethdev_pci.h > > ethdev_vdev.h -> rte_ethdev_vdev.h > > > > lib/librte_ethdev/meson.build | 5 +++++ > > meson_options.txt | 2 ++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > > index c37b2e377..7ecdec6f0 100644 > > --- a/lib/librte_ethdev/meson.build > > +++ b/lib/librte_ethdev/meson.build > > @@ -20,6 +20,11 @@ headers = files('rte_ethdev.h', > > 'rte_mtr_driver.h', > > 'rte_tm.h', > > 'rte_tm_driver.h') > > +if get_option('enable_driver_sdk') > > +headers += files('ethdev_driver.h', > > + 'ethdev_pci.h', > > + 'ethdev_vdev.h') > > +endif > > Instead of adding the "get_option('enable_driver_sdk')" checks to the modules, > what about a more generic solution, like: > > modules assign relevant headers into a new variable, let's say 'pmd_headers', > and in a high level meson file, all 'pmd_headers' are installed if > 'enable_driver_sdk' enabled? > +1. Just, I don't like "pmd_headers" as the list name. It can be misunderstood as the list of pmd-specific headers (thinking of rte_pmd_i40e.h), that are exposed to applications. -- David Marchand