From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B18D1A0546; Thu, 16 Jul 2020 13:30:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ACB91BEE7; Thu, 16 Jul 2020 13:30:50 +0200 (CEST) Received: from us-smtp-1.mimecast.com (unknown [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 595C41BEB2 for ; Thu, 16 Jul 2020 13:30:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594899029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1FAl9P4pzyyEyK3ZgrdsXQxeEH9kedYPLeAd7RDgVmU=; b=HlAtwefULDeLfEcNXwsePkVikzDLoJW6ATatraOo0B6cYW1Q2tsAnShl5r5OwAul45fN8p XzSi8AJi2T9qIVVyz6SaUlyh1kljXEiZsglAUIzkuOMch+SHI1h6USNqbhTJIgd8P2cKUB jYUOro4cqMx215vZVmysPpXDp0ACrKs= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-E7nP_ZAlOAuDjRd8Qgj6pw-1; Thu, 16 Jul 2020 07:30:21 -0400 X-MC-Unique: E7nP_ZAlOAuDjRd8Qgj6pw-1 Received: by mail-ua1-f72.google.com with SMTP id l2so1025208uae.19 for ; Thu, 16 Jul 2020 04:30:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1FAl9P4pzyyEyK3ZgrdsXQxeEH9kedYPLeAd7RDgVmU=; b=mrdRvTE4sotoJ6+8jyRM/3SJOPmYY0gxwzM+8tX+gvwbHFeHk3S/ulyOf/y1neewW6 GrAgIFTVWDZW1ggJGozaUgLu5ZSB9xAIbDIY61tyyNzqYJfNDwZZ5DTmnJnPqkyJSccF OHHCb4OsrM3wG0eDhL6WJYvL8LTjww3BfJNZaXT8gaTzTVc1hQc0T0pR88T+0zQGIxF2 xEoZB7S+Mrg3Y+yPiPd7qd+MNpCEH4s4a61wnRe+5RowfGaKabqiX9NsABjvVtYZ7mi0 FAQZOEyhuX0qPpGCXXAqWr8+RKv3BExIrIKai7cvl8EWIntHwOfCwxrd7jpOeTGyFdvQ WgZA== X-Gm-Message-State: AOAM5317h6lIipXpUbSg+elETMOKS/LErjnyh+Ndb9TkCFXUB4rUgSHq Qoy0/Fe3BLJY3GF8w9hkn9Y7eAzpkZUAuWPZn/dsIqvKLHDJaTC/M3EXBa1t1eTxVU07kcHU/O8 CTyMoyc0GLbY9LyMWbo0= X-Received: by 2002:ab0:5a72:: with SMTP id m47mr2802195uad.86.1594899020899; Thu, 16 Jul 2020 04:30:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv+YtjuoxTXvULTnzpLqI9NjTbeaeaUVvm8yDyP7xdvOFtn/IiTInk2+k+jHHWLZNphdqsrTQjjIysLnc7l5g= X-Received: by 2002:ab0:5a72:: with SMTP id m47mr2802169uad.86.1594899020589; Thu, 16 Jul 2020 04:30:20 -0700 (PDT) MIME-Version: 1.0 References: <1594289442-18594-1-git-send-email-phil.yang@arm.com> <1594310331-23345-1-git-send-email-phil.yang@arm.com> In-Reply-To: From: David Marchand Date: Thu, 16 Jul 2020 13:30:09 +0200 Message-ID: To: Phil Yang , Olivier Matz , Dodji Seketeli , Ray Kinsella Cc: dev , Stephen Hemminger , David Christensen , Honnappa Nagarahalli , Ruifeng Wang , nd , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 16, 2020 at 6:16 AM Phil Yang wrote: > > David Marchand writes: > > > Subject: Re: [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt > > operations > > > > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: > > > > > > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > > > ops which enforce unnecessary barriers on aarch64. > > > > > > Signed-off-by: Phil Yang > > > Reviewed-by: Ruifeng Wang > > > --- > > > v4: > > > 1. Add union for refcnt_atomic and refcnt in rte_mbuf_ext_shared_info > > > to avoid ABI breakage. (Olivier) > > > 2. Add notice of refcnt_atomic deprecation. (Honnappa) > > > > v4 does not pass the checks (in both my env, and Travis). > > https://travis-ci.com/github/ovsrobot/dpdk/jobs/359393389#L2405 > > I think we need an exception in 'libabigail.abignore' for this change. > Is that OK with you? Testing the series with libabigail 1.7.0: Functions changes summary: 0 Removed, 1 Changed (6 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 1 function with some indirect sub-type change: [C]'function unsigned int rte_reorder_drain(rte_reorder_buffer*, rte_mbuf**, unsigned int)' at rte_reorder.c:367:1 has some indirect sub-type changes: parameter 2 of type 'rte_mbuf**' has sub-type changes: in pointed to type 'rte_mbuf*': in pointed to type 'struct rte_mbuf' at rte_mbuf_core.h:469:1: type size hasn't changed 1 data member changes (1 filtered): type of 'rte_mbuf_ext_shared_info* rte_mbuf::shinfo' changed: in pointed to type 'struct rte_mbuf_ext_shared_info' at rte_mbuf_core.h:679:1: type size hasn't changed 1 data member change: data member rte_atomic16_t rte_mbuf_ext_shared_info::refcnt_atomic at offset 128 (in bits) became anonymous data member 'union {rte_atomic16_t refcnt_atomic; uint16_t refcnt;}' Error: ABI issue reported for 'abidiff --suppr /home/dmarchan/dpdk/devtools/../devtools/libabigail.abignore --no-added-syms --headers-dir1 /home/dmarchan/abi/v20.05/build-gcc-static/usr/local/include --headers-dir2 /home/dmarchan/builds/build-gcc-static/install/usr/local/include /home/dmarchan/abi/v20.05/build-gcc-static/dump/librte_reorder.dump /home/dmarchan/builds/build-gcc-static/install/dump/librte_reorder.dump' ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue). We will have no other update on mbuf for 20.08, so the following rule can do the job for 20.08 and we will remove it in 20.11. diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index daa4631bf..b35f91257 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -52,6 +52,10 @@ [suppress_type] type_kind = struct name = rte_epoll_event +; Ignore updates of rte_mbuf_ext_shared_info +[suppress_type] + type_kind = struct + name = rte_mbuf_ext_shared_info ;;;;;;;;;;;;;;;;;;;;;; ; Temporary exceptions till DPDK 20.11 Olivier, Dodji, Ray? -- David Marchand