From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F39BAA052A; Wed, 27 Jan 2021 11:22:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86BCF140CF7; Wed, 27 Jan 2021 11:22:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 85737140CF5 for ; Wed, 27 Jan 2021 11:22:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611742967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTNVng8SgOK1DPd3Q9Ab8UtbRslYsYhN9owRu9UO92E=; b=dcSj+NshZO+ir9U5XcE36LsTAXWm366BKe8RoZBnkgxoA0Olt0WCPJEacQIyv338edYuZs pZKZjv+b4IxI59YUO81RAXOFcmXHEwef+LBA+MExmvdo5Icy1gpjO5zqQvsc9sI3ys163E LYrbOgF4aNGCivfYn2l4mYTpvpCxBPY= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-sgt4OsQ_NoGN3HxxCllIPg-1; Wed, 27 Jan 2021 05:22:46 -0500 X-MC-Unique: sgt4OsQ_NoGN3HxxCllIPg-1 Received: by mail-vk1-f197.google.com with SMTP id c7so187011vkq.18 for ; Wed, 27 Jan 2021 02:22:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yTNVng8SgOK1DPd3Q9Ab8UtbRslYsYhN9owRu9UO92E=; b=AqWnOAj98oT9YC3KMD95RPDARHykdERd9ufM3lx/itSm0A8fg+Tl+TliRzyjYmDG12 /KdumptgPnX7KBTSpM7X8KSmR2WwJw7IXcZ/WzKlaVZDVObcRuuhfIJgsYKDm5rTj1Js 9jvotIVq3Tm9XaGElwxRa1NYjFzIkW6+OuBjbFLa97TT9Zynn7kyl93wKM18LsxkRgqo UyxFQbRhXr7J23Ig9f01njArGXpWzd3nL19b1jjpcy3fBeNQl/pl80w9kmQUzCydgCAE FPzU3+IAQ5vm9OOUrNWZa05H/vT4BDseQV7QdzHL0e+Y4HWwbWcIZpxL7iu9CzpR59GO dTcg== X-Gm-Message-State: AOAM5310WOIftASdp0VOZTPg0QIL+4EpNmEycLO1OfUm6HoLrEGo+YF+ 8Ee0vlcY08iReqE5qC+0L+QGukfjoSFy1abQx6LtBrQVLo0rc+n/p5FfcfmMRn+rgW6Np4Hu23w 012lzGBBRG/iJjwJ9Dy8= X-Received: by 2002:a1f:cec1:: with SMTP id e184mr7391185vkg.17.1611742965597; Wed, 27 Jan 2021 02:22:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZ92F/4uJlSe/BbkuxWayxvNq6QMjXcsLor1Fv+/ReK860+W11lFFWovLIOr9Huq+x+Z2DBH0Qm8NTnHLkVhE= X-Received: by 2002:a1f:cec1:: with SMTP id e184mr7391174vkg.17.1611742965382; Wed, 27 Jan 2021 02:22:45 -0800 (PST) MIME-Version: 1.0 References: <20210115095821.42721-1-joyce.kong@arm.com> In-Reply-To: <20210115095821.42721-1-joyce.kong@arm.com> From: David Marchand Date: Wed, 27 Jan 2021 11:22:34 +0100 Message-ID: To: Joyce Kong Cc: Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , Honnappa Nagarahalli , dev , nd , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 15, 2021 at 10:58 AM Joyce Kong wrote: > > Compiling with "meson build -Dbuildtype=3Ddebug --cross-file > config/arm/arm64_thunderx2_linux_gcc" shows the warnings > "function returns an aggregate [-Waggregate-return]": > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In > function =E2=80=98__cas_128_relaxed=E2=80=99: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20: > error: function returns an aggregate [-Werror=3Daggregate-return] > __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp") > ^~~~~~~~~~~~~~~~~ > > Fix the compiling issue by defining __ATOMIC128_CAS_OP as a void > function and passing the address pointer into it. > > Fixes: 7e2c3e17fe2c ("eal/arm64: add 128-bit atomic compare exchange") > Cc: stable@dpdk.org > > Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob Applied, thanks. --=20 David Marchand