From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6803842969; Mon, 17 Apr 2023 09:33:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E672640698; Mon, 17 Apr 2023 09:33:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 23A4B40144 for ; Mon, 17 Apr 2023 09:33:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681716788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qae50Sh3ijT7aj3DvpSfoDN20y0PWmkGLGiw63e3jJQ=; b=N82x3grZvGeIm4CfTyo0HtZsERDuNFdI5PpuAiPVBI5YBOB6Pw/EU57PYKgHA3llhqaBQU /cUV80VP8xt7Ez+dppDfF2YOQRfAdc6D8o5u27kACzivgBUOSMwNJUuH7cIAPvXcSAg5oR /oNEE+XgK4FFD4Ue06xbB5vl3jkraN0= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-m0YKPSocNf2LzRquUUSsaA-1; Mon, 17 Apr 2023 03:32:27 -0400 X-MC-Unique: m0YKPSocNf2LzRquUUSsaA-1 Received: by mail-pj1-f72.google.com with SMTP id s13-20020a17090a5d0d00b002478f3e8cbfso611557pji.0 for ; Mon, 17 Apr 2023 00:32:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681716746; x=1684308746; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qae50Sh3ijT7aj3DvpSfoDN20y0PWmkGLGiw63e3jJQ=; b=dIo6krMIKhl/ihV5gBTcK2Bw2dkJ3AfrtbkPBqRH1q6PGzAmCbtoYwS5ymrCb2xmwD sKI+09DNvq1pnBl2U/Uuui0fE7RJ4i0na97JuG/HhVMo1o0KF0ElqAUWsz37MrsIG6/U yS5cD8VaZkhY4KW0tLk4E94lJSfSuU6siMrHckS1ZnBIQFyJbnRcNQ6AaAedpZDvoqKO e201ju60SxyZweEubDN9hkTTEmajkLo3pTCObSWBSj1LphqZDRCOkMvVocP5AW6H4ABs nUALIS7Oe8P8ZtvCy2ZdRhWL7Dn3hOUZuwt5SX82kugyWG/t/gA/V4Lkw5Jqt89zjYGR ebBQ== X-Gm-Message-State: AAQBX9fpSY7o3PzPgYt7cWiZrPSNDVMn45r35ka6bo3y/ei6U2OCWhuc kb6YO0SfiehZo86uscksPw/1k2b7yn8egjHYXhpUF4JDDLksAl8EuQmt6OmA+U4uYXRQFQpa+8J W5Ov59VifiWJ9zs2OrzU= X-Received: by 2002:a63:115e:0:b0:51b:70c9:c1df with SMTP id 30-20020a63115e000000b0051b70c9c1dfmr2492109pgr.11.1681716746176; Mon, 17 Apr 2023 00:32:26 -0700 (PDT) X-Google-Smtp-Source: AKy350YzfstIWOtgmsSkdVnGFs20/fwD9riUcHvIOtEEqWhaLKNoPmAIN1JYcScoBrOCDvHNPPR1EoFhQ1Y8RvMPChU= X-Received: by 2002:a63:115e:0:b0:51b:70c9:c1df with SMTP id 30-20020a63115e000000b0051b70c9c1dfmr2492102pgr.11.1681716745874; Mon, 17 Apr 2023 00:32:25 -0700 (PDT) MIME-Version: 1.0 References: <20230228172909.2054386-1-ferruh.yigit@amd.com> <20230414152522.83636-1-ferruh.yigit@amd.com> In-Reply-To: <20230414152522.83636-1-ferruh.yigit@amd.com> From: David Marchand Date: Mon, 17 Apr 2023 09:32:14 +0200 Message-ID: Subject: Re: [PATCH v2] kni: fix build with Linux 6.3 To: Ferruh Yigit Cc: dev@dpdk.org, Vamsi Krishna Attunuru X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ferruh, On Fri, Apr 14, 2023 at 5:25=E2=80=AFPM Ferruh Yigit = wrote: > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > causing a build error. > > `FOLL_*` defines in Linux kernel first moved to another header [1], > later some of them moved to memory subsystem internal header [2] for 6.3 > > `get_user_pages_remote()` already sets `FOLL_TOUCH` internally, > no need to set this flag externally anyway, moving flag from the call > altogether. > > [1] > Commit b5054174ac7c ("mm: move FOLL_* defs to mm_types.h") > > [2] > Commit 2c2241081f7d ("mm/gup: move private gup FOLL_ flags to internal.h"= ) > > Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand Thanks. --=20 David Marchand