From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com
 [209.85.221.182]) by dpdk.org (Postfix) with ESMTP id F277A1B20D
 for <dev@dpdk.org>; Mon, 14 Jan 2019 15:39:57 +0100 (CET)
Received: by mail-vk1-f182.google.com with SMTP id y14so4914438vkd.1
 for <dev@dpdk.org>; Mon, 14 Jan 2019 06:39:57 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=LbwNZcbIAQ8GWPj2mrmh10f6tE+xXC/QGGN0P9uAMtQ=;
 b=AloZMMe6bvcoUGSZKBpJHLZBGqm6iHtIENNS9z2A6YlizcixaI4rKtJkNtYG2uObIH
 +vigW/x1sH9Iet4Uq0+gS4VR6bHdQ58VrRgXu0LLqbOtQ3i36ANu84/PVxzql6acNC+D
 J92yyCmHPAn5m0dcwKv1rWcle/xxOMT18CTcW0b+1QNXqbn8NiA9vqEAu0Kqqo3tlWMT
 ggn3fAsHMTEQoDUKJMx0WL41IrkBfZvP5zRp8GL07JxIJcDOix60u5On8Ye1o745eRaA
 VFMJMmR+Dt568k1mobcfS4kb05SgPXSmF9LAQfMiGeUeqsYUqD93plkfDA/7S6R2jolw
 rcaw==
X-Gm-Message-State: AJcUukcyTfgWCJjDNsWs9KnXhmfFNznN3WkV0fk6f74amH1PNpo+6Hdy
 C/9pp599AnLPRIXHcMCKTKYe3nSNeSimriBagGqvYQ==
X-Google-Smtp-Source: ALg8bN6RveiyBDx4XGxXUfBwl1q9CnRadTehp4XBP4+lvADQDSDsTTH+plh+Y6DFCN88uiEpTfuj3DpzcOavTQUPF/E=
X-Received: by 2002:a1f:b58d:: with SMTP id e135mr9761179vkf.86.1547476797256; 
 Mon, 14 Jan 2019 06:39:57 -0800 (PST)
MIME-Version: 1.0
References: <1547216106-13680-1-git-send-email-hari.kumarx.vemula@intel.com>
 <1547461730-3208-1-git-send-email-hari.kumarx.vemula@intel.com>
In-Reply-To: <1547461730-3208-1-git-send-email-hari.kumarx.vemula@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 14 Jan 2019 15:39:46 +0100
Message-ID: <CAJFAV8x4kJAEnVT6XZpRd8Qqs2LwAWfHMVJ8iB2qZ+NQ=YQROw@mail.gmail.com>
To: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v5] eal: fix core number validation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 14:39:58 -0000

On Mon, Jan 14, 2019 at 11:31 AM Hari Kumar Vemula <
hari.kumarx.vemula@intel.com> wrote:

> diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c
> index 2acab9d69..4dc22ec36 100644
> --- a/test/test/test_eal_flags.c
> +++ b/test/test/test_eal_flags.c
> @@ -18,6 +18,7 @@
>  #include <sys/file.h>
>  #include <limits.h>
>
> +#include <rte_per_lcore.h>
>  #include <rte_debug.h>
>  #include <rte_string_fns.h>
>
> @@ -513,6 +514,16 @@ test_missing_c_flag(void)
>         const char *argv25[] = { prgname, prefix, mp_flag,
>                                  "-n", "3", "--lcores",
>                                  "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"};
> +       /* core number is negative value */
> +       const char * const argv26[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l", "-5" };
> +       const char * const argv27[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l", "-5-7" };
> +       /* core number is maximum value */
> +       const char * const argv28[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l", RTE_STR(RTE_MAX_LCORE) };
> +       const char * const argv29[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l",
> "1-"RTE_STR(RTE_MAX_LCORE) };
>

Please move this block with the other "-l" options.
You can add my Reviewed-by tag with this.


Thanks.

-- 
David Marchand