From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47F81426CF; Fri, 6 Oct 2023 12:07:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1756402A8; Fri, 6 Oct 2023 12:07:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id ADB104014F for ; Fri, 6 Oct 2023 12:07:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696586837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcw3zPxdIFsyYpWFfk8lvTe9vw0na3HHonLubdxY504=; b=P7n6pOcArEO0Kyu2CyCbUTu5coJwGe2YIePbSQyx7UoAH0NbCUiF/Fskl7p+5LuuA4In7V sfZvC6NO3ueyKzyepSuCpAIJb6i1o4/VXU4UYuYQNoadO+Sf5HNt+eKLZCbNpuQQtqe+O7 +u/ATVzJOGacIIpE4cZTuTdxe81VIvQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-mQli3PBiPVi6X9MuJUOhaA-1; Fri, 06 Oct 2023 06:07:15 -0400 X-MC-Unique: mQli3PBiPVi6X9MuJUOhaA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c129cb765bso17168611fa.2 for ; Fri, 06 Oct 2023 03:07:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696586834; x=1697191634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pcw3zPxdIFsyYpWFfk8lvTe9vw0na3HHonLubdxY504=; b=jMHQztRjltbGkTbpeTtQMUKfkEKhybUWiJi9mMlMIPc+DB08/i74qeHjzKAkg4YV2F P8gZ7kZYr2vAqiSxw1tQsPcD28YpMF4xecZj/aKCZcU2Yu0GeEqDzesRAZAqe8UE+xat IvOqS0u/qaX6VN0hud7rfcADKs7c3pj/Sd6xX+PcFzCsFpjyw5iTVbNNoEDTJeIBaWDu v05emnau4lM1pfxZVamDQYoP8bgpOTmdiegTa46saK/lP7V3Oo81aaw6JVM8e0bkvETI YEYLqE7eCzg49PLjILpFYOM1W4GVqGGEGFLZsbvXVFxsCttpW/yBhpGPQK/8mnGpHBFL rVIg== X-Gm-Message-State: AOJu0YwhptMuQwmr/uktWEOrLBfVYI65OCHCpQuYax8Q+Po55/o1mV7t MuuOTP4uJQCfNpY6ojFCg0dH39XEab56Plmh/ByzH+yk2/tb2BeW1nkNenJkqAdh7bMPoFrqQnC 9Nu1fCeVI3w2dnXpwdvY= X-Received: by 2002:a2e:9888:0:b0:2bc:d8cb:5a13 with SMTP id b8-20020a2e9888000000b002bcd8cb5a13mr7332810ljj.42.1696586834435; Fri, 06 Oct 2023 03:07:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHljLBpbz3jCbjos9/NpRTBUiB0Q/LcLe2C/pySZo8dPiR+f0mgm/vErbyMCgrdj4bZQvQYdxzl+i07p2lAUsY= X-Received: by 2002:a2e:9888:0:b0:2bc:d8cb:5a13 with SMTP id b8-20020a2e9888000000b002bcd8cb5a13mr7332794ljj.42.1696586834156; Fri, 06 Oct 2023 03:07:14 -0700 (PDT) MIME-Version: 1.0 References: <20230803162512.41396-1-levendsayar@gmail.com> In-Reply-To: <20230803162512.41396-1-levendsayar@gmail.com> From: David Marchand Date: Fri, 6 Oct 2023 12:07:02 +0200 Message-ID: Subject: Re: [PATCH] gpu/cuda: fix getenv related build error To: Levend Sayar Cc: eagostini@nvidia.com, dev@dpdk.org, Aaron Conole , John Romein X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 3, 2023 at 6:25=E2=80=AFPM Levend Sayar = wrote: > > If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. > This causes gdrcopy.c build to give an error; > because compiler can not find signature of getenv. > stdlib.h is included for the definition of getenv function. > > Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters"= ) > > Signed-off-by: Levend Sayar Applied, thanks Levend. --=20 David Marchand