From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50052A04BB; Tue, 6 Oct 2020 14:38:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7FBB1B3EF; Tue, 6 Oct 2020 14:38:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 1095E2E81 for ; Tue, 6 Oct 2020 14:38:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601987929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lHVm1fpDq6LTMRTEnseJz6oFGhIA74KFJwUC7mGHxZs=; b=Z++2LY7gwGM0SCdw1SMU0V+FN15cp8q1CLeOiR0cuGDXzLIG15EJ8U5VQ0dozoW0ELQ7rX V5LqPBhVd7hcXJQDdPI960waOwYYXBO3zh11RbV0tURF5QqHKK7MohIjj3HA97vParDGv2 AXgCYhbmUMzD4dvyZl+r+TWynla48Fg= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-aokR1qwPNgu90vU9VRu7tA-1; Tue, 06 Oct 2020 08:38:47 -0400 X-MC-Unique: aokR1qwPNgu90vU9VRu7tA-1 Received: by mail-vs1-f69.google.com with SMTP id y6so3880177vsm.11 for ; Tue, 06 Oct 2020 05:38:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lHVm1fpDq6LTMRTEnseJz6oFGhIA74KFJwUC7mGHxZs=; b=DGWLS64VjpvQ4ZDoiuePUe8DqaQPP+wG8+6PZ34RkVrmUkuNVugn1FGtxH6L7Exd99 ESUDZZ6iu+Ga3g3m2bPqtUsJ5tDDVzssmpXiUtuY+3Vgpn+MctvY0k7NR2G16utXSytu oazbzZBry7062jw/oLEmJk8jxLi5cKv2qc5nGvlU29ieDrvVOoC1MhGeZEzJaJhOqcrS IcOZp6+9gcbtf30TYSNHTXBOcMKKtjaLp1I9ABrUqh24cWXAXcvtuGcIu7GRezyz9xtF UibzV6BeKkHmFbiAw2auU4Exe8hPRJuBALdRR9x7WIRDhfBCy43mULbc3LV8szb5mSLy P6yQ== X-Gm-Message-State: AOAM53055meRy2/9pFgrj8uzzCE2MpemVd9CcHLvhyQOHuOe1sPca6lN ZNhVOo8rx3D3gnG/SxbvokZaBTnXAuYI/ruorSoGhp9xdgUB8lQAJ9MNnsXxZ0fYefw6+Hx4mMc BUGgaSZxbYjIfy75Zqag= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr2718149vsp.17.1601987926825; Tue, 06 Oct 2020 05:38:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTpO4NI+ugM8bGiPdhZNku0vgvR/lmotCMVAbEc0uRzXKJ+l1KLLDGCkc9mbmFo83jmSO9LuA+XoMHYTOExPU= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr2718139vsp.17.1601987926596; Tue, 06 Oct 2020 05:38:46 -0700 (PDT) MIME-Version: 1.0 References: <20200921133830.1575872-1-ferruh.yigit@intel.com> In-Reply-To: From: David Marchand Date: Tue, 6 Oct 2020 14:38:35 +0200 Message-ID: To: Rasesh Mody , Ferruh Yigit Cc: Shahed Shaikh , "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] [PATCH 1/4] net/qede: fix build with gcc 11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 25, 2020 at 6:28 AM Rasesh Mody wrote: > >From: Ferruh Yigit > >Sent: Monday, September 21, 2020 6:38 AM > > > >Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 > >(experimental) > > > >build error: > >../drivers/net/qede/qede_main.c: In function =E2=80=98qed_get_current_li= nk=E2=80=99: > >../drivers/net/qede/qede_main.c:587:17: > > warning: this =E2=80=98if=E2=80=99 clause does not guard... > > [-Wmisleading-indentation] > > 587 | if (!ptt) > > | ^~ > >../drivers/net/qede/qede_main.c:590:25: > > note: ...this statement, but the latter is misleadingly indented > > as if it were guarded by the =E2=80=98if=E2=80=99 > > 590 | qed_fill_link(hwfn, ptt, if_link); > > | ^~~~~~~~~~~~~ > > > >Signed-off-by: Ferruh Yigit > >--- > >I am not clear what the exact intention of the original code is, compile= r > >warning is about wrong indentation of 'qed_fill_link(..)', I have update= d the > >code to keep the behavior same but fix the indentation. > >Please send a proper fix if the existing behavior needs to be updated. > > The existing behavior needs to be fixed, I'll send a proper fix for 20.11= . I suppose this is fixed with: https://patchwork.dpdk.org/patch/79562/ I'll mark Ferruh patch as rejected. --=20 David Marchand