From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24423A0093; Mon, 3 Oct 2022 09:17:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C286940695; Mon, 3 Oct 2022 09:17:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8DCEB40693 for ; Mon, 3 Oct 2022 09:17:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664781427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RIiLDEwX4QwOG3gfTFioEJbdYJMYfEO1weC9CRhD44o=; b=TJW26rpDvN1++VQ5nZwC0axKuVERYldnVn3JOG8JqnLFn+FwokdvFcsHjHEWh65CjGRcOQ HzwGza+MCSB1pTGt+SylUUFxNP+bD5tgXlKUW2adLVQSKdWUndNApa8GuC+RJy4vpkKgIs nnWIe/tLAUlMIJkeCxVWrgNMesAddtE= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-390-A-1K9wb5O2eFab-utW69LA-1; Mon, 03 Oct 2022 03:17:06 -0400 X-MC-Unique: A-1K9wb5O2eFab-utW69LA-1 Received: by mail-pg1-f198.google.com with SMTP id a33-20020a630b61000000b00429d91cc649so6472232pgl.8 for ; Mon, 03 Oct 2022 00:17:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=RIiLDEwX4QwOG3gfTFioEJbdYJMYfEO1weC9CRhD44o=; b=qs2y7yQRc4HoyeZgwdyzN3hFHQvRSQUmE2MGHcomaOqGoMZgqVFg808KaW5ruA2Yh0 QYeGOjKZ8xgyEasJtDLISYysfKuoAV1q42+hBd05exwxAPeZo7NOJFAgxs5G9omB9G08 xeTbod8tlDmAVuVUUIxyCKlkJn0MZctNKztyVI3KfB9XOTZGaYwrpic3kPn0QHFmpUn3 DCFNY7brGO7H3D31UNQ6+nwMmWh2Y9P6Dntz+UWKsp8gfC8C2HqHE4aDOriYZvfl3dx9 I88JpSyY/9ntp0l7DnripKL5nhBWugGeVe22KtH3YDByb6we625ggkc55KAVwsVjMRgo H3Qg== X-Gm-Message-State: ACrzQf0OZ6OE2H04JKpNsSILvauOJP0KiIWPUVPdz1Az4udofnH93Rj/ UElcr2rp6ZAUcuKznvP/wysL/rzwjnFVipK/UNm13E7BpvQRBrJ5wKjEr6ReRgZomL3IG70RckU qeBwpxPDftj9Ij/XAM+U= X-Received: by 2002:a63:2a57:0:b0:439:42f4:97e1 with SMTP id q84-20020a632a57000000b0043942f497e1mr17537475pgq.190.1664781425084; Mon, 03 Oct 2022 00:17:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7PxLzlTOf43TMcoJpW7pm5GMaZVuStu1N5MLCEi/9Gd0Hv27uA3ZSetvG6wS6n0wqFdP3GV37KDpWkrJLrTvY= X-Received: by 2002:a63:2a57:0:b0:439:42f4:97e1 with SMTP id q84-20020a632a57000000b0043942f497e1mr17537458pgq.190.1664781424823; Mon, 03 Oct 2022 00:17:04 -0700 (PDT) MIME-Version: 1.0 References: <20220929105101.406724-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Mon, 3 Oct 2022 09:16:53 +0200 Message-ID: Subject: Re: [PATCH] eal: remove panic on remote launch failure To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, Ray Kinsella , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 30, 2022 at 9:17 AM David Marchand wrote: > > On Thu, Sep 29, 2022 at 12:51 PM Bruce Richardson > wrote: > > > > Library functions should not cause the app to exit or panic. Replace the > > existing panic call in the EAL remote launch functions with an error > > code return instead. > > > > Signed-off-by: Bruce Richardson > Reviewed-by: David Marchand There are probably other places to cleanup wrt rte_panic in EAL, but this first cleanup is good and the rest can come later. Added a note in the RN and applied. Thanks Bruce. -- David Marchand