From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E8A0EA0471 for ; Thu, 20 Jun 2019 21:45:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 565E11D445; Thu, 20 Jun 2019 21:45:53 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 8F5551D440 for ; Thu, 20 Jun 2019 21:45:52 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id k9so2294379vso.5 for ; Thu, 20 Jun 2019 12:45:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VZrQkZEtvEyXH+ZDrnTrJbp50g9Z2Ke5LnUvhWy8H6o=; b=oS840WHQN+PFAznBy4lZb9Azq/HkXdHJNLgeJyCDOXU2Y1DR9m0kXtL5wEprU5v0tJ uCY21yPt12dBGMsGy7gkQ54yx/p1A1OiqsXx7zcOvbq7Fh2XjrLa76k/L7++aWAzjZWZ gK/SC5qFprcN8u/1MP71JdQeBn1TBobuHuCmuiDt/nZSHStCkN5dMrR4k0aHKSLaIxdB R2SCUSGYfbhHvWVSVK6C0WFFCQ5t5r+ndCmL1Q4z1AgDy6ePKPLxdUDH35fwxgbLm1Pw FdfXomgbXCrpp4/gFq8UgdF/hQ2MIRRRKcQBnIPdB1s7xSkVsVft0gmEvn/yg/O+jVte ZkDQ== X-Gm-Message-State: APjAAAVLnJDsdMFKD8t31AR1o3BeXCFtpizhTE68COcj4xW0pYRIPgYj H1W1j7PzkAsopnoY6Z54bzX6ZEXDgXDMUU7TFhCJFQ== X-Google-Smtp-Source: APXvYqx942gP9uH25mS+OnGPHFagOxSwBB92TPMQwSdVITZWuMzZFoM81ToPKaumfggZZ8gvXCGeqj/mGYfS2nki7oc= X-Received: by 2002:a67:688f:: with SMTP id d137mr62868009vsc.198.1561059951977; Thu, 20 Jun 2019 12:45:51 -0700 (PDT) MIME-Version: 1.0 References: <20190620164206.3972-1-gage.eads@intel.com> In-Reply-To: From: David Marchand Date: Thu, 20 Jun 2019 21:45:41 +0200 Message-ID: To: Aaron Conole Cc: Gage Eads , dev , Jerin Jacob Kollanukkaran , Van Haaren Harry , Nikhil Rao , Erik Gabriel Carrillo , Neil Horman , Bruce Richardson , Pablo de Lara Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 20, 2019 at 8:26 PM Aaron Conole wrote: > Gage Eads writes: > > > The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), > > and rte_service_attr_reset_all() were introduced nearly a year ago in > DPDK > > 18.08. They can be considered non-experimental for the 19.08 release. > > > > rte_service_may_be_active() is used by eventdev and the sw PMD, and this > > commit allows them to not need any experimental API. > > > > Signed-off-by: Gage Eads > > --- > > drivers/event/sw/Makefile | 1 - > > drivers/event/sw/meson.build | 1 - > > lib/librte_eal/common/include/rte_service.h | 15 +++------------ > > lib/librte_eal/common/rte_service.c | 6 +++--- > > lib/librte_eal/rte_eal_version.map | 6 +++--- > > lib/librte_eventdev/Makefile | 1 - > > lib/librte_eventdev/meson.build | 1 - > > 7 files changed, 9 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile > > index 81236a392..c6600e836 100644 > > --- a/drivers/event/sw/Makefile > > +++ b/drivers/event/sw/Makefile > > @@ -7,7 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk > > LIB = librte_pmd_sw_event.a > > > > # build flags > > -CFLAGS += -DALLOW_EXPERIMENTAL_API > > CFLAGS += -O3 > > CFLAGS += $(WERROR_FLAGS) > > # for older GCC versions, allow us to initialize an event using > > diff --git a/drivers/event/sw/meson.build b/drivers/event/sw/meson.build > > index 30d221647..985012219 100644 > > --- a/drivers/event/sw/meson.build > > +++ b/drivers/event/sw/meson.build > > @@ -1,7 +1,6 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -allow_experimental_apis = true > > I don't think you can remove these. There are still some experimental > APIs (f.e. the rename for rte_cryptodev_sym_session_get_private_data > marked that function as experimental and it will cause build breakage). > > Maybe I'm mis understanding it? It would be good to get verification > from Bruce whether that API should not be marked as experimental (it was > just a rename, so not sure...) - maybe that's a follow up for this > patch? > > See: https://travis-ci.com/ovsrobot/dpdk/jobs/209722145 for an example > > The odd thing is I only see it on the clang builds - perhaps it's a > missing definition for the clang compiler. > Erf, it looks like the __rte_experimental tag is affected by the order in the declaration of the symbol. --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -1245,7 +1245,7 @@ struct rte_cryptodev_asym_session * __rte_experimental * - On success return pointer to user data. * - On failure returns NULL. */ -void * __rte_experimental +__rte_experimental void * rte_cryptodev_sym_session_get_user_data( struct rte_cryptodev_sym_session *sess); With this, I get the proper warning... -- David Marchand