From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70D00A0542; Thu, 10 Nov 2022 17:18:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17FAF4021D; Thu, 10 Nov 2022 17:18:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6D1CB4021D for ; Thu, 10 Nov 2022 17:18:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668097125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v0oRyMHWNxl7XN+Cd4IMENaes4m/iAZVp+81KUWEIeM=; b=MZpD71/ldHQUOc+4pbzPdyRxlGtbQrpJQOShRZmrE5LdN5+As3Ar6lqPdreLY1Uk8NmstW qcHJby469cUbUwusTcgAXhAFskGd6eCon5XAxvn09lQ9o2AwIN//JU+AKy1RkD/wqfgZGW 9I8vR1mpn6ioJP7j5JUQqYXDu/3enmU= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-672-a17syToKMIaqspNEyOKPpg-1; Thu, 10 Nov 2022 11:18:44 -0500 X-MC-Unique: a17syToKMIaqspNEyOKPpg-1 Received: by mail-pg1-f200.google.com with SMTP id k71-20020a63844a000000b004701e90da0dso1224993pgd.22 for ; Thu, 10 Nov 2022 08:18:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v0oRyMHWNxl7XN+Cd4IMENaes4m/iAZVp+81KUWEIeM=; b=vxM+gph3LJIDMri6tQos6jF5ZIebHniYzyRKPHntYnp9fADQEJp4v/0c5FzqO9weuG onqaVYFmnZ2KlwSAL/A5exZeZ6y73Zu58kBfsPsR+GHeJcBuE4EydD8kgF108i4vU3At UpOS+HlJ4G14XCIxJaiRz8EbmlQwjwYNCnrp79XsvNgGvbpFJqBbVCnsFuxY9G4deH8z v9WMYd3cXjDTrdmwyxD9Hxx+byoHz79yUJc1LvK7rqHer/gHgRsucjhXqvwx5mSE+85f dxIYnLs51f9u4GBzRwN6AZGyg99jpsHUEe8Ygcv3H5x/PeTDFwRgeZSX9qwrpv69090D gEOA== X-Gm-Message-State: ACrzQf2WTGg+QDiUqildJpzzO14iPmTsZfQ4xgMWYUO5dI/646YFPH31 iXM0hT09rCPg477mbMQhAioeT8AAqj8OS1wkJv+wBljGa1FJdhmQPUF3zxwFECJm0kEOvgpOaQ/ 5FMb+bi7Ce6fkoPkhnRA= X-Received: by 2002:a17:90a:f0d6:b0:212:c877:e948 with SMTP id fa22-20020a17090af0d600b00212c877e948mr1451926pjb.39.1668097123642; Thu, 10 Nov 2022 08:18:43 -0800 (PST) X-Google-Smtp-Source: AMsMyM5koIafG+IzPJZ+/4IaIQeqgakQN22NK4zlfvU246XqoyM5Vlh58MK/Vg9vNLWmyBAZPn6VDXA8Iqt4dTtHR+U= X-Received: by 2002:a17:90a:f0d6:b0:212:c877:e948 with SMTP id fa22-20020a17090af0d600b00212c877e948mr1451916pjb.39.1668097123337; Thu, 10 Nov 2022 08:18:43 -0800 (PST) MIME-Version: 1.0 References: <20221110130520.15275-1-getelson@nvidia.com> In-Reply-To: <20221110130520.15275-1-getelson@nvidia.com> From: David Marchand Date: Thu, 10 Nov 2022 17:18:32 +0100 Message-ID: Subject: Re: [PATCH] common/mlx5: fix DevX register read error severity To: Gregory Etelson Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, stable@dpdk.org, Viacheslav Ovsiienko X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 10, 2022 at 2:06 PM Gregory Etelson wrote: > > PMD attempt to read HW UTC counter properties can fail because the feature > has no support in port FW or mlx5 kernel module. > > In that case PMD still can produce correct time-stamps if it runs on core with > nanosecond time resolution. > > Fixes: b0067860959d ("common/mlx5: update log for DevX general command failure") > No blank line here. > Cc: stable@dpdk.org > Reported-by: David Marchand > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad I had tested the same change to pass OVS unit tests. I did not hit any other error level messages from functions changed in b0067860959d ("common/mlx5: update log for DevX general command failure"). So I guess only changing this one is enough. Acked-by: David Marchand -- David Marchand