From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36F0AA0C3F; Mon, 28 Jun 2021 11:25:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AF06410F9; Mon, 28 Jun 2021 11:25:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 49DCD4068A for ; Mon, 28 Jun 2021 11:25:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624872332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YiZT46wGx7wGdDAtmKDUdk21up1HdvwmrGZhU4UpgT8=; b=Yw21nNHZYV5xaOBcVjm6j+as8hwygbWxX8GQfDgi8H2DfdnH+ZNNJvj/yQ0cDSptUzqvc8 GwO6ZnTgedhBZX8aZEWtv0s4o2oNAjPTcY5XV/fhvH7ql5a55j62NYkl+BtjYgkPphdOVx AurrbOG8UlXHr5dVjV/iMtN8JEXOqJY= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-r_X5UbRyPMObSf91PNpZIg-1; Mon, 28 Jun 2021 05:25:30 -0400 X-MC-Unique: r_X5UbRyPMObSf91PNpZIg-1 Received: by mail-vs1-f71.google.com with SMTP id i4-20020a67f5840000b0290274a00a20d6so3995475vso.19 for ; Mon, 28 Jun 2021 02:25:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YiZT46wGx7wGdDAtmKDUdk21up1HdvwmrGZhU4UpgT8=; b=cWhiIRAlMzdutFQ5aWXi7gWZ3lQskGochhuPYzV7jm12kp54MmQ29KHAwjD2ZGDHEp rmAsZJYRk3Jyi9hygAb3Xqo7qlnZYeJY4IrCLt8Yr/H0mFoC89/kSueWCwXoXS1/d/1r /eLaX6aWXL8RdOWy0cHelUweJktZ/wCDFhhyxVZH2zJ4P+4d6AVIEEnD2rwg0Sz2CIeu IlsIWsHMAQAT9KxwQ3LKkjxwYGElcZ40y04FIrBvYYOis2C7fm1en9yuo6AQ8C/uRpUa bje3qJSW/NbxaDR5QE9hc3RG33sYR0rwhWHecBiugK5iM0oC840pIGUMUucZJ/mt7g0Q 3sbw== X-Gm-Message-State: AOAM531PIIWeLm8e7WPUKJ+V0MP3IFqsTxBXo4RWZTqO9lHIT2YeqOUA oxGNqsRAUA652O3FyflFF9erprHdGYyfMOUePhErulv2u4CnFxb1hFNpA/McXDxXwECAQpMFvIn S4J4svRJylxyd8CMyG58= X-Received: by 2002:ab0:1484:: with SMTP id d4mr6023642uae.86.1624872329690; Mon, 28 Jun 2021 02:25:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS4W95m8+gV+By3hG64Av9TWWLt3vwFhlmZ9XgXLunNDx9jaxHQuVI/6PRpAw7vOGl184XfrtaSPHid1BUi/M= X-Received: by 2002:ab0:1484:: with SMTP id d4mr6023636uae.86.1624872329481; Mon, 28 Jun 2021 02:25:29 -0700 (PDT) MIME-Version: 1.0 References: <20210628090834.71199-1-winsome8282@163.com> In-Reply-To: <20210628090834.71199-1-winsome8282@163.com> From: David Marchand Date: Mon, 28 Jun 2021 11:25:18 +0200 Message-ID: To: RickZhong Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] fix l2fwd --no-mac-updating not working issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 28, 2021 at 11:09 AM RickZhong wrote: > > The original disable mac updating codes were removed by mistake. > > Signed-off-by: RickZhong > --- > examples/l2fwd/main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index 32d405e65..69d0087dc 100644 > --- a/examples/l2fwd/main.c > +++ b/examples/l2fwd/main.c > @@ -491,6 +491,10 @@ l2fwd_parse_args(int argc, char **argv) > timer_period = timer_secs; > break; > > + /* no-mac-updating */ > + case 0: > + break; > + > /* long options */ > case CMD_LINE_OPT_PORTMAP_NUM: > ret = l2fwd_parse_port_pair_config(optarg); This issue should be fixed with these patches: http://patchwork.dpdk.org/project/dpdk/patch/20210622024706.1179945-1-sunchenglian@loongson.cn/ http://patchwork.dpdk.org/project/dpdk/patch/20210622024944.1180109-2-sunchenglian@loongson.cn/ Can you test/review them? Thanks. -- David Marchand