From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41822A0093; Fri, 22 May 2020 09:47:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 198B51D924; Fri, 22 May 2020 09:47:20 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 4D3AA1D91C for ; Fri, 22 May 2020 09:47:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590133637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MdFKbACy1pLnxW3FwbKbQnWn4TvCD99q2VQeHO31o4g=; b=L5klOaYos12QiOwPF/BnLoC5dYoLl6urK9nLoSGEMyxvwJzqzhkZOd5/4MpB698P7FoGbs FvqIw3IlLrEdpbeLpGcpmSvuwljuWP81PNH/8Iur3yT1pcxQ2Yj/VC+e6KBGOYsbEalIPh oKOvSqU0isUX0BB7wKi1fKP/s8TDfr4= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-W4ziAGaxNnWhf2NJ_VLl4Q-1; Fri, 22 May 2020 03:47:16 -0400 X-MC-Unique: W4ziAGaxNnWhf2NJ_VLl4Q-1 Received: by mail-vk1-f198.google.com with SMTP id u79so3905761vkb.16 for ; Fri, 22 May 2020 00:47:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MdFKbACy1pLnxW3FwbKbQnWn4TvCD99q2VQeHO31o4g=; b=pB9mpRwijgzYJW76VMSaZsFAXIpC4EwO/fseB6UgTU63sftK3c3yX6MzKZ1gBHQZlW uwBhYHZnjHgeHdQorGQoOIpfpbjXvoXX3Sh6E7/qmderDMOKmAdOYb1Qf7ruSClPLZ0j +SUIzFy8Ydb+GawKb+DQXFyow5qHqPmnoYkH3BF8S3R9No0h8jlAg8wNGBGBYUoHRvtw IZVXQow6ddWchhG9NDxLbsPjIZLFh6hjb44B5E2jV4H2es6rElyf0AoNPxc173JmK3CW XN7iOL3J6fGEnxHDziy6lniNK2RfnEx6pkXxNXVUAKGuL9TiGnrnsnbeJskGhbwTRRhL TlMw== X-Gm-Message-State: AOAM531WYowdn2vDaXNbIOq2YjqtMtmYRTe5QYA/UPcYuTMlZMs1Ksui G79wsOHe2y8a+Zunkz+UcYckF8xu4dRXQDA1OSlW5Z43GloYsMd7uQePZkaFXCiq+luzi7pQcoQ fGsZqaPnKIwEBx5OejM4= X-Received: by 2002:a67:7d81:: with SMTP id y123mr10250012vsc.105.1590133635621; Fri, 22 May 2020 00:47:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYEtOXTQuoFEUL7H6iuIjRor6S2lFxWDRuF9OXige4UFih1R2dWoC55N+bBhEmV7d9lWExX9xLHtBnNGjHa98= X-Received: by 2002:a67:7d81:: with SMTP id y123mr10250000vsc.105.1590133635326; Fri, 22 May 2020 00:47:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Fri, 22 May 2020 09:47:03 +0200 Message-ID: To: Jerin Kollanukkaran , "Richardson, Bruce" , "ciara.power@intel.com" Cc: "keith.wiles@intel.com" , Thomas Monjalon , dpdk-dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] No telemetry legacy support print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran wrote: > > "No telemetry legacy support " prints pops up on all the default dpdk applications now. > Is it worth to print? Since it using direct 'printf', we cannot even disable through dynamic logging. > Is possible to remove that print at least, if non legacy telemetry init is successful. > Thoughts? This init function is odd as it calls printf in error and warning cases and sets an error string when it succeeds. Let's remove the two printf in this init function. If we really care about the warning message, we have to initialise *err_str to NULL (+ this must be described in the function prototype). In EAL init, we can then add a rte_eal_init_alert with the error string when telemetry init fails and maybe a warning message if err_str != NULL. -- David Marchand