From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEB1CA04C4; Wed, 20 Nov 2019 23:52:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C8E09E4; Wed, 20 Nov 2019 23:52:44 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id A4A982AB for ; Wed, 20 Nov 2019 23:52:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574290363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xewBBl2n7KPs8aK9bibMY1qzmkpvXbktYekUyGzsjMg=; b=bzs+druWIGYc8Dlcaylqr0RMAPdkOXoki0ed5QjCaG2utiYD8WBPysHcBMCM9wcsrnmn1r 0ACVJ6vB1T0Ew8sJNpO7Kl6ZQ3ozbWfIsBiBWchMLSHbx0PNv5nVfRvL2sqNP7tNPUfwbU VEAwzpEIU1jMS4QvFaH7W/U+LHorO/w= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-xcN-glQDPgWUlwYGGC3ALw-1; Wed, 20 Nov 2019 17:52:39 -0500 Received: by mail-vk1-f199.google.com with SMTP id x65so516186vkd.15 for ; Wed, 20 Nov 2019 14:52:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xewBBl2n7KPs8aK9bibMY1qzmkpvXbktYekUyGzsjMg=; b=ILt8q5OtKXta2cRe+g/xtzLOjg+BjMuvG7vToy96ZKkrGMidvoEdtef79xQmM6z4PQ ndytln9IVOoRE8FcAKTANl4FQoTrclhqE4KDjzoQIBXOlz2lEpN8V2H/lfkNniMNAwwU 8EqL+Fr+gAj/A6PRA/IcIR5XfVfIUCVrbBaU/6Dm7dSp7tbXL2I9bJj+l9lO/UaC1Kko kY2bvnE5TZovWs4pEUZ8RV6wK71LarHt4i27WSBCgg8lTCK3Zx0TZqpcFq0E/zTxj4vh snPlS9dYTwCdIKbMfA9+YvyHiIkDhD756PDEv13eI+5WSYsn63oGyT8T1/z2FDH4IXGp EDMg== X-Gm-Message-State: APjAAAXAs2O84GFoJe11bjWRvtgKJHgU21ExZ2gt4FjQ6MYEq6wpqGrf RNT2DCaFD3c9uUILyOUDcz0ouB5oVyoUblT1er8eOB9KU9BpiL1ZceeoMUbXLzEEJZOniH5/xO6 6XFvmbEcvtAUZDFh6yOM= X-Received: by 2002:a1f:60ce:: with SMTP id u197mr3517909vkb.80.1574290358751; Wed, 20 Nov 2019 14:52:38 -0800 (PST) X-Google-Smtp-Source: APXvYqx0ESlMZuPnFMfb7rpLtatgR6FINBTH0Ou1XDkn6G4K+Pw1V+eomoX4oylkyqxQ5xLoK20KTnF0sf45+Z1wMrE= X-Received: by 2002:a1f:60ce:: with SMTP id u197mr3517888vkb.80.1574290358351; Wed, 20 Nov 2019 14:52:38 -0800 (PST) MIME-Version: 1.0 References: <1573548459-6931-1-git-send-email-matan@mellanox.com> <1574243271-27734-1-git-send-email-matan@mellanox.com> In-Reply-To: <1574243271-27734-1-git-send-email-matan@mellanox.com> From: David Marchand Date: Wed, 20 Nov 2019 23:52:27 +0100 Message-ID: To: Matan Azrad Cc: dev , dpdk stable , Thomas Monjalon X-MC-Unique: xcN-glQDPgWUlwYGGC3ALw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/pci: fix driver detach clear X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 10:48 AM Matan Azrad wrote: > > When a rte_device is unplugged, the driver should be detached from the > device. > > The PCI detach driver operation wrongly didn't clear the driver from the > device structure what remain the device in probe state from the EAL > point of view. > > For example, when a device is removed twice using rte_dev_remove, it > cause a crash in EAL. > > Clear the driver in driver detach successful operation. > > Signed-off-by: Matan Azrad Acked-by: Thomas Monjalon Applied with updated commitlog. Thanks. -- David Marchand