From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C15E0A0561; Mon, 20 Apr 2020 09:14:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B2C81C10C; Mon, 20 Apr 2020 09:14:39 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 459981C0D1 for ; Mon, 20 Apr 2020 09:14:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587366877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=asWWNZvvN+WTu8yyNys/BKzAaOwZvk/9SHVVZGHy+YU=; b=HBQw+ftmXCcxz9d2er0wJNmN7IMRV7iFrD+/tp8u7gf4jQkRa007czYi9MDtc8lc5D2VH4 LOL3vE2h/QRFXL4xG1pMGEifKHWzpNhS/xjOC25iXnCSVjxvfoQ66ZjeKOrlmRhMEJQIFz vK/qdb5DFRQZ0bXOPX9huXKbI3ZqmnI= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-Fa5aRJRqM-e8SRLeNiufXA-1; Mon, 20 Apr 2020 03:14:35 -0400 X-MC-Unique: Fa5aRJRqM-e8SRLeNiufXA-1 Received: by mail-ua1-f70.google.com with SMTP id z20so450650uag.19 for ; Mon, 20 Apr 2020 00:14:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tdDHiDmruKG6rhZQVJ8Xg42LWQbIoe4h75U+fezhPc=; b=TqxMZf/5bMAZvAfddkW58oBxq/h/92J/7ZFXq03shLI/KuF/ttzy+hXtp+JD84rVg8 HahdA4746kRRlKjGY/Z6haEyPxr0Z8WDYrIJ0CQT8j0uBG26S/NqXFy135H8/Zd8qpN4 qY0oDfcDenGyfKYJC+KAdYzNE0eDM3DrN3YbO1bI79FNtprcZALFla80WpXvpToZ65KW msL3u/PEDbdFCUeCQN9/f86EhtYSWoGNgZCQIFdxGUIQ8v4nmJmALwVCdZfoAzLyuve4 0CxoTKlR5wUIGWrpkY/94wIvCk9zh7lGk6p3HG6azOR9yvG/HUETGrFmwqsFEaLCK49J 4Thw== X-Gm-Message-State: AGi0PubcRu18VSJg6KZFrefSaqZe8cv9HcQP4bArPkdVR9qYdfM3Ct/z qCcmUqW04ToIshWmUEZP0Xwlvdz/F8RZpbyi3lQDupZ7/3Q5i00W4+wUHzsf6FppSj1Ve4rZiqc qqtevQRVh3P4bHzLpDW8= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr4480467vkd.18.1587366875254; Mon, 20 Apr 2020 00:14:35 -0700 (PDT) X-Google-Smtp-Source: APiQypL3w+UXJkKEaZsdzT/U7JTutfg5RhDqjUYfWZwnPwNxt/A47SiNUVxSxVPirCxowCfIWqZRjgLQp7GI2i8BhvE= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr4480460vkd.18.1587366875008; Mon, 20 Apr 2020 00:14:35 -0700 (PDT) MIME-Version: 1.0 References: <20200420062638.80181-1-ajit.khaparde@broadcom.com> In-Reply-To: <20200420062638.80181-1-ajit.khaparde@broadcom.com> From: David Marchand Date: Mon, 20 Apr 2020 09:14:24 +0200 Message-ID: To: Ajit Khaparde Cc: dev , Raslan Darawsheh , Lance Richardson , Somnath Kotur X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix CLANG compilation error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 20, 2020 at 8:28 AM Ajit Khaparde wrote: > > Fix a compilation error seen with CLANG. > The current code causes a typedef redefinition error because > 'p__LINE__' is a C11 feature. Fixing it by defining it to something > which is not already defined in the language. Can't you reuse the RTE_BUILD_BUG_ON macro instead of redefining this in your driver? If the EAL macro is not enough, I suppose we could improve it. --=20 David Marchand