DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable
Date: Sat, 2 Oct 2021 11:34:41 +0200	[thread overview]
Message-ID: <CAJFAV8x9kr8TUGLzsVgem4CBOWPuhytRykv767A3zwFPzukg5A@mail.gmail.com> (raw)
In-Reply-To: <20210831193507.43426-4-stephen@networkplumber.org>

On Tue, Aug 31, 2021 at 9:35 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> This function should be made stable now.
>
> Also, fix the docbook comment format.
>
> Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value")
> Cc: konstantin.ananyev@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/mbuf/rte_mbuf.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 7722b36ee44b..627790fe26e7 100644
> --- a/lib/mbuf/rte_mbuf.h
> +++ b/lib/mbuf/rte_mbuf.h
> @@ -1773,7 +1773,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail
>         return 0;
>  }
>
> -/*
> +/**
>   * @warning
>   * @b EXPERIMENTAL: This API may change without prior notice.
>   *
> @@ -1797,6 +1797,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf *head, struct rte_mbuf *tail
>   * @return
>   *   raw tx_offload value.
>   */
> +__rte_experimental

From title and description, I would expect we remove
__rte_experimental tag, not add one.
Can you clarify the intention?


>  static __rte_always_inline uint64_t
>  rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t tso,
>         uint64_t ol3, uint64_t ol2, uint64_t unused)
> --
> 2.30.2
>


-- 
David Marchand


  parent reply	other threads:[~2021-10-02  9:34 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 15:52 [dpdk-dev] [PATCH 0/2] mbuf: unmark experimental API's Stephen Hemminger
2021-08-25 15:52 ` [dpdk-dev] [PATCH 1/2] mbuf: take experimental of mbuf copy and bulk free Stephen Hemminger
2021-08-25 15:52 ` [dpdk-dev] [PATCH 2/2] mbuf: remove experimental from dynamic field support Stephen Hemminger
2021-08-25 22:09 ` [dpdk-dev] [PATCH v2 0/3] mbuf: experimental tag changes Stephen Hemminger
2021-08-25 22:09   ` [dpdk-dev] [PATCH v2 1/3] mbuf: take experimental of mbuf copy and bulk free Stephen Hemminger
2021-08-25 22:09   ` [dpdk-dev] [PATCH v2 2/3] mbuf: remove experimental from dynamic field support Stephen Hemminger
2021-08-25 22:09   ` [dpdk-dev] [PATCH v2 3/3] mbuf: mark function rte_mbuf_tx_offload with __rte_expermental Stephen Hemminger
2021-08-31 19:35   ` [dpdk-dev] [PATCH v3 0/4] mbuf: promote experimental API's to stable Stephen Hemminger
2021-08-31 19:35     ` [dpdk-dev] [PATCH v3 1/4] mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's Stephen Hemminger
2021-09-01  6:42       ` Andrew Rybchenko
2021-09-16 11:55         ` Olivier Matz
2021-08-31 19:35     ` [dpdk-dev] [PATCH v3 2/4] mbuf: make rte_mbuf_dynfield API's stable Stephen Hemminger
2021-09-01  6:43       ` Andrew Rybchenko
2021-09-16 11:56         ` Olivier Matz
2021-08-31 19:35     ` [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable Stephen Hemminger
2021-09-01  6:45       ` Andrew Rybchenko
2021-09-01 17:14         ` Stephen Hemminger
2021-09-16 12:14         ` Olivier Matz
2021-10-02  9:34       ` David Marchand [this message]
2021-08-31 19:35     ` [dpdk-dev] [PATCH v3 4/4] mbuf: make rte_mbuf_check part of stable API Stephen Hemminger
2021-09-01  6:46       ` Andrew Rybchenko
2021-09-01  6:49         ` Andrew Rybchenko
2021-09-16 12:35           ` Olivier Matz
2021-10-04 19:32 ` [dpdk-dev] [PATCH v4 0/5] mbuf: promote experimental API's to stable Stephen Hemminger
2021-10-04 19:32   ` [dpdk-dev] [PATCH v4 1/5] mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's Stephen Hemminger
2021-10-04 19:32   ` [dpdk-dev] [PATCH v4 2/5] mbuf: make rte_mbuf_dynfield API's stable Stephen Hemminger
2021-10-04 19:33   ` [dpdk-dev] [PATCH v4 3/5] mbuf: make rte_mbuf_check part of stable API Stephen Hemminger
2021-10-04 19:33   ` [dpdk-dev] [PATCH v4 4/5] mbuf: make rte_mbuf_tx_offload as stable Stephen Hemminger
2021-10-05  7:27     ` Olivier Matz
2021-10-05  8:17       ` Ananyev, Konstantin
2021-10-04 19:33   ` [dpdk-dev] [PATCH v4 5/5] mbuf: mark rte_mbuf_to_priv " Stephen Hemminger
2021-10-05  7:31     ` Olivier Matz
2021-10-05  8:20   ` [dpdk-dev] [PATCH v4 0/5] mbuf: promote experimental API's to stable David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8x9kr8TUGLzsVgem4CBOWPuhytRykv767A3zwFPzukg5A@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).