From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CF94A0093; Thu, 10 Mar 2022 16:32:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A68534113F; Thu, 10 Mar 2022 16:32:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id ACCB84113E for ; Thu, 10 Mar 2022 16:32:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646926361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i8Zh9QalAetHKv30uIXAe1FjGByyccVGmvXgtksmtSQ=; b=ROLw1Wl0HUcx3fhmWNQ1mvNXYfhltslsYpshzMQ3ND0By21anJBV4sQxcG2BSveuNgtyqb 35IkyuoaaVmpS65hXMDUM6TBajiWqpFvrCgGvRZ5JtM6F2H1ktT0kA9pAD9UXRRsy68YmT SYRSRY+jCzWss4q/+b3aVUbapfoBcAg= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-198-wFLDB4kpOAC1RYyH7IUFsQ-1; Thu, 10 Mar 2022 10:32:39 -0500 X-MC-Unique: wFLDB4kpOAC1RYyH7IUFsQ-1 Received: by mail-lj1-f199.google.com with SMTP id bd5-20020a05651c168500b002467c7cdfb2so2445799ljb.16 for ; Thu, 10 Mar 2022 07:32:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i8Zh9QalAetHKv30uIXAe1FjGByyccVGmvXgtksmtSQ=; b=GVTGibguuU7CcVcUKujmEcKTRuDYdShb+1hARiVDRuZ6pZgrUjzb43luCztEJsbk0E JP83x8n+pb8lBj8YBhfW7Al+W1hc8S2bTGVFae79O5O5WIHQWS65SQ4m9H6rmgSJQlC1 IZavevo9KVn858OoAEeSQX0x3ELJKoqO9Seu1lfXM5DapVIFciVXxdk8u1z5Myv2XJQb YZfLtn17dpMGQfrv7jW/YprVcJODxJfbh1L0GGfo0yzfC8s8CfaacRmkvXaLGi/LyXoj NYugRmkgam6KmjMsyAygFHnml9jFV+arXfCmrnEjKtydDdcPJ4PC8GoqtJ/DIc0vBz+Q gRPQ== X-Gm-Message-State: AOAM532uvQ+jZw1wwMiNQPGCuNkraU45jukddo5rDNkB/UqaGzn9JU38 db0gMV/0YZfEnqC2sYuUXz5Qjl0z6ISWtO2fT68/DnfD4Iafmp5dDdyW6APH/TO3OKFkkxbLrco 7rIH4Mn+Ci9I952ASEGg= X-Received: by 2002:a2e:9997:0:b0:247:ec9c:8efb with SMTP id w23-20020a2e9997000000b00247ec9c8efbmr3259878lji.297.1646926358340; Thu, 10 Mar 2022 07:32:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYnJPGBjKr2ISpM+pPy+jhB/JUPUkchOqEld+1FebrkIiC3Jvv8UQoNEb+WTwUDX8Pn3mluAgnmDPbCH3m5X0= X-Received: by 2002:a2e:9997:0:b0:247:ec9c:8efb with SMTP id w23-20020a2e9997000000b00247ec9c8efbmr3259865lji.297.1646926358104; Thu, 10 Mar 2022 07:32:38 -0800 (PST) MIME-Version: 1.0 References: <20220310125059.30562-1-david.marchand@redhat.com> <20220310125059.30562-2-david.marchand@redhat.com> <6f056e81-07c9-d20f-47a2-f76fc51322c8@redhat.com> In-Reply-To: <6f056e81-07c9-d20f-47a2-f76fc51322c8@redhat.com> From: David Marchand Date: Thu, 10 Mar 2022 16:32:27 +0100 Message-ID: Subject: Re: [PATCH 2/2] vhost: fix FD leak with inflight messages To: David Marchand Cc: dev , Maxime Coquelin , "Xia, Chenbo" , dpdk stable , leonwxqian@gmail.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 10, 2022 at 2:00 PM Maxime Coquelin wrote: > On 3/10/22 13:50, David Marchand wrote: > > Even if unlikely, a buggy vhost-user master might attach fds to inflight > > messages. Add checks like for other types of vhost-user messages. > > > > Fixes: d87f1a1cb7b6 ("vhost: support inflight info sharing") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin Series applied, thanks. -- David Marchand