From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1064A0350; Mon, 11 May 2020 15:59:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A57611C1BD; Mon, 11 May 2020 15:59:06 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 901FC1C1BC for ; Mon, 11 May 2020 15:59:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589205543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6r4oaseMxDSY6xxHlO/XrYNeTW4Oo9LSjYfe8RFfaz8=; b=bnXry4NxtiM2ANPPpuK4YKnRQlumqdtLViLiEb7InEhxOzpfxIcMp5+yD+Kf5ETw6WtAWR OPYtXsdSnzU89M24n8EXMTGACBz2RUkD4BdknljJRSfxxsjlhYDuPbRL+J36rfsNYUsuem haKp1j8uDEvlMol2Kv4H7akKqVjpVc4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-DWXXGgY8PQ2JR8DdZ6lXRw-1; Mon, 11 May 2020 09:58:59 -0400 X-MC-Unique: DWXXGgY8PQ2JR8DdZ6lXRw-1 Received: by mail-vs1-f71.google.com with SMTP id s25so1402502vsn.11 for ; Mon, 11 May 2020 06:58:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6r4oaseMxDSY6xxHlO/XrYNeTW4Oo9LSjYfe8RFfaz8=; b=jOiqcEhgH7mOen9VyHAr1JwkUHYq36vI1KO7fey1f2jLN7LdetuUMq17Y08eC1GUZ1 IjF7yfTbn36IJSvAlu9cLOWJJvmNVVtdBjWg6ptDLW2RazK7enPMx8TgEEMo1mEU/24B bMCjZ0/utzu0vvbpg3k2ZtA1TzGN+Bw3EnsFsuDbypA7rB1m8qnnun5PD2u44NdWWpRH UMbdFE0Ftuei0uYyBh2ubtGngI4N3sJQtdXFTv6z0UEy6Wb2pYbNlxVHtLlN9OVTl80A kFbDgiJmrUhS+jas/+i9TVvBGxwYoxvZ3otLxVfkDAKcdld7wZEOECsXooZalRhT/N6H +SFQ== X-Gm-Message-State: AOAM531XdjNy5U9uz7fmHfX/bojcLU+DkxDs3HNlqB1uvUWFK+H1wIkg HH2OyS9byV9zRuB/vfnx5xG++scf4rXRTXMWOKAh2tSwrpbhxWzfvJSKjC/mqkMTReoUdSH4i+3 McAouJ3pzkn5aLlVIfyM= X-Received: by 2002:a9f:300c:: with SMTP id h12mr6201417uab.86.1589205538770; Mon, 11 May 2020 06:58:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzjluo2nYRyQxqMAWsigbylRm3olp6CNRm+7cPHF4/ucBo3KCTd4//MiiFpYxMY5j7qoGZvsl5BeofiWrLInM= X-Received: by 2002:a9f:300c:: with SMTP id h12mr6201400uab.86.1589205538447; Mon, 11 May 2020 06:58:58 -0700 (PDT) MIME-Version: 1.0 References: <20200511133212.21444-1-david.marchand@redhat.com> <20200511134734.GD1957@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200511134734.GD1957@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 11 May 2020 15:58:47 +0200 Message-ID: To: Bruce Richardson Cc: dev , Kevin Laatz , Ciara Power , Keith Wiles X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 3:47 PM Bruce Richardson wrote: > > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > > telemetry can not depend on EAL anymore but it still wants to get arch > > headers. > > We directly point at the right source directories by using the same logic > > than EAL. However the special case of armv7 has been missed. > > > No objection to the fix, but why is ARMv7 needing special treatment? For ARMv7, RTE_ARCH == ARCH_DIR so it is not set in mk/arch/* but a default value is still set in EAL makefiles. We could hide this in rte.vars.mk so that other components' makefiles do not have to care about it but I went with the quicker fix. -- David Marchand