From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C763A056A; Fri, 6 Mar 2020 11:12:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D72691BFE1; Fri, 6 Mar 2020 11:12:25 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id C9DF81BFCD for ; Fri, 6 Mar 2020 11:12:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583489543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dr4VIm/EIKyHXMcNbyKTFtXXl/iNUgcl07dVJcSRR+E=; b=aDohVGYAg6iRLDzcMpnOOLlISHu4G8jLXwjEmC3Y1qKHgdzfLfDJBm9RNwFdcjUnASjE2z bSW0aWGYVtxxp6/k7hrrQzbZZjzWS+BaB3Go8AAUIJEWTRBchj90LHRMvStBBw5L77xK0W i/6dyfJvsW3feolNFRh1L88dDRYpTwE= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-Dx7IFVBDOVa_ksoSe6IYlQ-1; Fri, 06 Mar 2020 05:12:20 -0500 X-MC-Unique: Dx7IFVBDOVa_ksoSe6IYlQ-1 Received: by mail-vk1-f197.google.com with SMTP id h26so630006vkn.4 for ; Fri, 06 Mar 2020 02:12:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7H7et0rgXe/IYWIELj2qp6XK+TxMUbg2jnNQA4Zd/Tc=; b=BS+Ef3Fw5sPbNaCgL4psam8pNQ68TgoKBwDVBeok1hwuGicUSZQChZga3TgcDm3/jZ 8V6LGlLyODO+9x4covnFQ1ISzDxlAL0zHPyFav7wZWncsbrULXVLE+yzOb7msv8GZwDZ 32tkIew0ewTVfcY/bcgWZD8BJE1CXtlHRvJ0QyezbZCkj4KscEYCcxuKBVh09Qo5faDp 4gXS10eNOfeIffdbZaKGGgWc0oLnj3h8wdoXF4BOFZBBFC5ZzsNobvGVG4ATBi8RDQd4 FAN2pZdt8Z9XHGYwDN9tF6yjORBDJ6jKk/R3A0/Qtjp2Ls/55ZIE37C+rfJkjxDrnGai 0E/A== X-Gm-Message-State: ANhLgQ3CNdjEZGxyUyKRENGp2t2sYB+a7oNDJu2ro5gX9Ol3b+S5mANj a/GNKz9oUSv1n1F4nwMR4jxexYIngQel6ImEkMGEqhh0i9dzsFpoTFBGTEzB9ePoRbfR1m3oqhJ 7/VOZ/COfNBFi82c18/0= X-Received: by 2002:ab0:6796:: with SMTP id v22mr1177105uar.41.1583489539442; Fri, 06 Mar 2020 02:12:19 -0800 (PST) X-Google-Smtp-Source: ADFU+vvxARScg7MvrcYCOFwyyxc9z0s6NfTvc08TG3An3+yxag64JFsnThAp9SupRf95gVrlsj2OqaZniyHvITjkbvg= X-Received: by 2002:ab0:6796:: with SMTP id v22mr1177083uar.41.1583489539039; Fri, 06 Mar 2020 02:12:19 -0800 (PST) MIME-Version: 1.0 References: <20200302145829.27808-1-hemant.agrawal@nxp.com> In-Reply-To: From: David Marchand Date: Fri, 6 Mar 2020 11:12:07 +0100 Message-ID: To: "Hemant Agrawal (OSS)" Cc: "Yigit, Ferruh" , dev , Neil Horman , Thomas Monjalon , Dodji Seketeli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 5, 2020 at 10:19 AM Hemant Agrawal (OSS) wrote: > > On Thu, Mar 5, 2020 at 10:06 AM Hemant Agrawal (OSS) > > wrote: > > > > > > Hi David, > > > > On Mon, Mar 2, 2020 at 10:26 AM Hemant Agrawal > > > > wrote: > > > > > > > > > > This patch series add various patches for enhancing and fixing NX= P > > > > > fslmc bus, dpaa bus, and dpaax. > > > > > > > > > > - the main change is support to allow thread migration across > > > > > lcores > > > > > - improving the multi-process support > > > > > > > > This series triggers an ABI warning that must be investigated. > > > >https://travis-ci.com/ovsrobot/dpdk/jobs/292904119#L2233 > > > > > > [Hemant] > > > As per the logs: > > > > > > Variables changes summary: 1 Removed, 2 Changed, 0 Added variables > > > 1 Removed variable: > > > 'dpaa2_portal_dqrr per_lcore_dpaa2_held_bufs' > > {per_lcore_dpaa2_held_bufs@@DPDK_20.0} > > > 2 Changed variables: > > > [C]'dpaa2_io_portal_t dpaa2_io_portal[128]' was changed at > > dpaa2_hw_dpio.h:40:1: size of symbol changed from 5120 to 2048 > > > [C]'dpaa2_io_portal_t per_lcore__dpaa2_io' was changed at > > > dpaa2_hw_dpio.h:20:1: size of symbol changed from 40 to 16 > > > > > > Error: ABI issue reported for 'abidiff --suppr devtools/libabigail.ab= ignore -- > > no-added-syms --headers-dir1 reference/usr/local/include --headers-dir2 > > install/usr/local/include reference/dump/librte_bus_fslmc.dump > > install/dump/librte_bus_fslmc.dump' > > > > > > --------------- > > > > > > These changes are w.r.t modifications in internal structures and vari= ables. > > They may be ignored. > > > > The ABI check considers symbol exposed in headers available to final us= ers. > > If those are internal, why are the headers public? > > > > [Hemant] These symbols are not part of any public header files, but they= are part of *.map files to share them between different driver libs i.e bu= s_fslmc and net_dpaa2 I would expect libabigail to skip those symbols, so there is something I have missed in how --headers-dirX work. Anyway, all of those symbols in dpaa are part of the driver ABI. We are still missing a way to mark internal symbols. Neil had posted a framework for this http://patchwork.dpdk.org/project/dpdk/list/?series=3D5004. In order to get this series passing the checks, I recommend NXP rebasing Neil scripts (I will help reviewing this part), then mark all those symbols as internal in its drivers. Other vendor will convert their drivers later, as there is no need at the moment. Thanks. --=20 David Marchand