From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 025E3A0562; Wed, 14 Apr 2021 22:57:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 717ED161D13; Wed, 14 Apr 2021 22:57:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0FF69161D12 for ; Wed, 14 Apr 2021 22:57:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618433834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GqmQDUvSFScPpcd7hWnmmm2BX+GFqOTNexG7qb7KOc0=; b=MEQrJ5iNOQYEdWELUoes6vA1YjiXjhHBW1IsVUWbxV4tgb8hsZEknoh4+67NtIwlBEA+nt 9w7rMoyj03RSfUkYHz24fcWJIoy+e0BGrGgX/EfQe1zLQd4Rngq2EgwMkyrTcAFV+KPEWL DZK3fcXabF04oMPmWHOJ0b4Q0J4skdE= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-452-oZOQDjX3PKe4X2iht-mPUg-1; Wed, 14 Apr 2021 16:57:13 -0400 X-MC-Unique: oZOQDjX3PKe4X2iht-mPUg-1 Received: by mail-vk1-f198.google.com with SMTP id r13-20020a1f2b0d0000b02901d8b51bffc5so906906vkr.9 for ; Wed, 14 Apr 2021 13:57:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GqmQDUvSFScPpcd7hWnmmm2BX+GFqOTNexG7qb7KOc0=; b=r3QI0MUqkbhoMxs4q7T8CyT6KZ8I51cu9g4kf1szTAPoId6X37dTDRYSQCI11OLtRt nGfTyjYtIUNGqDUvcvro1w2kG2IYficLG91CPeANs+Eqh6ztlOs9NmPPRL0xPqUsCAr9 O1lzu/LGmYzbrF7L+bPj6X2j8FwQvPDpxAinCwIQvz9XLLKhBlhl663hK6Pff9oXZmSY ydob5GMNGwUVsBOaj6Wz0+DKIk8kiOAMessY8kdxeqwoXYRfx1QPfN7ndA/suOGiJqCk MUZj4jSfoprfycB9th1uhjYCDTqjOppucYRLQV0hq11Ku1FcG1o8zJ5HJTNO8ITdPyP5 YwCg== X-Gm-Message-State: AOAM53343Lu5J+Yp4Cw5oJdjfAqL1qfJ7d46mvq43P0B8Z8Pa1ZIGoIK G7WSbHslyMu/e1nLYRCC5YDJ4/QVXgL9g+0FDlcMc5bhEkN+98XfLhnt2jYNOoUVw51xn9CFQEU 61BKhi9QqkmgZWWoKyag= X-Received: by 2002:a67:87c1:: with SMTP id j184mr53865vsd.18.1618433832135; Wed, 14 Apr 2021 13:57:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgunr/u6LocSs4ONGdhoTRt9Em0apeagt6HPR9aTuEf/aQi86xZCguoBM3hbgjLyqLCCUvpoa6NkBGPtf+vgE= X-Received: by 2002:a67:87c1:: with SMTP id j184mr53855vsd.18.1618433831836; Wed, 14 Apr 2021 13:57:11 -0700 (PDT) MIME-Version: 1.0 References: <20210414122036.1262579-2-gakhil@marvell.com> <20210414180417.1263585-1-gakhil@marvell.com> <20210414180417.1263585-2-gakhil@marvell.com> In-Reply-To: <20210414180417.1263585-2-gakhil@marvell.com> From: David Marchand Date: Wed, 14 Apr 2021 22:57:00 +0200 Message-ID: To: Akhil Goyal Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , dev , Ray Kinsella , Abhinandan Gujjar , Hemant Agrawal , Nipun Gupta , Sachin Saxena , Anoob Joseph , Matan Azrad , Fan Zhang , Gagandeep Singh , Erik Gabriel Carrillo , "Jayatheerthan, Jay" , Pavan Nikhilesh , Van Haaren Harry , Shijith Thotton , Dodji Seketeli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v10 1/4] devtools: add exception for reserved fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 14, 2021 at 8:04 PM wrote: > > From: Akhil Goyal > > Certain structures are added with reserved fields > to address any future enhancements to retain ABI > compatibility. > However, ABI script will still report error as it > is not aware of reserved fields. Hence, adding a > generic exception for reserved fields. > > Signed-off-by: Akhil Goyal > --- > devtools/libabigail.abignore | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 6c0b38984..654755314 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -19,4 +19,8 @@ > ; Ignore fields inserted in cacheline boundary of rte_cryptodev > [suppress_type] > name = rte_cryptodev > - has_data_member_inserted_between = {offset_after(attached), end} > \ No newline at end of file > + has_data_member_inserted_between = {offset_after(attached), end} > + > +; Ignore changes in reserved fields > +[suppress_variable] > + name_regexp = reserved > -- > 2.25.1 > Mm, this rule is a bit scary, as it matches anything with "reserved" in it. You need an exception anyway to insert the new fields (like in patch 2). Can you test your series dropping this patch 1 ? -- David Marchand