From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5463F43C12;
	Thu,  7 Mar 2024 18:59:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4215D402BA;
	Thu,  7 Mar 2024 18:59:27 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mails.dpdk.org (Postfix) with ESMTP id B988940272
 for <dev@dpdk.org>; Thu,  7 Mar 2024 18:59:25 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1709834365;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=+r2Am1hjK9vGRXwq/Wou+mCIm/jtUqtb6kt2g2n3NUQ=;
 b=P3fB/UBrdlgDnw9Zq+K70PKNZfpSAyI+5I6CC6rQ7vCeyJityvp+FjsoR4fah0B+fX3v4d
 iJXLpFSaE9RRcMZdl61GcAEEoRzf7cqxsPwFJHzzBtqUln5WGXOpVW87jCeKMCRs42vXyk
 watQ5a8h2aGK5dh6KC6yorxfyvN2Aek=
Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com
 [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-557-c0CdLtb-MHGloj2IbK3IQg-1; Thu, 07 Mar 2024 12:59:23 -0500
X-MC-Unique: c0CdLtb-MHGloj2IbK3IQg-1
Received: by mail-lf1-f71.google.com with SMTP id
 2adb3069b0e04-5134251ef6eso1362970e87.2
 for <dev@dpdk.org>; Thu, 07 Mar 2024 09:59:23 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1709834362; x=1710439162;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=+r2Am1hjK9vGRXwq/Wou+mCIm/jtUqtb6kt2g2n3NUQ=;
 b=AZ0yXCFNS546VVFTq9OUCEhO9VkSdJq81DCW9PwTlg+uk3zvZiK0lfgwbt4Q3sOWLC
 ADkZ88O7mTSZkEaruV4uRz1SjQ2+cLVXg0NacpgbSeTf7udLKRQvuRwh/wt7cdzj1D34
 fpjuqezzlh+TA+/zuFBBlqjxuyiTKHJ9gMKHIFXF3WFFyOBm0pnQedJVsNi9+3fkOIza
 uAZUvDClIWM5yPcBT1z2ohioIknWiBjEyjAi4glfIziYk9+Bk/RSKExM/RKVEEpBksfi
 ngNjMLxhFNmmYQ+h1DMrvrpw2+F2YeQbNGTmvKNAMqKo07CxMBV8BJjrmIJhrCt721Rf
 cbmA==
X-Forwarded-Encrypted: i=1;
 AJvYcCVyLyfHypLVf0y/VBq3+3ntfgC8/Dat01EVZpdQ7blt2GUoLYKcfDvXfPvV7kuX2sJY6DiQENdraRA1cfk=
X-Gm-Message-State: AOJu0YyH4hp1xoIwmWazpcrGen3CK7FjXczkiq5lqTI+TNJxGrpRxVMp
 22uMomY9EuskIgTs6ZjG63bwRVaZI35fmIH4ddqJirQKD8l3ldTIe0Nq96yr4JIRuCeTfhcdxrE
 CBEanrNoC2Fy/L4A1SgMHJgTupKBdLVtMpON3RiM1zYrgfxi7ZKh6y7q0Rl/7w83QYkR8Ye+Fy4
 24Mn2uLjSVM9eD4ZU=
X-Received: by 2002:a05:6512:32b5:b0:513:5765:35b7 with SMTP id
 q21-20020a05651232b500b00513576535b7mr1986587lfe.61.1709834362500; 
 Thu, 07 Mar 2024 09:59:22 -0800 (PST)
X-Google-Smtp-Source: AGHT+IEo2RreNo7uv5+IDMIRilHv+o3Vod1RgG3K9ZAU9LOxSAk4C+ruX+9BkI/hadb/HKWhfRgXeaMvEbL3LMm2/Lg=
X-Received: by 2002:a05:6512:32b5:b0:513:5765:35b7 with SMTP id
 q21-20020a05651232b500b00513576535b7mr1986577lfe.61.1709834362279; Thu, 07
 Mar 2024 09:59:22 -0800 (PST)
MIME-Version: 1.0
References: <20240304184508.89956-1-stephen@networkplumber.org>
 <20240307013715.114013-1-stephen@networkplumber.org>
 <20240307173651.GA13790@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
In-Reply-To: <20240307173651.GA13790@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 7 Mar 2024 18:59:11 +0100
Message-ID: <CAJFAV8xBqUBPO=3Z=CUQZgXKA_YG9WE70sTnEO3QRdvajKRvgg@mail.gmail.com>
Subject: Re: [PATCH v3] hash: put GFNI stubs back
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, dev@dpdk.org, 
 Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, 
 Bruce Richardson <bruce.richardson@intel.com>, 
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Mar 7, 2024 at 6:37=E2=80=AFPM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
> On Wed, Mar 06, 2024 at 05:36:42PM -0800, Stephen Hemminger wrote:
> > Make the GFNI stub functions always built. This solves the conditional
> > linking problem. If GFNI is available, they will never get used.
> >
> > Fixes: 07d836e5929d ("hash: uninline GFNI stubs")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Tested-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied with the edits I mentionned previously.


--=20
David Marchand