From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 929B2A0C43; Mon, 15 Nov 2021 10:28:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D9F140E01; Mon, 15 Nov 2021 10:28:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C3DDD40141 for ; Mon, 15 Nov 2021 10:28:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636968527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B7bzNsO10mdnwVVZMhGkKDzrmOa3q+U78RncN1swWhE=; b=epJWaz/bZyd6dqYCRqbrj85jnapN2L4jkr2d62RtRzwQgumcftEzn8104qVOY4uaIMAf2z UngT2YOpz/2WaShiO/kwKr4Huyj8xyAazPw7cCBzQH0VBTQdklVV5Dga2M+SGHrbhNUjtH KHGstlj5FbMcaEfSc7Bnhfw+jVeaeSk= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-cy6ZjIByOUaQhGpeMsQCEQ-1; Mon, 15 Nov 2021 04:28:45 -0500 X-MC-Unique: cy6ZjIByOUaQhGpeMsQCEQ-1 Received: by mail-lj1-f199.google.com with SMTP id q64-20020a2e2a43000000b00218c94eab9bso4881073ljq.18 for ; Mon, 15 Nov 2021 01:28:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B7bzNsO10mdnwVVZMhGkKDzrmOa3q+U78RncN1swWhE=; b=x8kDRl3pZuemp3yLV4BQxgKO8Gj5+3NWsIi3cKYohJ2ZAxcT/q+/2ZVBEYWxjKzD/l UD2YzcRyg77rR+TPQCqASDbRAKKftSuNpILwfA+j9KgFe5HhIRMAsDTkPTCcwgNBH1Kb CtFsJ6Sy4YguFaJ1QTJz1dUvnXUcxdRWNZ8/fOldMMjR0yC4lrUMaSvMWuyR70vEqDJB icdfK1tCKucdFWIwT0+vexJTBdk45OZoFF9UtkHXdRJHB3ev69UIII75qWxuK65HuHQW xABts0jzKtPXv0tgIOe2kgdSb6pfr2L8lrl+6byljl2bxMPJT69Wzn3eQlii2umLyJEK 7M9A== X-Gm-Message-State: AOAM531RKr8frR/nExWlw/KxRDAZ3RSvgdqAdgFW7igTNnHANqc5mmni ONxpJuE6suDf9j9UpbiHDdG/yQsuwtc7EXH+M7TVZDDVTGwAVvU16dvndoZ52d481UmOU0vmAUf +erpLq5qvuxh8fgdJISM= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr32505268lfv.560.1636968524282; Mon, 15 Nov 2021 01:28:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqsfszdqnJ3xUqtrLXec19yKq9IO34ado8wt77aro3BiZ/xEOuxNrcU2m0gM4nZVNYaveGRxuBx3APGD+ve24= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr32505248lfv.560.1636968524059; Mon, 15 Nov 2021 01:28:44 -0800 (PST) MIME-Version: 1.0 References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-6-conor.walsh@intel.com> In-Reply-To: <20211112140111.922171-6-conor.walsh@intel.com> From: David Marchand Date: Mon, 15 Nov 2021 10:28:33 +0100 Message-ID: Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables To: Ajit Khaparde , Somnath Kotur Cc: "Yigit, Ferruh" , "Liang, LongfengX" , dev , "Mcnamara, John" , Stephen Hemminger , Conor Walsh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ajit, Somnath, On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > This patch fixes unused but set variables in the following net drivers: > - bnxt > - hinic > - liquidio > - nfp > - octeontx > - qede > - txgbe > - vmxnet3 > > This patch also fixes an unused function warning for vmxnet3_unmap_pkt > from within vmxnet3 > > Bugzilla ID: 881 > > Fixes: b87abb2e55cb ("net/bnxt: support marking packet") > Fixes: 88badb3aef94 ("net/bnxt: add helper functions for blob/regfile ops") > Fixes: a4957d87e05a ("net/hinic/base: add mgmt module") > Fixes: 5ee7640f95a0 ("net/liquidio: add API to flush IQ") > Fixes: 19af5a38f7b6 ("net/nfp: move CPP bridge to separate file") > Fixes: 9eb5cb3b11cc ("net/octeontx: fix access to indirect buffers") > Fixes: 86a2265e59d7 ("qede: add SRIOV support") > Fixes: b7311360fb67 ("net/txgbe: support VF interrupt") > Fixes: c3ecdbb376da ("vmxnet3: support TSO") > > Signed-off-by: Conor Walsh > Reported-by: Liang Longfeng > --- > drivers/net/bnxt/bnxt_rxr.c | 22 ---------------------- > drivers/net/bnxt/tf_ulp/ulp_utils.c | 3 --- > drivers/net/hinic/base/hinic_pmd_mgmt.c | 6 ------ > drivers/net/liquidio/lio_rxtx.c | 2 -- > drivers/net/nfp/nfp_cpp_bridge.c | 6 ++---- > drivers/net/octeontx/octeontx_rxtx.h | 3 +-- > drivers/net/qede/base/ecore_vf.c | 5 +---- > drivers/net/txgbe/txgbe_ethdev_vf.c | 2 ++ > drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 ++++++++ > 9 files changed, 14 insertions(+), 43 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index 8bc8ddc353..157297bc64 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -823,9 +823,6 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp, > struct rte_mbuf *mbuf) > { > uint32_t cfa_code = 0; > - uint8_t meta_fmt = 0; > - uint16_t flags2 = 0; > - uint32_t meta = 0; > > cfa_code = rte_le_to_cpu_16(rxcmp1->cfa_code); > if (!cfa_code) > @@ -834,25 +831,6 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp, > if (cfa_code && !bp->mark_table[cfa_code].valid) > return; > > - flags2 = rte_le_to_cpu_16(rxcmp1->flags2); > - meta = rte_le_to_cpu_32(rxcmp1->metadata); > - if (meta) { > - meta >>= BNXT_RX_META_CFA_CODE_SHIFT; > - > - /* The flags field holds extra bits of info from [6:4] > - * which indicate if the flow is in TCAM or EM or EEM > - */ > - meta_fmt = (flags2 & BNXT_CFA_META_FMT_MASK) >> > - BNXT_CFA_META_FMT_SHFT; > - > - /* meta_fmt == 4 => 'b100 => 'b10x => EM. > - * meta_fmt == 5 => 'b101 => 'b10x => EM + VLAN > - * meta_fmt == 6 => 'b110 => 'b11x => EEM > - * meta_fmt == 7 => 'b111 => 'b11x => EEM + VLAN. > - */ > - meta_fmt >>= BNXT_CFA_META_FMT_EM_EEM_SHFT; > - } > - > mbuf->hash.fdir.hi = bp->mark_table[cfa_code].mark_id; > mbuf->ol_flags |= RTE_MBUF_F_RX_FDIR | RTE_MBUF_F_RX_FDIR_ID; > } > diff --git a/drivers/net/bnxt/tf_ulp/ulp_utils.c b/drivers/net/bnxt/tf_ulp/ulp_utils.c > index df3afaa6fd..c60d81d14a 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_utils.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_utils.c > @@ -200,7 +200,6 @@ ulp_bs_push_msb(uint8_t *bs, uint16_t pos, uint8_t len, uint8_t *val) > { > int i; > int cnt = (len + 7) / 8; > - int tlen = len; > > /* Handle any remainder bits */ > int tmp = len % 8; > @@ -211,12 +210,10 @@ ulp_bs_push_msb(uint8_t *bs, uint16_t pos, uint8_t len, uint8_t *val) > ulp_bs_put_msb(bs, pos, tmp, val[0]); > > pos += tmp; > - tlen -= tmp; > > for (i = 1; i < cnt; i++) { > ulp_bs_put_msb(bs, pos, 8, val[i]); > pos += 8; > - tlen -= 8; > } > > return len; Review please. -- David Marchand