From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC6DAA034F; Thu, 14 May 2020 18:29:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4831B1DA15; Thu, 14 May 2020 18:29:08 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 5D5A71D9CE for ; Thu, 14 May 2020 18:29:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589473745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j4jZZYo5I22OISHuhzTzYGVzqSyHNMk2UZkhR7FN1Zg=; b=R2ImoNQuaO8Fzo2VjVv516RRSPsNDoN+Kscr38kCHsalM6F5xx+naCbuCHX/ZoL5yaiMCm +C5j7Ibqn0ERTrjOYFciDP/UYYG9d8WhOY7ZkSwKtUM4aLVUs2eFsI2gLlascpecAen/pQ r5LHi5hQg2pH+rVshs+sjWqcuAK3Owc= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-RppSF-0MNp6muC8g2OR65A-1; Thu, 14 May 2020 12:29:02 -0400 X-MC-Unique: RppSF-0MNp6muC8g2OR65A-1 Received: by mail-vk1-f199.google.com with SMTP id 188so1525677vkz.19 for ; Thu, 14 May 2020 09:29:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j4jZZYo5I22OISHuhzTzYGVzqSyHNMk2UZkhR7FN1Zg=; b=OAq5TmsQv9mtxyw1R10O3UGrZWSatqa/4QEtJ4maMOuqr50tMFI2mvtE5EeuKS8VOU aSb8xP6/Xd4+Zivxn3LffHWyXr62b8jPJsl+2IhKlbvM/W3Y5TPY7bSyGiYTIYiuJPUs EGbF+WOEw+fLdCF6PpC5c49zza1W9Q5xp5iDgQ9W5iNhgWZDOBU/WYXrt8jPUpOW7Vwv b8navDLG5ponwXXQ4f1aVFcceitru+bOHPRVzbklIIOuGTQpSwCcwfzDfboIVlhk4uX/ /kqAcDmV3TuBzzryf6LvCYs45unBGnNxGO7mVVDW0EUy2AgJ7VZ3olHJ+SaTUFYdCWY+ XNoQ== X-Gm-Message-State: AOAM530ZO7+PqeCl1c/BFegmwLDlNH8hXEhs6nE7St9pMcCOtiGgDy3D jcP9gZtxY/KJkWEDMLpZQpvhpdBCH183EYhhRRn1d9ekc1TkgA78BFXmtoSX+pTIl4bjb+vUtex oNlbHpbGBPYNligesKGM= X-Received: by 2002:ab0:36d9:: with SMTP id v25mr3856570uau.126.1589473741925; Thu, 14 May 2020 09:29:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1C3RrFVXCJHd3p1d7QqtqPGNin1Q87dgzWN7lxlosMTTtksXC3t9/0eS1tdjVh8TdeODafs1WTfNMRHGtCA8= X-Received: by 2002:ab0:36d9:: with SMTP id v25mr3856542uau.126.1589473741610; Thu, 14 May 2020 09:29:01 -0700 (PDT) MIME-Version: 1.0 References: <20200512140100.26803-1-hemant.agrawal@nxp.com> <20200513132745.9006-1-hemant.agrawal@nxp.com> <20200513132745.9006-2-hemant.agrawal@nxp.com> <63aee4d4-db63-de05-2ff1-5f9ae748da80@ashroe.eu> <22cd532f-8b25-df37-29b0-daad10381def@ashroe.eu> <313184ad-539c-5f18-3a19-7939fbd3d730@ashroe.eu> In-Reply-To: From: David Marchand Date: Thu, 14 May 2020 18:28:50 +0200 Message-ID: To: "Hemant Agrawal (OSS)" , Ray Kinsella Cc: "dev@dpdk.org" , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 3:31 PM David Marchand wrote: > > On Thu, May 14, 2020 at 2:39 PM Hemant Agrawal (OSS) > wrote: > > > > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > > > I removed the filename_exp and introduced function based name= > > Now the issue is the following warning > > SONAME changed from 'librte_pmd_dpaa2.so.20.0' to 'librte_pmd_dpaa2.so.0.200.2' > > > > The primary reason is that now pmd_dpaa2 has no symbol left for 20.0 section. > > Following is not helping. > > [suppress_file] > > soname_regexp = ^librte_pmd_dpaa2 > > so, it seems for now, the filename_exp is the only option > > That's interesting. > Because I wondered about this point when reviewing __rte_internal. > For components providing only internal symbols like components > providing only experimental symbols, the build framework will select a > soname with .0.200.x. > > Here, your dpaa2 driver was seen as a stable library so far. > Moving everything to internal changes this and the build framework > changes the soname to non stable. Looking at a v19.11 testpmd binary: $ readelf -d $HOME/abi/v19.11/build-gcc-shared/usr/local/bin/dpdk-testpmd |grep dpaa 0x0000000000000001 (NEEDED) Shared library: [librte_bus_dpaa.so.20.0] 0x0000000000000001 (NEEDED) Shared library: [librte_common_dpaax.so.20.0] 0x0000000000000001 (NEEDED) Shared library: [librte_mempool_dpaa.so.20.0] 0x0000000000000001 (NEEDED) Shared library: [librte_pmd_dpaa.so.20.0] Changing the soname would break this. > You could keep an empty DPDK_20.0 block to avoid this and the soname > will be kept as is. We will have to maintain such soname for all dpaa libraries until 20.11. -- David Marchand