From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 9F2991B5FB for ; Thu, 10 Jan 2019 11:44:21 +0100 (CET) Received: by mail-ua1-f67.google.com with SMTP id d19so3418161uaq.11 for ; Thu, 10 Jan 2019 02:44:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eABiOLyCWk57H7n059lXJXE0Ne+TsBtReudPklLatYc=; b=TGjeItgWoNNr9yCeIhS7n5zYxvJt1ib64ysHTJy1npuWuHNdp8PQshVxi1/PpkqaSC figXTTVSzZHtq3a8Iz1e/A3od1MrvTDeRK8A5xA26OtM7Mt1P78hpbf0CMfsneQJBVi1 cenHVjVw9yiwKp+5oai8vfmDBcbn9b7IinTfWqhoekYR14gjpCKk2GE3bFT63gkAAsJi E9nlSAo7b8aU+hcLfgh4LH1mds1A6x3+0K0TE1W0InzftYoiTvBWBff1JHlY1VJ6GPj4 eQTy3npO1+geo7Fl2MF5LmitA/CZO4H3GRmIyLSFXPXmOh9Wy+dW3Y0HsS07EMIBR5FW 24ig== X-Gm-Message-State: AJcUukcwxTVac29dyWwtvQe8lco0i/qfFn3thhroZnq9rnLq+cdVMglQ bxHj1tfdYO1JDph+S0e5LIlRN/RL+7YAEGu5Be5y4A== X-Google-Smtp-Source: ALg8bN7c3/mUBKSljN2VjFcaI5XM0tQdr4C1RMiZ50KMRfxQsaeha7gao60i+5+w3lCbPgF1zuL9PGneyJuWD5NKQ7g= X-Received: by 2002:ab0:4121:: with SMTP id j30mr3420847uad.65.1547117060988; Thu, 10 Jan 2019 02:44:20 -0800 (PST) MIME-Version: 1.0 References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <1557339.2CBSiR8abE@xps> <2632071.H5f8aPozaM@xps> <20190110100220.GA13196@bricha3-MOBL.ger.corp.intel.com> <20190110104135.GA4728@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190110104135.GA4728@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 10 Jan 2019 11:44:07 +0100 Message-ID: To: Bruce Richardson Cc: "Burakov, Anatoly" , Thomas Monjalon , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 10:44:22 -0000 On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson < bruce.richardson@intel.com> wrote: > On Thu, Jan 10, 2019 at 10:34:19AM +0000, Burakov, Anatoly wrote: > > On 10-Jan-19 10:02 AM, Bruce Richardson wrote: > > > I also forgot that. However, that does bring up the thought that for > some > > > of our headers we may want them available for all libraries even > before EAL > > > is compiled up. [I think this hits on the idea Thomas was discussing of > > > splitting EAL up into two, where we have a core part that is always > > > compiled first and has no dependencies followed by another which is > built > > > later and can have dependencies.] > > > > > > For this specific issue, my thought is that we should indeed move > compat.h > > > into EAL, but also add the EAL common/include/ path to the global > include > > > path for the project, so all EAL headers (e.g. including those with > defines > > > for cacheline size, and other common macros) are just always available. > > > Libs like kvargs and others should be able to use RTE_DIM etc. for > > > consistency with the rest of DPDK. > > > > > > /Bruce > > > > > > > Patches welcome so! :) > > > Working on it... :-) > I don't think it is that quick to do, so, for the time being, do we go with this patch ? -- David Marchand