Re: [PATCH v4 1/1] mbuf: enable to be compiled with MSVC

[David Marchand <david.marchand@redhat.com>]

On Tue, Apr 8, 2025 at 11:24 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
> diff --git a/lib/net/meson.build b/lib/net/meson.build
> index 7a6c419f40..c528fcc9a2 100644
> --- a/lib/net/meson.build
> +++ b/lib/net/meson.build
> @@ -43,7 +43,12 @@ use_function_versioning = true
>
>  if dpdk_conf.has('RTE_ARCH_X86_64')
>      sources += files('net_crc_sse.c')
> -    cflags += ['-mpclmul', '-maes']
> +    cflags_options = ['-mpclmul', '-maes']
> +    foreach option:cflags_options
> +        if cc.has_argument(option)
> +            cflags += option
> +        endif
> +    endforeach

What guarantee do we have that MSVC builds with those instructions?

>      # only build AVX-512 support if we also have PCLMULQDQ support
>      if cc.has_argument('-mvpclmulqdq')
>          sources_avx512 += files('net_crc_avx512.c')


-- 
David Marchand