From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC022A0C47; Tue, 6 Jul 2021 15:28:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 933514128B; Tue, 6 Jul 2021 15:28:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 458594128B for ; Tue, 6 Jul 2021 15:28:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625578083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K4CjbFJgQfg8Oyoclll9gYl6SC9fH0oF+EibxcWj8SY=; b=V+8/wLZlCWy3PZu/lY3zN6F7tZNO+ZRMtpuJ46OwbAS9Q0brqnGZ4LDzRYf5uS+tY3xK2U 0t+1vC6lAbYQsU+BeO1SN9RdVWZHPxIb+zajP8g/5vKlQq5uoOaBHcl1DdPN/Cu9wZopNI gpV9WDu5vluT+Tf2jEkNT7/z3f4xOe0= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-OI1DQMn2OPy35w04xSb5EQ-1; Tue, 06 Jul 2021 09:28:00 -0400 X-MC-Unique: OI1DQMn2OPy35w04xSb5EQ-1 Received: by mail-vs1-f71.google.com with SMTP id v15-20020a67c00f0000b029023607a23f3dso4726162vsi.10 for ; Tue, 06 Jul 2021 06:28:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K4CjbFJgQfg8Oyoclll9gYl6SC9fH0oF+EibxcWj8SY=; b=Bt7BC3T9A0dP/7mgjqOfT6do4Vha9mzpFp9rHfxN17BWbK3ZYSbrxsoxb9isWAKJuA 6zHN+Nsm+5MWQcjyW+SrPUTGgtxLvQkulUEQn47L4eZ9t4zbo6o9qwDTKQJfKkQCmE5Y 1iW4W1IHHaRMf+k+omx90bAhEhJ4B79nAPH1pJALOR6sTrYKFx5exb0lxCd3rrBXJSIj I1I7q8OGb8KQVMkSOF6U3Eq3WyPLQa2TqM0Ea12e9rFgGSQrvjdZzx3qUXmw8sLFGB8a XdUsL4uQFssLNqGIlv46N0v3jqY2xrwldyoepn1YGygj7VEkc8dcZU29sJ07MPCbd2As MGfQ== X-Gm-Message-State: AOAM531D9s+nfBy5BO4LZqGs6rY8hZRfkvcDwpeREnVCH0vk5Z9bRkNq vV/PePKTMQW/uDZYM5WopZrZ6VCT36tRD5N2k4jw/Od4nOdeHpCjBi5x0CizcOQbdauZRmBnK+M /2zgtSdzc0tNsnciFve8= X-Received: by 2002:a67:f3d1:: with SMTP id j17mr7640264vsn.18.1625578079889; Tue, 06 Jul 2021 06:27:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRcbmhZ0UQJzaWgdaQHAkvtui0MsyN36d6wuHmSXTc6zkAxcH4Jl5qCchmGrXTWRL4gLQSUusX70iZcc7POY8= X-Received: by 2002:a67:f3d1:: with SMTP id j17mr7640244vsn.18.1625578079639; Tue, 06 Jul 2021 06:27:59 -0700 (PDT) MIME-Version: 1.0 References: <20210706085643.5088-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 6 Jul 2021 15:27:48 +0200 Message-ID: To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Yang, Qiming" , "Zhang, Qi Z" , "Stillwell Jr, Paul M" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ice: fix memzone leak when firmware is missing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue wrote: > > > The function 'ice_deinit_hw' should be used. ;-) > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice > > /ice_main.c#n4508 > > > > Well I was inspired by ice_dev_close(), so I guess this code too could > > use some cleanup but I don't have the hw anymore to test this change. > > I'll trust you and simply update ice_dev_init. Adding to this, there are other potential leaks if ice_flow_init() or ice_reset_fxp_resource() fails. Probably worth opening a bz for later processing. WDYT? -- David Marchand