From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07E30A034C; Wed, 21 Dec 2022 16:03:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE75D40A7F; Wed, 21 Dec 2022 16:03:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B1C2B40A7A for <dev@dpdk.org>; Wed, 21 Dec 2022 16:03:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671635017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlPNg8ip0znARRPlsaQduJRQqN77GyRDVQLuItqQPWI=; b=SjOFSCaW1rgtoCzNe9sgzA4V74GaTAzqNszVis8VfY6nH2lzej6GT9FFVRedWiAWFgtulc 8gg64ZC550WBALt7XQ56rxAfApO/h6+/+sdtQXhfy92uyyeyGwoGUzuX05kNVBhMF8muIT zOjz9Hi91hPnClRMVm4xWF8ySxR/vR8= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-619-Uug4raqBNoKyrxVHh7EWFw-1; Wed, 21 Dec 2022 10:03:33 -0500 X-MC-Unique: Uug4raqBNoKyrxVHh7EWFw-1 Received: by mail-pg1-f199.google.com with SMTP id i19-20020a63e913000000b004705d1506a6so9060748pgh.13 for <dev@dpdk.org>; Wed, 21 Dec 2022 07:03:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FlPNg8ip0znARRPlsaQduJRQqN77GyRDVQLuItqQPWI=; b=6qpHWjBBfERPg6maxBhG3xO+rgUHPmda+lNidLUuQbS9/1Qb76Yh00ARfnpNoYKOHt 0D4GKGmb2+L/iWVWZL/r826zlTvEE8CA/gFTVG288GchTO3L+nHxFzJ7NZM4WeEX6KFH 1b1+jEGPBPIOO1cvESrspvinHWeEj2vej+kqEbMsK3gcLmdKJkEKwH8sPDZciUJw1JG5 XjSf/SaEfRIwVqZCuWWnnyXBqi9+nySpIF7Z9f5vNEZIi9U6CqASNTvD5qlEWTe+V7/y 50Pmhcz1RHKDxN8m4eQLWybEyJFM1BpTTmkcpV33s/Osi7m522/u/58x0UMrAU1q0v7T zvWw== X-Gm-Message-State: AFqh2krTSGDEHtndy57BkZsxGwpC6ivK+67nVJxh1caAj0yeIiOFEWJX UXNdq/D4Z18Yng1qWzKwQnEWbYPkRgKUEyarQIgGmGMVTdTU6YLqhVm0hrqtUALCGN6AQ818rmV t5Q9pIFbQL8HBTf4ZSBE= X-Received: by 2002:a63:a23:0:b0:484:83e4:4ca1 with SMTP id 35-20020a630a23000000b0048483e44ca1mr67560pgk.178.1671635011752; Wed, 21 Dec 2022 07:03:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXt1pxTners6k8Kk/6S4BdaIJYPM9X8LfZF8iazHsMa5tYpqvLu7ReG1Vewu+HqOLMNafCDuhUaejFf8hqkU0Xc= X-Received: by 2002:a63:a23:0:b0:484:83e4:4ca1 with SMTP id 35-20020a630a23000000b0048483e44ca1mr67559pgk.178.1671635011507; Wed, 21 Dec 2022 07:03:31 -0800 (PST) MIME-Version: 1.0 References: <1670287169-15325-1-git-send-email-roretzla@linux.microsoft.com> <1671211000-14856-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1671211000-14856-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand <david.marchand@redhat.com> Date: Wed, 21 Dec 2022 16:03:20 +0100 Message-ID: <CAJFAV8xDpVsPWgZKdiqQNS5CwGFrV-haj9cJqxpot4HD6U7GCA@mail.gmail.com> Subject: Re: [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it. To: Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: dev@dpdk.org, stable@dpdk.org, dmitry.kozliuk@gmail.com, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Dec 16, 2022 at 6:16 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > Two bugs are fixed to allow this test to build, run & pass. > * Mark memory configuration complete during rte_eal_init() > * Use rte thread api to get a proper implementation of thread join. > > v2: > * update commit message to clarify why this test is beneficial on Windows. > * add missing Fixes tag > > Tyler Retzlaff (2): > eal: add missing call marking memory config complete > test: enable lcores test on Windows > > app/test/test_lcores.c | 28 +++++++++++++--------------- > lib/eal/windows/eal.c | 3 +++ > 2 files changed, 16 insertions(+), 15 deletions(-) For the series, Acked-by: David Marchand <david.marchand@redhat.com> I added review tags from Stephen from v1. Series applied, thanks. -- David Marchand