From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBDEE4558B; Wed, 10 Jul 2024 10:03:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD86C40647; Wed, 10 Jul 2024 10:03:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 855474029C for ; Wed, 10 Jul 2024 10:03:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720598637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zeemDJpFw7gOBqr89HPtYNyliqoMYEet8G4a5HPnMx0=; b=ZCGhsTADojGr85zKGgyKxArnk339oSAv1rYo24e7oZ7EOe8aWDvySUlwU2ya8csn1BwBYX PLBYjmF+p/OORxxFwS8t0FDMJ2x/aYspZF6sPZtUQ+5rkZCpc52S1TUT49iDQs8WwEQAm9 nvGB8dnzDxRWG2RVlSgl/IcRhWReWCY= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307--qrsTYTLPf6234rdngaTiQ-1; Wed, 10 Jul 2024 04:03:55 -0400 X-MC-Unique: -qrsTYTLPf6234rdngaTiQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2eebdfcb63eso6968451fa.2 for ; Wed, 10 Jul 2024 01:03:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720598634; x=1721203434; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zeemDJpFw7gOBqr89HPtYNyliqoMYEet8G4a5HPnMx0=; b=nivQ15T0Co3B51W+z/XIUivs93YGMN2eYbqKrifXrTHNU6S8HgnVRl34JrZIlFHjhx rvL9e+uz6sMnoqoUIgGkhQqe7uiF0EWUR2hzX8kxwU1PUjDngo0i8zmyzM7Ly7lNc8Ds sUVBhrenC5YQdDQZqRzHunGXm8IXA0ejaOht9LwXsQlZZqiRdl3nfnkKIW6fnbECAS4V /jmSpl2IPPSFBqJQKn3m7bkQdX4W+EocFLRGstkaRRpMNiYoRNj74XJTJfCeYRqV39uj 6tkaI4kN38UYsBdwzZZTeWzHH1LLXfbe6az9T9HurBN71R4e8nCzvAYrasI1QJj7i0Di kcWw== X-Gm-Message-State: AOJu0Yz9F3vvF0H/l3X+21R008uaCeUOnBAsPTq3lQ2dp4+PNEpTF0uH xUAyglMrZ2Fli5O73PY/R1rX/SkvUf6wVCcrGjMxgcMIMPzGSP10fgqlxxvPStw3/zCUDrEs4c3 Wzmsi1vzOpDK2gCqN4VSRRG7RwIomtbozZgaBAy8c3h3TjZHt2mtOcaFvOYGngAJpBrxPFyVoma Kp4/pT0d6Me68oFNM= X-Received: by 2002:a2e:2c16:0:b0:2ee:bcf3:2686 with SMTP id 38308e7fff4ca-2eebcf32ab6mr14661691fa.21.1720598634001; Wed, 10 Jul 2024 01:03:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtEHDcNJS805e8vo2O0CxNM5oQdz85yLxPjanbY+kTp8qk0NQJqSBHuIr6KtQP7wSWC0UfcHx69UiULZHC+rw= X-Received: by 2002:a2e:2c16:0:b0:2ee:bcf3:2686 with SMTP id 38308e7fff4ca-2eebcf32ab6mr14661551fa.21.1720598633662; Wed, 10 Jul 2024 01:03:53 -0700 (PDT) MIME-Version: 1.0 References: <20240302234812.9137-1-mb@smartsharesystems.com> <20240709132735.25671-1-mb@smartsharesystems.com> In-Reply-To: <20240709132735.25671-1-mb@smartsharesystems.com> From: David Marchand Date: Wed, 10 Jul 2024 10:03:42 +0200 Message-ID: Subject: Re: [PATCH v9] eal/x86: improve rte_memcpy const size 16 performance To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, stephen@networkplumber.org, roretzla@linux.microsoft.com, mattias.ronnblom@ericsson.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 9, 2024 at 3:28=E2=80=AFPM Morten Br=C3=B8rup wrote: > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > In the case where the size is known to be 16 at build time, omit the > duplicate copy. > > Reduced the amount of effectively copy-pasted code by using #ifdef > inside functions instead of outside functions. > > Suggested-by: Stephen Hemminger > Signed-off-by: Morten Br=C3=B8rup > Acked-by: Bruce Richardson > Acked-by: Konstantin Ananyev CI looks good (with OVS compilation tested). Applied, thanks. --=20 David Marchand