From: David Marchand <david.marchand@redhat.com>
To: Michael Santana <msantana@redhat.com>
Cc: dpdk stable <stable@dpdk.org>,
dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Van Haaren Harry <harry.van.haaren@intel.com>,
Rami Rosen <ramirose@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/2] devtools: fix result of svg include check
Date: Mon, 4 Mar 2019 11:17:12 +0100 [thread overview]
Message-ID: <CAJFAV8xE35_iUmWK8TWgaBFSsOvgWyaxUMQAV1ADLkg-0Fg3tw@mail.gmail.com> (raw)
In-Reply-To: <86213097.jjelSHenU9@xps>
On Fri, Mar 1, 2019 at 6:52 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 01/03/2019 18:08, Michael Santana:
> > Fix trivial bug. In sh shell, 'foo = 1' is not the same as
> > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
> > as a command, rather than a simple variable assignment.
> >
> > Signed-off-by: Michael Santana <msantana@redhat.com>
> > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
>
> CC: stable@dpdk.org must be inserted below Fixes for the record in git.
>
> Note also that Signed-off-by must be below with a blank line.
>
Ah ah, great that we won't have to check this manually soon :-)
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-03-04 10:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 19:08 [dpdk-dev] [PATCH 0/2] Minor changes to checkpatches Michael Santana
2019-02-13 19:08 ` [dpdk-dev] [PATCH 1/2] Enable codespell from config file Michael Santana
2019-02-13 19:16 ` Van Haaren, Harry
2019-02-14 14:07 ` Bruce Richardson
2019-02-14 2:50 ` Rami Rosen
2019-02-13 19:08 ` [dpdk-dev] [PATCH 2/2] Fix variable assignment Michael Santana
2019-02-14 19:35 ` [dpdk-dev] [PATCH v2 0/2] Minor changes to checkpatches Michael Santana
2019-02-14 19:35 ` [dpdk-dev] [PATCH v2 1/2] Enable codespell by default. Can be disabled from config file Michael Santana
2019-02-28 11:21 ` Thomas Monjalon
2019-02-28 22:09 ` Michael Santana Francisco
2019-02-28 23:01 ` Thomas Monjalon
2019-02-14 19:35 ` [dpdk-dev] [PATCH v2 2/2] Fix variable assignment Michael Santana
2019-02-28 11:14 ` Thomas Monjalon
2019-02-15 14:02 ` [dpdk-dev] [PATCH v2 0/2] Minor changes to checkpatches Bruce Richardson
2019-03-01 17:08 ` [dpdk-dev] [PATCH v3 " Michael Santana
2019-03-01 17:08 ` [dpdk-dev] [PATCH v3 1/2] Enable codespell by default. Can be disabled from config file Michael Santana
2019-03-01 17:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-01 17:51 ` Thomas Monjalon
2019-03-01 20:24 ` Michael Santana Francisco
2019-03-01 21:08 ` Thomas Monjalon
2019-03-04 16:59 ` Michael Santana Francisco
2019-03-01 17:08 ` [dpdk-dev] [PATCH v3 2/2] devtools: fix result of svg include check Michael Santana
2019-03-01 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-04 10:17 ` David Marchand [this message]
2019-03-04 19:07 ` [dpdk-dev] [PATCH v4 0/2] Minor changes to checkpatches Michael Santana
2019-03-04 19:07 ` [dpdk-dev] [PATCH v4 1/2] Enable codespell by default. Can be disabled from config file Michael Santana
2019-03-04 19:07 ` [dpdk-dev] [PATCH v4 2/2] devtools: fix result of svg include check Michael Santana
2019-03-04 21:46 ` [dpdk-dev] [dpdk-stable] [PATCH v4 0/2] Minor changes to checkpatches Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xE35_iUmWK8TWgaBFSsOvgWyaxUMQAV1ADLkg-0Fg3tw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=msantana@redhat.com \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).