From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by dpdk.org (Postfix) with ESMTP id 36DFC493D for ; Mon, 4 Mar 2019 11:17:24 +0100 (CET) Received: by mail-ua1-f44.google.com with SMTP id s15so3901262uap.6 for ; Mon, 04 Mar 2019 02:17:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X0+PNB8WRhhezHIloj9531zmzjLopMoDAZ8jjM/stME=; b=kR8oLqODLQIhkJnFxks5Nfisa6Qw9ezWNg42xbnturweib1on21dFOvqgQCfGKLsMa sEO1RzsuL4cy4jDhO1/L6JZwBycACEstJBQP7O3GTJvLqvNw3S/S+bYdQOq4Wxc9pPvU jsjIvKFGo9Xk7yIdzq67l32ux+A12Co+dU9EMcm8deputKh3W3pjPWYgYBavYYe2v4hQ WRRV1nL9akNio/7EqDe/QKdPpRuECtQ4ZDv+aVyCxuOhMvi5iUKcsyq5EDxn6L18nf5n +EXSzX9LfxqkCEDjicrWPwRgZ6i0XxT1NiPU6dy8K0uBQ0h3f+lGMdzvJeYY81hqhCFx WyIA== X-Gm-Message-State: APjAAAWdavZbp8l5KrldYYBS5kdsKC53P2AkKsy4YLX1Fus3M8EdtXak xipBD8yC4P8/Ij1gDVFKs4xYyKQQYjROK/3BTDP1Yg== X-Google-Smtp-Source: APXvYqw2pZAKgkvClxK/mzS7nbdCdb4GfflTOgT9O2rcQuNuFPUO0vSMdKhrtfCEPj8fQUKdJjGhT6R+tKpuMsOREPs= X-Received: by 2002:a67:c78e:: with SMTP id t14mr9198042vsk.180.1551694643644; Mon, 04 Mar 2019 02:17:23 -0800 (PST) MIME-Version: 1.0 References: <20190214193547.30783-1-msantana@redhat.com> <20190301170806.3547-1-msantana@redhat.com> <20190301170806.3547-3-msantana@redhat.com> <86213097.jjelSHenU9@xps> In-Reply-To: <86213097.jjelSHenU9@xps> From: David Marchand Date: Mon, 4 Mar 2019 11:17:12 +0100 Message-ID: To: Michael Santana Cc: dpdk stable , dev@dpdk.org, Bruce Richardson , Van Haaren Harry , Rami Rosen , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/2] devtools: fix result of svg include check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 10:17:24 -0000 On Fri, Mar 1, 2019 at 6:52 PM Thomas Monjalon wrote: > 01/03/2019 18:08, Michael Santana: > > Fix trivial bug. In sh shell, 'foo = 1' is not the same as > > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo > > as a command, rather than a simple variable assignment. > > > > Signed-off-by: Michael Santana > > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks") > > CC: stable@dpdk.org must be inserted below Fixes for the record in git. > > Note also that Signed-off-by must be below with a blank line. > Ah ah, great that we won't have to check this manually soon :-) Reviewed-by: David Marchand -- David Marchand