From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBFCBA0C44; Mon, 12 Apr 2021 11:33:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BA5114106F; Mon, 12 Apr 2021 11:33:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DF50E141061 for ; Mon, 12 Apr 2021 11:33:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618220004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VbrpNdS+YzIB802D17HMN+MfP3o4aphk0Vg2OXV9rTI=; b=RDGNXVg/4p9AijrknUO2uROMozM/yF93e2b6U5i+hGpBepEY7ZaqCoq1BFCQPIsD6JQYx0 eISlAvKI/eooE9xt8gRPSljBZ3uzN/y6QnYGg5z5IByFa1pNbgLmJXB8UUs0dM1vVMlJSu Og/UqMWCod3u9ivqxAamGGSWPLKnq44= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-iEc6PPYnM9ehxj7hJ3pLkg-1; Mon, 12 Apr 2021 05:33:22 -0400 X-MC-Unique: iEc6PPYnM9ehxj7hJ3pLkg-1 Received: by mail-vk1-f198.google.com with SMTP id j22so1324364vki.9 for ; Mon, 12 Apr 2021 02:33:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VbrpNdS+YzIB802D17HMN+MfP3o4aphk0Vg2OXV9rTI=; b=aNDWH5NDzf8P9SvmjwSudxrMf9wrE0RCOgOdV62KnoLFQtwcaFC3ie1q7yvN8oSLt/ BNrHWXVBT3nfJTmBD/bz3E845cfk41ntDfj0dinr8pxAR9HyFDO4Vzn+DEzOBoxJTrfE ZBxkOV6iyMTuERiTx/61xIa8rtWNFo2OsKMsGfiuxXy8yrB2TI9p5gowjcL1pvdjOoGT TrTORVhzfhF+UT9fc/9SSDZSejnxZrjUgD5fWPusEcBhox0ei3mJgCK/fHE8th1bgbqA OGEw8eiTOwiUaTk83gICHqEj1Wd8g1h7SzIiWukyQezHUlVtGRMNTMloq+1qHWjrpU8g W/1g== X-Gm-Message-State: AOAM532oPUwygSqkA5KFWG3Ol3NRrzXpENFLKnmmwsRXJ11laYp4aAvW NsYRIgEHFd62sz0MaTyO1yBTX0Rn0tuk34Ik6vdrZLaqLMGLFFZSbA1p/3fd1vZ/+EoJU0tbQcC ab94xNEFwaf/th8FvaNE= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr2775565vkq.17.1618220002089; Mon, 12 Apr 2021 02:33:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg2J+CjUERW63d4HEvsjVI4ggcHV69IUFdjSOUkUZ85O9LxjIDzeO4KWKgfnpemWqspvAkR6WiVsgUw7umH0A= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr2775560vkq.17.1618220001916; Mon, 12 Apr 2021 02:33:21 -0700 (PDT) MIME-Version: 1.0 References: <20210311063827.55394-1-xiao.w.wang@intel.com> <20210317063109.135662-1-xiao.w.wang@intel.com> In-Reply-To: From: David Marchand Date: Mon, 12 Apr 2021 11:33:10 +0200 Message-ID: To: "Wang, Xiao W" Cc: Maxime Coquelin , "Xia, Chenbo" , "Liu, Yong" , dev , "Ananyev, Konstantin" , dpdk stable , "yangyi01@inspur.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W wrote: > Considering the major consumer of vhost API is virtual switch/router, I tend to keep the current implementation and apply this fix patch. > Any comments? This is just a hack that bypasses the vswitch control. It happens to work when the vswitch does nothing. If anything is done, like popping a vlan header, the vswitch needs to update l3 offset. -- David Marchand