From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F2D53A0AC5 for ; Mon, 27 May 2019 12:15:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8718137D; Mon, 27 May 2019 12:15:22 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 6C0A1A49 for ; Mon, 27 May 2019 12:15:21 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id w19so10195449vsw.8 for ; Mon, 27 May 2019 03:15:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FoKif3qrJLI+xKYhz52KpwCLyc3jEEUS8Hgn5nxl/Vs=; b=BDxX7/mcXk2+jMCCUbr9s8ehEj5Xd46wmJ6zBmJgaewPedXf2GOyeW3hhehgx3ZLoI UrItx5pAU7oAXdV/N3xy9C76zrKhOJPHWIhecrZjow43XELnJv83Dnmwr1SIs6n823fA 2lw/kQnJzvnuUNc1nHRJ2Rck4kFrfFTCN6bDnuKk5LjqwyKFGWoA4moAwGA9HGeEaDgX RjFugwg4tL3twaAOu1uL8UoTOu4danfVpcvUhGIOxdW1D4K7zxZGR4VCwv08B+mpQdvK crkXQa422K3cBtHVAL1yeNNMXmHf1dPX08Qi0T7htqPTCv4/ltdecKjwHTrQvtgk6p2Q 1dmw== X-Gm-Message-State: APjAAAUQQ9rkaFstVyql52h3a1vhKF9G7mwMIBHbWrpry07tP/wb5TXJ bODadw/ItucbYH4KPxHobmXe6h21z255mejfitwyng== X-Google-Smtp-Source: APXvYqwzf6zzfeAUMS0ckz2T22Jgno9Fd+oQpA2pZjjVTtlLLnmi/Qx37oGznxvTmQIPOuuG0H2t4PAPPE33WFha6Hs= X-Received: by 2002:a67:ef45:: with SMTP id k5mr43013077vsr.105.1558952120808; Mon, 27 May 2019 03:15:20 -0700 (PDT) MIME-Version: 1.0 References: <1557907020-1548-1-git-send-email-david.marchand@redhat.com> <1558537617-27813-1-git-send-email-david.marchand@redhat.com> <9B028D36-C801-49AC-B529-C8721F0B7D8C@arm.com> <86110770-2603-480C-9D25-371773EC1916@arm.com> In-Reply-To: <86110770-2603-480C-9D25-371773EC1916@arm.com> From: David Marchand Date: Mon, 27 May 2019 12:15:09 +0200 Message-ID: To: Dharmik Thakkar Cc: "dev@dpdk.org" , "thomas@monjalon.net" , Stephen Hemminger , "maxime.coquelin@redhat.com" , "stable@dpdk.org" , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , nd Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/hash: use existing lcore API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Dharmik, On Wed, May 22, 2019 at 9:38 PM Dharmik Thakkar wrote: > > On May 22, 2019, at 12:17 PM, David Marchand > wrote: > > On Wed, May 22, 2019 at 6:27 PM Dharmik Thakkar > wrote: > > > @@ -738,10 +736,9 @@ struct { > > > rte_eal_remote_launch(test_rwc_reader, > > > (void > *)(uintptr_t)read_type, > > > > enabled_core_ids[i]); > > > - rte_eal_mp_wait_lcore(); > > > > > > for (i = 1; i <= rwc_core_cnt[n]; i++) > > > - if (lcore_config[i].ret < 0) > > > + if (rte_eal_wait_lcore(i) < 0) > > if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > > > > (There are similar changes in other functions too. > > I realize that this is a separate issue than what the patch is aimed for. > > If you see fit, please integrate it, else I will put out a patch once > your patch has been merged.) > > > > Indeed, reproduced. > > > Did you have a chance to look at this ? These loops could be reworked by using RTE_LCORE_FOREACH_SLAVE() (so that it automatically skips the master lcore) removing the need for enabled_core_ids[]. -- David Marchand