* [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file
@ 2019-08-19 12:58 Jim Harris
2019-08-20 5:14 ` Tiwei Bie
0 siblings, 1 reply; 3+ messages in thread
From: Jim Harris @ 2019-08-19 12:58 UTC (permalink / raw)
To: dev, maxime.coquelin, tiwei.bie, zhihong.wang
This function is declared __rte_always_inline so it
seems unnecessary to include it in the map file. In
addition, it was included in the EXPERIMENTAL section
even though the function itself is not marked
__rte_experimental.
Found by check-experimental-syms.sh when trying to compile
DPDK with -finstrument-functions.
Signed-off-by: Jim Harris <james.r.harris@intel.com>
---
lib/librte_vhost/rte_vhost_version.map | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
index 5f1d4a75c..4908b9b21 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -82,7 +82,6 @@ EXPERIMENTAL {
rte_vhost_crypto_fetch_requests;
rte_vhost_crypto_finalize_requests;
rte_vhost_crypto_set_zero_copy;
- rte_vhost_va_from_guest_pa;
rte_vhost_host_notifier_ctrl;
rte_vdpa_relay_vring_used;
rte_vhost_extern_callback_register;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file
2019-08-19 12:58 [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file Jim Harris
@ 2019-08-20 5:14 ` Tiwei Bie
2019-08-20 13:08 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Tiwei Bie @ 2019-08-20 5:14 UTC (permalink / raw)
To: Jim Harris; +Cc: dev, maxime.coquelin, zhihong.wang
On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote:
> This function is declared __rte_always_inline so it
> seems unnecessary to include it in the map file. In
> addition, it was included in the EXPERIMENTAL section
> even though the function itself is not marked
> __rte_experimental.
>
> Found by check-experimental-syms.sh when trying to compile
> DPDK with -finstrument-functions.
>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
> ---
> lib/librte_vhost/rte_vhost_version.map | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index 5f1d4a75c..4908b9b21 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -82,7 +82,6 @@ EXPERIMENTAL {
> rte_vhost_crypto_fetch_requests;
> rte_vhost_crypto_finalize_requests;
> rte_vhost_crypto_set_zero_copy;
> - rte_vhost_va_from_guest_pa;
> rte_vhost_host_notifier_ctrl;
> rte_vdpa_relay_vring_used;
> rte_vhost_extern_callback_register;
>
It might be better to mark this function with __rte_experimental
to fix the build with -finstrument-functions, as in this way we can
also get warned when using it with ALLOW_EXPERIMENTAL_API undefined.
And we can have another patch to promote it to stable.
Thanks,
Tiwei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file
2019-08-20 5:14 ` Tiwei Bie
@ 2019-08-20 13:08 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2019-08-20 13:08 UTC (permalink / raw)
To: Tiwei Bie; +Cc: Jim Harris, dev, Maxime Coquelin, Zhihong Wang
On Tue, Aug 20, 2019 at 7:16 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote:
> > This function is declared __rte_always_inline so it
> > seems unnecessary to include it in the map file. In
> > addition, it was included in the EXPERIMENTAL section
> > even though the function itself is not marked
> > __rte_experimental.
> >
> > Found by check-experimental-syms.sh when trying to compile
> > DPDK with -finstrument-functions.
> >
> > Signed-off-by: Jim Harris <james.r.harris@intel.com>
> > ---
> > lib/librte_vhost/rte_vhost_version.map | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> > index 5f1d4a75c..4908b9b21 100644
> > --- a/lib/librte_vhost/rte_vhost_version.map
> > +++ b/lib/librte_vhost/rte_vhost_version.map
> > @@ -82,7 +82,6 @@ EXPERIMENTAL {
> > rte_vhost_crypto_fetch_requests;
> > rte_vhost_crypto_finalize_requests;
> > rte_vhost_crypto_set_zero_copy;
> > - rte_vhost_va_from_guest_pa;
> > rte_vhost_host_notifier_ctrl;
> > rte_vdpa_relay_vring_used;
> > rte_vhost_extern_callback_register;
> >
>
> It might be better to mark this function with __rte_experimental
> to fix the build with -finstrument-functions, as in this way we can
> also get warned when using it with ALLOW_EXPERIMENTAL_API undefined.
> And we can have another patch to promote it to stable.
+1.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-20 13:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 12:58 [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file Jim Harris
2019-08-20 5:14 ` Tiwei Bie
2019-08-20 13:08 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).