DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add eal clean up to the example
Date: Thu, 8 Apr 2021 13:21:44 +0200
Message-ID: <CAJFAV8xExySu_ybA7fNzY+9YS6zckF9GnhN-zK7SVVNKXpD=CA@mail.gmail.com> (raw)
In-Reply-To: <1617877043-11025-1-git-send-email-humin29@huawei.com>

On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>
> From: Chengchang Tang <tangchengchang@huawei.com>
>
> According to the programming guide, the rte_eal_init should be used pairs
> with rte_eal_cleanup.
>
> So, we should add the use of clean up to the hello world example to
> encourage new users of DPDK to use it.
>
> Fixes: af75078fece3 ("first public release")

rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function
to release internal resources") from v18.02.

Other examples probably need fixes too.
$ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc
     52      52    1623


-- 
David Marchand


  reply	other threads:[~2021-04-08 11:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 10:17 Min Hu (Connor)
2021-04-08 11:21 ` David Marchand [this message]
2021-04-08 13:09   ` Min Hu (Connor)
2021-04-14  2:12     ` Min Hu (Connor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xExySu_ybA7fNzY+9YS6zckF9GnhN-zK7SVVNKXpD=CA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=humin29@huawei.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git