From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E01A6A0C43; Thu, 30 Sep 2021 20:44:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCAA6410EB; Thu, 30 Sep 2021 20:44:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 817D3410EC for ; Thu, 30 Sep 2021 20:44:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633027449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ow8XFV/nGq6SAKghzSorPLHeEuFxP9RneC7w6DCmtSo=; b=V6inEJLpq+pGVRiy1gDa1P1tT9u8QCVQ8neI/uQZB8LzOa/kJ0CoybYksf8tbB7Lqg8mOa r+D5Vh3KP389FrajnQoELub61jiDVbRGnxGkCjXcU/MlyufGwCck3yee6nMljxN4GVfX0Z UnmDHcDWlr8ymQhrxznbVd/G0Ok+DoY= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-zldNFpT0MSua9D9cP_J-kg-1; Thu, 30 Sep 2021 14:44:03 -0400 X-MC-Unique: zldNFpT0MSua9D9cP_J-kg-1 Received: by mail-lf1-f71.google.com with SMTP id g9-20020a0565123b8900b003f33a027130so6562273lfv.18 for ; Thu, 30 Sep 2021 11:44:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ow8XFV/nGq6SAKghzSorPLHeEuFxP9RneC7w6DCmtSo=; b=wY/CZhh83k5pIBJVGHWTPcsFYGjfjPMIbsYevi1p28754WNrFk1PZBxwgp6JCjxOMW mRCPlKxDjeBhxpGOXuStGTJIMy/HZONJL9iqn7HO+S+QwE2yBrDIV6ao8fciFFpUZIGA ui7QqGdYocL6+3jpRMMYuDHjW9uhAfIP14jybQcEdE5CH17/uJTMslMiAGyGtPYWeYch FwbCiqiMkmm0wJdG9yHCA4zfBeug0ZX/MnWOkjOfWPWmfs/knSaRSPeOPGFf4Q06RyYs Mdc95CkB9QxQsqS762U44MtJHwXqEE+fo1PaTBMeURRKeGGh5Wl/C+9YM+1WSuE/qq/b SGMg== X-Gm-Message-State: AOAM530U4BKPnev1xJAKM5sAB8cRWWVBwAJL+l41QVLhXhcECclTQdLq 9a0RlIeY27OJ1ihHIrBbD3PrR0gJZIXa1jVCmbZWnbfGNO54uSN/ebIaq1k23CG0D35AifNEQco ZLq7MgCFqKPrUUmfzuvE= X-Received: by 2002:a2e:9a98:: with SMTP id p24mr7557486lji.55.1633027442020; Thu, 30 Sep 2021 11:44:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgXEcf3R+JJlvQlGNYPcjaJIKxvwKuS7f7TsUsERgXkAc+fEJLFSjejnVqdGTwi/oZN8lZeCes+nG768IDX0Q= X-Received: by 2002:a2e:9a98:: with SMTP id p24mr7557464lji.55.1633027441797; Thu, 30 Sep 2021 11:44:01 -0700 (PDT) MIME-Version: 1.0 References: <20210804083128.64981-1-zhihongx.peng@intel.com> In-Reply-To: From: David Marchand Date: Thu, 30 Sep 2021 20:43:50 +0200 Message-ID: To: "Peng, ZhihongX" Cc: Kevin Traynor , "Xia, Chenbo" , Maxime Coquelin , dev , Ivan Ilchenko , dpdk stable , Christian Ehrhardt , "Xueming(Steven) Li" , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [DPDK] net/virtio: fix check scatter on all Rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 22, 2021 at 10:13 AM Peng, ZhihongX wrote: > > On 15/09/2021 19:37, David Marchand wrote: > > > On Wed, Aug 4, 2021 at 10:36 AM wrote: > > >> > > >> From: Zhihong Peng > > >> > > >> This patch fixes the wrong way to obtain virtqueue. > > >> The end of virtqueue cannot be judged based on whether the array is > > >> NULL. > > > > > > Indeed, good catch. > > > > > > I can reproduce a crash with v20.11.3 which has backport of 4e8169eb0d2d. > > > I can not see it with main: maybe due to a lucky allocation or size > > > requested to rte_zmalloc... ? > > > > > This problem was discovered through google asan, we have submitted DPDK ASan patch. > http://patchwork.dpdk.org/project/dpdk/patch/20210918074155.872358-1-zhihongx.peng@intel.com/ Can you work on a v2? Maxime had comments. https://inbox.dpdk.org/dev/e1c512c1-9766-1cd8-816b-8a77d13d53d6@redhat.com/ -- David Marchand