From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file
Date: Thu, 8 Apr 2021 18:11:36 +0200 [thread overview]
Message-ID: <CAJFAV8xFXRbQrV=mOsSWT_UJVJZwgobA7HkzVj1kt+ngEax1+g@mail.gmail.com> (raw)
In-Reply-To: <20210406175910.24450-1-david.marchand@redhat.com>
On Tue, Apr 6, 2021 at 7:59 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Rather than have two files that keeps getting out of sync, let's
> annotate the version.map to generate the Windows export file.
>
> Note: Existing version.map annotation achieved with:
> $ for dir in lib/librte_eal drivers/common/mlx5; do
> ./buildtools/map-list-symbol.sh $dir/*.map |
> while read file version sym; do
> ! git grep -qw $sym $dir/*.def || continue;
> sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map;
> done;
> done
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Updated commitlog and sorted common/mlx5 updates (from offlist
comments with Thomas).
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-04-08 16:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 16:32 [dpdk-dev] [PATCH] " David Marchand
2021-04-06 16:40 ` David Marchand
2021-04-06 16:50 ` Bruce Richardson
2021-04-06 16:53 ` David Marchand
2021-04-07 20:06 ` Kinsella, Ray
2021-04-06 17:59 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-04-06 18:52 ` Thomas Monjalon
2021-04-06 20:09 ` David Marchand
2021-04-06 22:39 ` Thomas Monjalon
2021-04-07 8:16 ` David Marchand
2021-04-07 8:53 ` Dmitry Kozlyuk
2021-04-07 8:57 ` Thomas Monjalon
2021-04-07 11:38 ` Tal Shnaiderman
2021-04-08 14:51 ` Thomas Monjalon
2021-04-08 16:11 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xFXRbQrV=mOsSWT_UJVJZwgobA7HkzVj1kt+ngEax1+g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=nhorman@tuxdriver.com \
--cc=pallavi.kadam@intel.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).