From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D0FAA0579; Thu, 8 Apr 2021 18:11:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A537D14113C; Thu, 8 Apr 2021 18:11:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5F2294068B for ; Thu, 8 Apr 2021 18:11:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617898311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TCWBkoGVtrjqMFJ1Ud99KyDPs3os36Le7QkStrhooTU=; b=iK9bOr0VLZEkqdesBfUfWI6Yknb+cpAehhp0OtaldQzzHGT2Sa3Mv5X1Ged4WN0mmhEJZs Y+GIFUTCnQJpNEsv+RJQnGJHU2m+Uidvrbpvj70Iz23pAWaevqp9R6qntaP737ZdQGDVHF 8OCtnQk8NdRrho9/0NrQ7/yRpGnXZuw= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-bLwGEF4KNAWE7Y8aEPjEkg-1; Thu, 08 Apr 2021 12:11:49 -0400 X-MC-Unique: bLwGEF4KNAWE7Y8aEPjEkg-1 Received: by mail-lf1-f70.google.com with SMTP id w21so1072588lfk.0 for ; Thu, 08 Apr 2021 09:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TCWBkoGVtrjqMFJ1Ud99KyDPs3os36Le7QkStrhooTU=; b=c6Oo66hkCPUT0Y9KsH1p4XM/qLidEIuMpHNTeAlZiamMXsSHozc93mFWoXbxVUog7i LBr0kb/pjugjd987WGdSw8UhldCI+sly/4NyfhzKLOug2I2Nb6tzt8W5PKNmHlZfbrQn uKvVxfMHmXvCfYVja93R8yHfNAYTKK+AYdhjGfmVz7uliXTcLb/oL9EYMKB/Hp0ofuyk 9D9A9xezxOVx6xI4uBbXAaqYO4mNGi+FLbe2zVU7hmG6dxfsvzExBnHgjXvNqOEgLX+X bJ9vnamzsuOglHuy1yICsZNYUd0avebVtNyr/hisKTBqjdR5eRywj5256uJ0G/IKvKKz HNXQ== X-Gm-Message-State: AOAM532YOiCAqND+ybTuztrAjo6wDy265O24vh0iVQrk5aAwUalEoleA NjevfXvuCrws0rXdIroMKZTWyjknXz93Tq6kwhr5jdEpr/SqpE/zNVQvVINwmQeN71zJgjU3M1i lc+rD88DC5T7D9IelZso= X-Received: by 2002:a19:c7c3:: with SMTP id x186mr6849658lff.76.1617898307936; Thu, 08 Apr 2021 09:11:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfP9OLA3GvGlZTJSyLHkcRDi/iQU1IpHLgXqUt1ROYFCIKmIJ7P4Kfjccl1SLpPgixQf1SvBFd42zcndtT3CQ= X-Received: by 2002:a19:c7c3:: with SMTP id x186mr6849640lff.76.1617898307764; Thu, 08 Apr 2021 09:11:47 -0700 (PDT) MIME-Version: 1.0 References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406175910.24450-1-david.marchand@redhat.com> In-Reply-To: <20210406175910.24450-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 8 Apr 2021 18:11:36 +0200 Message-ID: To: dev Cc: Thomas Monjalon , Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 6, 2021 at 7:59 PM David Marchand wrote: > > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: Existing version.map annotation achieved with: > $ for dir in lib/librte_eal drivers/common/mlx5; do > ./buildtools/map-list-symbol.sh $dir/*.map | > while read file version sym; do > ! git grep -qw $sym $dir/*.def || continue; > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map; > done; > done > > Signed-off-by: David Marchand Tested-by: Tal Shnaiderman Acked-by: Thomas Monjalon Updated commitlog and sorted common/mlx5 updates (from offlist comments with Thomas). Applied, thanks. -- David Marchand