From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 756A742D10; Wed, 21 Jun 2023 09:44:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D9C1406BC; Wed, 21 Jun 2023 09:44:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 699D84068E for ; Wed, 21 Jun 2023 09:44:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687333445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uYROf7XGde7la/FuXWF8GDg6gACnJWbQgUwEhIm3kmI=; b=Twd4ANV7pCryKFwtWuuFNvWQzeBPQRNnoHnxTag21NLq9HUez4TXo0J3q5HuHOTR13zj3G 1LXoeuONFKA620cZuxiWaXHakJUTbFNI0Q3HxT1LhtP7kUGDSBRQgr78NquJzvDOZlqAll 1fmfkEm4L+COE8+zZeVeaZLcLRigJms= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-482-52fprAyRN4S7nbsmPRqjlQ-1; Wed, 21 Jun 2023 03:44:01 -0400 X-MC-Unique: 52fprAyRN4S7nbsmPRqjlQ-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-25edb0c31ccso1598092a91.0 for ; Wed, 21 Jun 2023 00:44:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687333440; x=1689925440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uYROf7XGde7la/FuXWF8GDg6gACnJWbQgUwEhIm3kmI=; b=U01uJUleSsm+c73x7TSuNLG3tgPwGKCaiUwp+nMq1zsr7z6Af37qF0NEm0D0v0RBAN 3lUedRD/qOLaUpf4IYrnDFnGFAl163Z2E5Ky90B+mxdtYKt7zIW8TAWzqZ5AUdCXeGfx dDBHxufLwsvgL1mLLO64AvQDjIvuaTDyY3fBn6o2n/DODhLG7F5Hg0OLlvdqqOtHhkuu C0gIAPjMHuE1RYsMKXwdqKLcRIyo5hswS0CluGMKOaYuRVvbnCDJDjK4Psht/5vSRY2R 7LOh/euO1YfcPxpRXtcW504uBomy56qHa8Rp3O7FiuYkSrZ2/PoBiX33qWQ9g/N5fhdo IjEw== X-Gm-Message-State: AC+VfDy9W2xl1+VRfkX5pRwXHPVxV4kh7KbAJ/DLZDq3cTvcar+FSvh+ 9D5DP+9bBCYX+qxL2scQcYOUE2wdhAEQCuIILzxaJXIKMz4v5Fgpb8u7/Eb3JowbnVE86nKIZTj +QXytnQuH4YoeUOlQhE4= X-Received: by 2002:a17:90b:f90:b0:25b:e0fa:318e with SMTP id ft16-20020a17090b0f9000b0025be0fa318emr8896065pjb.2.1687333440589; Wed, 21 Jun 2023 00:44:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4EMLQ/Daj00yKfr6keJ8vZIfstZdItihltvvxn6lgIn8ioaBEsbe5rxOCE+701Rm/8S2b7YGBX9nIEAIrnFjA= X-Received: by 2002:a17:90b:f90:b0:25b:e0fa:318e with SMTP id ft16-20020a17090b0f9000b0025be0fa318emr8896056pjb.2.1687333440308; Wed, 21 Jun 2023 00:44:00 -0700 (PDT) MIME-Version: 1.0 References: <20230505103102.2912297-1-david.marchand@redhat.com> <20230620111028.4116505-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 21 Jun 2023 09:43:49 +0200 Message-ID: Subject: Re: [RFC PATCH v3] ethdev: advertise flow restore in mbuf To: Slava Ovsiienko , Ali Alnubani Cc: "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "i.maximets@ovn.org" , Aman Singh , Yuying Zhang , Matan Azrad , Ori Kam , Suanming Mou , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Andrew Rybchenko , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Tue, Jun 20, 2023 at 6:44=E2=80=AFPM Slava Ovsiienko wrote: > > As reported by Ilya [1], unconditionally calling > > rte_flow_get_restore_info() impacts an application performance for driv= ers > > that do not provide this ops. > > It could also impact processing of packets that require no call to > > rte_flow_get_restore_info() at all. > > > > Register a dynamic mbuf flag when an application negotiates tunnel meta= data > > delivery (calling rte_eth_rx_metadata_negotiate() with > > RTE_ETH_RX_METADATA_TUNNEL_ID). > > > > Drivers then advertise that metadata can be extracted by setting this d= ynamic > > flag in each mbuf. > > > > The application then calls rte_flow_get_restore_info() only when requir= ed. > > > > Link: http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8- > > 7f659bfa40de@ovn.org/ > > Signed-off-by: David Marchand > > We did not notice the degradation, so: > Acked-by: Viacheslav Ovsiienko Cool, thanks for testing! Should I add some Tested-by: tag from Ali? I guess he was the one who did the testing. I'll post a non-RFC patch for the CI to pass on it. --=20 David Marchand