From: David Marchand <david.marchand@redhat.com>
To: Paul Szczepanek <paul.szczepanek@arm.com>
Cc: dev@dpdk.org, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [PATCH v7 2/4] test: add pointer compress tests to ring perf test
Date: Thu, 7 Mar 2024 12:27:34 +0100 [thread overview]
Message-ID: <CAJFAV8xFZ1wTJPX5Qw9g9NKpE-zZP3jWJmu6AvHCX=2iQw4ywQ@mail.gmail.com> (raw)
In-Reply-To: <20240301102104.20074-3-paul.szczepanek@arm.com>
On Fri, Mar 1, 2024 at 11:21 AM Paul Szczepanek <paul.szczepanek@arm.com> wrote:
>
> Add a test that runs a zero copy burst enqueue and dequeue on a ring
> of raw pointers and compressed pointers at different burst sizes to
> showcase performance benefits of newly added pointer compression APIs.
>
> Refactored threading code to pass more parameters to threads to
> reuse existing code. Added more bulk sizes to showcase their effects
> on compression. Adjusted loop iteration numbers to take into account
> bulk sizes to keep runtime constant (instead of number of operations).
>
> Adjusted old printfs to match new ones which have aligned numbers.
>
> Signed-off-by: Paul Szczepanek <paul.szczepanek@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> app/test/test_ring.h | 94 +++++++++-
> app/test/test_ring_perf.c | 354 +++++++++++++++++++++++++-------------
> 2 files changed, 324 insertions(+), 124 deletions(-)
>
> diff --git a/app/test/test_ring.h b/app/test/test_ring.h
> index 45c263f3ff..3b00f2465d 100644
> --- a/app/test/test_ring.h
> +++ b/app/test/test_ring.h
> @@ -1,10 +1,12 @@
> /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright(c) 2019 Arm Limited
> + * Copyright(c) 2019-2023 Arm Limited
Thomas insisted recently that updating copyrights in this manner is not needed.
https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-not-bump-the-year-on-change
--
David Marchand
next prev parent reply other threads:[~2024-03-07 11:27 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 15:08 [RFC 0/2] add pointer compression API Paul Szczepanek
2023-09-27 15:08 ` [RFC 1/2] eal: add pointer compression functions Paul Szczepanek
2023-10-09 15:54 ` Thomas Monjalon
2023-10-11 13:36 ` Honnappa Nagarahalli
2023-10-11 16:43 ` Paul Szczepanek
2023-10-11 12:43 ` [RFC v2 0/2] add pointer compression API Paul Szczepanek
2023-10-11 12:43 ` [RFC v2 1/2] eal: add pointer compression functions Paul Szczepanek
2023-10-11 12:43 ` [RFC v2 2/2] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 0/3] add pointer compression API Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 1/3] eal: add pointer compression functions Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 2/3] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-10-31 18:10 ` [PATCH v3 3/3] docs: add pointer compression to the EAL guide Paul Szczepanek
2023-11-01 7:42 ` [PATCH v3 0/3] add pointer compression API Morten Brørup
2023-11-01 12:52 ` Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 0/4] " Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 1/4] eal: add pointer compression functions Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2023-11-01 12:46 ` [PATCH v4 4/4] test: add unit test for ptr compression Paul Szczepanek
2023-11-01 18:12 ` [PATCH v5 0/4] add pointer compression API Paul Szczepanek
2023-11-01 18:12 ` [PATCH v5 1/4] eal: add pointer compression functions Paul Szczepanek
2024-02-11 15:32 ` Konstantin Ananyev
2023-11-01 18:12 ` [PATCH v5 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-11-01 18:13 ` [PATCH v5 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2023-11-01 18:13 ` [PATCH v5 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-02-22 8:15 ` [PATCH v5 0/4] add pointer compression API Paul Szczepanek
2024-02-22 16:16 ` Konstantin Ananyev
2024-03-01 11:16 ` Morten Brørup
2024-03-01 16:12 ` Patrick Robb
2024-03-01 19:57 ` Honnappa Nagarahalli
2024-03-02 10:33 ` Morten Brørup
2024-03-06 22:31 ` Paul Szczepanek
2024-03-07 2:13 ` Honnappa Nagarahalli
2024-03-04 14:44 ` Konstantin Ananyev
2024-05-15 17:00 ` Paul Szczepanek
2024-05-15 22:34 ` Morten Brørup
2024-05-16 8:25 ` Paul Szczepanek
2024-05-16 8:40 ` Konstantin Ananyev
2024-02-29 16:03 ` [PATCH v6 " Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 1/4] eal: add pointer compression functions Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2024-02-29 16:03 ` [PATCH v6 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-03-01 10:21 ` [PATCH v7 0/4] add pointer compression API Paul Szczepanek
2024-03-01 10:21 ` [PATCH v7 1/4] eal: add pointer compression functions Paul Szczepanek
2024-03-07 11:22 ` David Marchand
2024-03-01 10:21 ` [PATCH v7 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-07 11:27 ` David Marchand [this message]
2024-03-01 10:21 ` [PATCH v7 3/4] docs: add pointer compression to the EAL guide Paul Szczepanek
2024-03-01 10:21 ` [PATCH v7 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-03-07 11:30 ` David Marchand
2024-03-07 20:39 ` [PATCH v7 0/4] add pointer compression API Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 1/4] ptr_compress: add pointer compression library Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 2/4] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 3/4] docs: add pointer compression guide Paul Szczepanek
2024-03-07 20:39 ` [PATCH v8 4/4] test: add unit test for ptr compression Paul Szczepanek
2024-03-08 8:27 ` [PATCH v7 0/4] add pointer compression API David Marchand
2024-03-10 19:34 ` Honnappa Nagarahalli
2024-03-11 7:44 ` David Marchand
2024-03-11 14:47 ` [PATCH v9 0/5] " Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 1/5] lib: allow libraries with no sources Paul Szczepanek
2024-03-11 15:23 ` Bruce Richardson
2024-03-15 8:33 ` Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 2/5] ptr_compress: add pointer compression library Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 3/5] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 4/5] docs: add pointer compression guide Paul Szczepanek
2024-03-11 14:47 ` [PATCH v9 5/5] test: add unit test for ptr compression Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 0/5] add pointer compression API Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 1/5] lib: allow libraries with no sources Paul Szczepanek
2024-03-15 9:14 ` Bruce Richardson
2024-03-11 20:31 ` [PATCH v10 2/5] ptr_compress: add pointer compression library Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 3/5] test: add pointer compress tests to ring perf test Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 4/5] docs: add pointer compression guide Paul Szczepanek
2024-03-11 20:31 ` [PATCH v10 5/5] test: add unit test for ptr compression Paul Szczepanek
2023-09-27 15:08 ` [RFC 2/2] test: add pointer compress tests to ring perf test Paul Szczepanek
2023-10-09 15:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xFZ1wTJPX5Qw9g9NKpE-zZP3jWJmu6AvHCX=2iQw4ywQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=paul.szczepanek@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).