From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5286043E42; Thu, 11 Apr 2024 10:30:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DFE74067E; Thu, 11 Apr 2024 10:30:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1B83C4067A for ; Thu, 11 Apr 2024 10:30:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712824236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/TSH7QtEyYOSBvwTXCX+wKiBtDa0dOtk17H0qDqqxqM=; b=Q9+tuXvukcff7Ht/xaPLak4JB7Tb/yEhlVDQebwTsSeWF+r7jaoTZHM5WLqa60uZVIRLxN hyZ94dBvF9SuNAF28tlhIADJPwUfR+r1xApkfWfkl1NG7VgViwIwxcyTxv6fmQkL8fJSVD geqD+DLJKlgM+YtUCwDXqlo3t9LWkHQ= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-xzUrVkq3OGW3qeCKTsdm4g-1; Thu, 11 Apr 2024 04:30:34 -0400 X-MC-Unique: xzUrVkq3OGW3qeCKTsdm4g-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d8a7bb09afso26365711fa.0 for ; Thu, 11 Apr 2024 01:30:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712824233; x=1713429033; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/TSH7QtEyYOSBvwTXCX+wKiBtDa0dOtk17H0qDqqxqM=; b=T/dA5lhNy603cEUEZNTkqTwsBvRHL5Jen4ZxwVfJ86SBXXEM2XiEbSDYVMn/CiSErd I5+kPFbhYe51Pq1WuzxlnrlOoCOmV+ay0qSOTbwFE0+xs9+h/dssql9yoC0abeoUB2Gd 6HQo2OBXbq146KKi5r5NHIRfXhbXUXDlEgWoH/Fl5iCgd5XWKgHUsTADRgwWSE2fDIrn 618AhwqUhcipWS6WgzjlpD9zNqCRpzw+brn6JbRIcqCcha4yN+v/OmSzirm7kZp6q3xm ZBg40wjhF7GK6rY1otzDvcyRf9kxFUJhfpSY5bCZGidXzx+4dn7Ut9lKEXz9/lwD6fPF O0KQ== X-Gm-Message-State: AOJu0YxMP4h9pI2XmheA3Y2xA1Hna/N2ilFL9rRSyeOUMJlXOQRB8ZVN odevF+euvJpS6626h2vrGm64k/gBbRNuwouEd9B9AlYyeaC/qlyWEVea6hZxJU9SXK+CU11tWM4 MyiNd5w09sP/VTXtcYKaypVgrrbakfasbiTV+18JnqSgaBmDsDeHCeUFNW/Tszd8YBoB2n4Q3Xm MTdEQAmHm+n3oaaPg= X-Received: by 2002:a2e:b753:0:b0:2d8:7b22:fb4 with SMTP id k19-20020a2eb753000000b002d87b220fb4mr2680372ljo.0.1712824232931; Thu, 11 Apr 2024 01:30:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExZuUgNdbtmYE06D9WSmSTzJDQfSezJDCT9EMKLkwecnCDyEK+bb1081ZKHw1t4IGK07TZQoDjhxszVpOjfUo= X-Received: by 2002:a2e:b753:0:b0:2d8:7b22:fb4 with SMTP id k19-20020a2eb753000000b002d87b220fb4mr2680354ljo.0.1712824232591; Thu, 11 Apr 2024 01:30:32 -0700 (PDT) MIME-Version: 1.0 References: <20240405125039.897933-1-david.marchand@redhat.com> <20240405144604.906695-1-david.marchand@redhat.com> <20240405144604.906695-3-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 11 Apr 2024 10:30:19 +0200 Message-ID: Subject: Re: [PATCH v2 2/8] net/ice: enhance debug when HW fails to transmit To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 8, 2024 at 5:23=E2=80=AFPM Bruce Richardson wrote: > > On Fri, Apr 05, 2024 at 04:45:56PM +0200, David Marchand wrote: > > At the moment, if the driver sets an incorrect Tx descriptor, the HW > > will raise a MDD event reported as: > > ice_interrupt_handler(): OICR: MDD event > > > > Add some debug info for this case and the VF index in all logs. > > > > Signed-off-by: David Marchand > > --- > > drivers/net/ice/ice_ethdev.c | 29 +++++++++++++++++++++++++---- > > 1 file changed, 25 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.= c > > index 87385d2649..fd494e6b3b 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -1389,6 +1389,7 @@ ice_interrupt_handler(void *param) > > uint32_t oicr; > > uint32_t reg; > > uint8_t pf_num; > > + uint16_t vf_num; > > uint8_t event; > > uint16_t queue; > > int ret; > > @@ -1432,28 +1433,48 @@ ice_interrupt_handler(void *param) > > if (reg & GL_MDET_TX_PQM_VALID_M) { > > pf_num =3D (reg & GL_MDET_TX_PQM_PF_NUM_M) >> > > GL_MDET_TX_PQM_PF_NUM_S; > > + vf_num =3D (reg & GL_MDET_TX_PQM_VF_NUM_M) >> > > + GL_MDET_TX_PQM_VF_NUM_S; > > event =3D (reg & GL_MDET_TX_PQM_MAL_TYPE_M) >> > > GL_MDET_TX_PQM_MAL_TYPE_S; > > queue =3D (reg & GL_MDET_TX_PQM_QNUM_M) >> > > GL_MDET_TX_PQM_QNUM_S; > > > > PMD_DRV_LOG(WARNING, "Malicious Driver Detection = event " > > - "%d by PQM on TX queue %d PF# %d", > > - event, queue, pf_num); > > + "%d by PQM on TX queue %d PF# %d VF# = %d", > > + event, queue, pf_num, vf_num); > > } > > > Would this output be misleading in the case where there is no VF involved > and the actual MDD error comes from the PF? I will check, but IIRC, the queue here is an "absolute" queue number that should help figure out whether it is the PF or a VF in the case vf_num =3D=3D 0. --=20 David Marchand