DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] eal/x86: fix 32-bit write-combined stores
@ 2024-09-06 13:27 Bruce Richardson
  2024-09-06 15:18 ` Radu Nicolau
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Bruce Richardson @ 2024-09-06 13:27 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson, radu.nicolau, stable

The "movdiri" instruction is given as a series of bytes in rte_io.h so
that it works on compilers/assemblers which are unaware of the
instruction. The REX prefix (0x40) on this instruction is invalid for
32-bit code, causing issues. Thankfully, the prefix is unnecessary in
64-bit code, since the data size used is 32-bits.

Fixes: 8a00dfc738fe ("eal: add write combining store")
Cc: radu.nicolau@intel.com
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/eal/x86/include/rte_io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/eal/x86/include/rte_io.h b/lib/eal/x86/include/rte_io.h
index 0e1fefdee1..5366e09c47 100644
--- a/lib/eal/x86/include/rte_io.h
+++ b/lib/eal/x86/include/rte_io.h
@@ -24,7 +24,7 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr)
 {
 	asm volatile(
 		/* MOVDIRI */
-		".byte 0x40, 0x0f, 0x38, 0xf9, 0x02"
+		".byte 0x0f, 0x38, 0xf9, 0x02"
 		:
 		: "a" (value), "d" (addr));
 }
--
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-04 14:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-06 13:27 [PATCH] eal/x86: fix 32-bit write-combined stores Bruce Richardson
2024-09-06 15:18 ` Radu Nicolau
2024-09-12  5:56 ` Tyler Retzlaff
2024-10-04 14:45 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).