From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58E814246E; Mon, 23 Jan 2023 15:42:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECA3A400EF; Mon, 23 Jan 2023 15:42:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 88B49400D4 for <dev@dpdk.org>; Mon, 23 Jan 2023 15:42:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674484951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kbtA+IdIqjeibSN7+k0822IWwalC87BTUyUgIfk4W6w=; b=IJoTYAGD2aMFix/1Pf39REzFh/SkxwDnP2Jl5V0z6aGDMZy0tUzDI3q8O9cobtcudROt+W J+T40D0eCA+yjLQoyrAPWdJv7Dw8eQDIf4vhrm7cIS9pwGX1wFSVSVdAGy3yZrOlvx7Zfv dyq4DWwL/Y6OJwjvLMDgEW6WoprhndQ= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-371-7lTtVnq4NQG44KGaNndjqg-1; Mon, 23 Jan 2023 09:42:30 -0500 X-MC-Unique: 7lTtVnq4NQG44KGaNndjqg-1 Received: by mail-pf1-f197.google.com with SMTP id f22-20020a056a00239600b0058d956679f5so5366551pfc.5 for <dev@dpdk.org>; Mon, 23 Jan 2023 06:42:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kbtA+IdIqjeibSN7+k0822IWwalC87BTUyUgIfk4W6w=; b=B9VeKojh5YGcxNuqt6Xc8mmxgLtGHD+3CLlY5xhyFBVkx3KKRFimnOqUWKJisTe30W wvmmXlMMkrNTM4QhCdwdQQJD55lPxrR7Y0jp+W1duzbD0WcR/ylhigk5k+VsSfdtVCxY ropNZvNgJYRUiWeQ2HlbcVdjG9ANd6tERx27sSb0J4LlgXT8wm9tfk+O1DddkMCclRWM q2noJf4NTaeM28IXv4sFzM7d3+yVcQZzC8vHNq33EPoUyqACqcvZlGpD9AIcFjUaypBz ydvVD00xDOkPaysyVhTq0xkOf6495BUI+WGYx+myhCjj//PTAynAi2SgUH8XaAHb84sd r1tw== X-Gm-Message-State: AFqh2kokxGZlC8CEka3aRj9QNaobz1/saEkJ8zJN0gkSbLK89TXZ5wvn 7Vnsb0gifVMrnKS1m8jKZDYx7g+dGnBx7tGQe3Fhhxm9c0faCxeuhkiHQKJBmRzEdqsX5TLKAcg monxr33NPdUFo+b4aDqQ= X-Received: by 2002:a17:90a:e384:b0:22b:b217:e5ea with SMTP id b4-20020a17090ae38400b0022bb217e5eamr1467688pjz.206.1674484948932; Mon, 23 Jan 2023 06:42:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXu0KivNss9R+TZjgUkuwDbxwExa51xaZZLJDhMuKAEl9wFcyDg2YqZi/U55kU9eCtKYKBL/KaHnsQzm6ulu04g= X-Received: by 2002:a17:90a:e384:b0:22b:b217:e5ea with SMTP id b4-20020a17090ae38400b0022bb217e5eamr1467680pjz.206.1674484948588; Mon, 23 Jan 2023 06:42:28 -0800 (PST) MIME-Version: 1.0 References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230120182154.481039-1-bruce.richardson@intel.com> <CAJFAV8wB6cKsUvkRo2-qK+DNfuUSs7ei9Gta1DhQ7awfae3hNA@mail.gmail.com> <Y86Yns5mJFu9018T@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8zRAf138AUrwtNZCydQnRTrYqM22_fpdvUFhbTxUdMszg@mail.gmail.com> <Y86bdzSf0b9xQpMV@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <Y86bdzSf0b9xQpMV@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Mon, 23 Jan 2023 15:42:17 +0100 Message-ID: <CAJFAV8xHfFJbh9Uv4gmv1aeufwDiuS9uQgGaSKttkR2dNAu2Hw@mail.gmail.com> Subject: Re: [PATCH v4 0/3] Split logging functionality out of EAL To: Bruce Richardson <bruce.richardson@intel.com>, Dodji Seketeli <dodji@redhat.com> Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Jan 23, 2023 at 3:37 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Mon, Jan 23, 2023 at 03:31:58PM +0100, David Marchand wrote: > > On Mon, Jan 23, 2023 at 3:24 PM Bruce Richardson > > <bruce.richardson@intel.com> wrote: > > > > > > On Sun, Jan 22, 2023 at 03:56:12PM +0100, David Marchand wrote: > > > > Hi Bruce, > > > > > > > > On Fri, Jan 20, 2023 at 7:22 PM Bruce Richardson > > > > <bruce.richardson@intel.com> wrote: > > > > > > > > > > There is a general desire to reduce the size and scope of EAL. To this > > > > > end, this patchset makes a (very) small step in that direction by taking > > > > > the logging functionality out of EAL and putting it into its own library > > > > > that can be built and maintained separately. > > > > > > > > > > As with the first RFC for this, the main obstacle is the "fnmatch" > > > > > function which is needed by both EAL and the new log function when > > > > > building on windows. While the function cannot stay in EAL - or we would > > > > > have a circular dependency, moving it to a new library or just putting > > > > > it in the log library have the disadvantages that it then "leaks" into > > > > > the public namespace without an rte_prefix, which could cause issues. > > > > > Since only a single function is involved, subsequent versions take a > > > > > different approach to v1, and just moves the offending function to be a > > > > > static function in a header file. This allows use by multiple libs > > > > > without conflicting names or making it public. > > > > > > > > > > The other complication, as explained in v1 RFC was that of multiple > > > > > implementations for different OS's. This is solved here in the same > > > > > way as v1, by including the OS in the name and having meson pick the > > > > > correct file for each build. Since only one file is involved, there > > > > > seemed little need for replicating EAL's separate subdirectories > > > > > per-OS. > > > > > > > > There is another complication. > > > > > > > > The ABI check is not handling properly the case where symbols are > > > > moved to the new log library (even though the dependency to librte_log > > > > is explicit in librte_eal elf). > > > > For now, I don't have a good way to handle this. > > > > > > > > A workaround to pass the check is to suppress those symbols wrt the eal dump: > > > > [suppress_function] > > > > symbol_name_regexp = rte_log > > > > [suppress_function] > > > > symbol_name = rte_openlog_stream > > > > [suppress_function] > > > > symbol_name = rte_vlog > > > > > > > > But this is not a good solution because we would be losing checks on > > > > them for the rest of the v23 ABI life. > > > > > > > Right, I got error messages from the CI job for this too, but I also have > > > no idea how to work around this. Perhaps we only get to move content > > > between libraries when we do an ABI bump? Seems a bit restrictive, though. > > > > Moving symbols as you did does not seem an ABI breakage. > > An application that links to eal would see the dt_needed entry for the > > new log library, load it accordingly and gets the right symbols. > > > Yes, I agree. However, I also agree with you that it is risky to lose > symbol checking for the moved symbols if we need to remove them from > analysis. That said, maybe others have some ideas as to how to work around > this, or perhaps we just take the risk of disabling checking. I opened a bz for libabigail. https://sourceware.org/bugzilla/show_bug.cgi?id=30034 If it is handled fast enough, we may have a solution by the time 23.03 is released and we will remove this workaround for 23.07 development (no pressure Dodji :-p). -- David Marchand