Re: [PATCH v6 4/8] build: generate symbol maps

[David Marchand <david.marchand@redhat.com>]

On Wed, Apr 2, 2025 at 10:06 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 28/03/2025 11:52, David Marchand:
> > --- /dev/null
> > +++ b/lib/eal/common/eal_symbol_exports.h
> > @@ -0,0 +1,16 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright (c) 2025 Red Hat, Inc.
> > + */
> > +
> > +#ifndef EAL_SYMBOL_EXPORTS_H
> > +#define EAL_SYMBOL_EXPORTS_H
> > +
> > +/* Internal macros for exporting symbols, used by the build system.
> > + * For RTE_EXPORT_EXPERIMENTAL_SYMBOL, ver indicates the
> > + * version this symbol was introduced in.
> > + */
> > +#define RTE_EXPORT_EXPERIMENTAL_SYMBOL(a, ver)
> > +#define RTE_EXPORT_INTERNAL_SYMBOL(a)
> > +#define RTE_EXPORT_SYMBOL(a)
> > +
> > +#endif /* EAL_SYMBOL_EXPORTS_H */
>
> Another thought, there is no specific reason to have a "s"
> at the end of this filename.
>
> eal_symbol_export.h looks better to me.
> Or simply eal_export.h ?

I don't think there is other notions that will be about "exporting",
so implicit eal_export.h looks ok.


-- 
David Marchand