From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61B6FA0548; Fri, 9 Jul 2021 17:03:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49BF4416AD; Fri, 9 Jul 2021 17:03:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4670E4014D for <dev@dpdk.org>; Fri, 9 Jul 2021 17:03:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625843025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GjXDKoRHc04HVrOvRnpI91XrmabCHVr70hpLlj7Hz8A=; b=chf44DXdBBAU2s2vy7QjTo+wL2u8bE4MCRtHgcuLXAqW6tT8yLh2fJ0rFM7YcoWtn1GaRL OezYpgobeJ+zBwSJIbTe1gQ3m7tJJU3VY5tlh2eZD4nRsKftFnKuTDY2CEVQOK4B2rFWYt +gW93PFSsaKWCOEBgGCvmUcwjgemnqI= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-6IEjpn_oMbuq08CSA-N2Zw-1; Fri, 09 Jul 2021 11:03:44 -0400 X-MC-Unique: 6IEjpn_oMbuq08CSA-N2Zw-1 Received: by mail-ua1-f69.google.com with SMTP id x6-20020ab036e60000b02902994703ad42so3685201uau.19 for <dev@dpdk.org>; Fri, 09 Jul 2021 08:03:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GjXDKoRHc04HVrOvRnpI91XrmabCHVr70hpLlj7Hz8A=; b=fSjz+VB2v2idRsXZA/17odHyywWjqXC++DjHZZEYSpWIIpOsL0i/So7cklp13Keg18 Sq53xXok1RlXTg9DI4P05r2s16I4nbZt3Vj9a2XjRGvkOacgBORJKcl8Y5DWFfpDlvfd 40x/Sc8vvgGj2xW9vrMf8U/qkV6yxbYcpyaX8BzpyDwzw+CHPtoarxNM89wOl03ZKt/T JRWHifTtpuQ309EX15dLmGEBp0pO1bxK0Lov30AxI0Ne/fSgdUetUVQE5vDX4vxv1ZZL K6WVDUCpSomH7DLqKhh01Iy33DGdfZZ5zX1TvzA9nFSDRQbuNE0w17HSHnXqZRy486om 3j/w== X-Gm-Message-State: AOAM530V96IYjZ5dup21JuBqKiKWB7wwZLoSgrTPP2j0aP3pA5LEyk74 lb8PgXUgb8c+ZTgY0zoZsgW48k5hPWsm0/Nh2hkhxs5pL1mYEfGIUBPdigEQkmA6IoBISbEKsNb aFt0PWCBjIgJTsJpRJ+8= X-Received: by 2002:ab0:211a:: with SMTP id d26mr38589033ual.41.1625843024228; Fri, 09 Jul 2021 08:03:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeh0m8C5+di+f5aX1CJRVIFIBy20/C+E83Dm7gMSB2/xSNP72XvjF5W87az7WT5pZNeW2G4/wz0drjuUfMxjI= X-Received: by 2002:ab0:211a:: with SMTP id d26mr38589011ual.41.1625843024024; Fri, 09 Jul 2021 08:03:44 -0700 (PDT) MIME-Version: 1.0 References: <cover.1622548381.git.anatoly.burakov@intel.com> <8007029ea9e5129ea43f0c11708169406a16727f.1622548381.git.anatoly.burakov@intel.com> <DM6PR11MB4491619FE571C85E788BB6219A0A9@DM6PR11MB4491.namprd11.prod.outlook.com> <53ac7ee0-e4bc-099a-2ddd-0d74949eea9d@intel.com> <DM6PR11MB4491A8C6C27B2DFBE35F99D49A089@DM6PR11MB4491.namprd11.prod.outlook.com> <249f6957-0f10-926f-9f0e-5cb10fc4d2c3@intel.com> <DM6PR11MB4491F20D7A128F06878E0BB99A089@DM6PR11MB4491.namprd11.prod.outlook.com> <22ddddf1-6523-8219-dcef-86205e662756@intel.com> <DM6PR11MB4491C264823DE29484F020E19A089@DM6PR11MB4491.namprd11.prod.outlook.com> <084a42d9-1422-f4a5-f57e-53b4667c1f44@intel.com> <DM6PR11MB4491ADA61FF825A714C3BE2B9A079@DM6PR11MB4491.namprd11.prod.outlook.com> <e1c69e40-120b-1bae-5698-0f15e0af711e@intel.com> In-Reply-To: <e1c69e40-120b-1bae-5698-0f15e0af711e@intel.com> From: David Marchand <david.marchand@redhat.com> Date: Fri, 9 Jul 2021 17:03:32 +0200 Message-ID: <CAJFAV8xJ0ZC0S9ZPTSPYvF-jdN6-ZxkjzhzjLtQaJ+4orFOACw@mail.gmail.com> To: "Burakov, Anatoly" <anatoly.burakov@intel.com> Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Loftus, Ciara" <ciara.loftus@intel.com>, "Hunt, David" <david.hunt@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Jun 24, 2021 at 4:35 PM Burakov, Anatoly <anatoly.burakov@intel.com> wrote: > Right, so the idea is store the PMD-specific data in the monitor > condition, and leave it to the callback to interpret it. > > The obvious question then is, how many values is enough? Two? Three? > Four? This option doesn't really solve the basic issue, it just kicks > the can down the road. I guess three values should be enough for > everyone (tm) ? :D Can we have multiple callbacks executed for a given rxq? Since this is on the rx path, I would say no, but I might be missing some consideration for future evols of this API. In this case, a private field in rxq seems a good place for temporary storage, and then we simply pass a void * opaque pointer. -- David marchand