From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, chenbox@nvidia.com, stable@dpdk.org, yux.jiang@intel.com
Subject: Re: [PATCH] vhost: restrict set max queue pair API to VDUSE
Date: Thu, 3 Oct 2024 08:47:47 +0200 [thread overview]
Message-ID: <CAJFAV8xJNpEa5AUK2f1YnzBsqREYXWxg1XEd03tG5eVrO=dV-Q@mail.gmail.com> (raw)
In-Reply-To: <20241002144208.2618714-1-maxime.coquelin@redhat.com>
On Wed, Oct 2, 2024 at 4:42 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> In order to avoid breaking Vhost-user live-migration, we want the
> rte_vhost_driver_set_max_queue_num API to only be effective with
> VDUSE.
>
> Furthermore, this API is only really needed for VDUSE where the
> device number of queues is defined by the backend. For Vhost-user,
> this is defined by the frontend (e.g. QEMU), so the advantages of
> restricting more the maximum number of queue pairs is limited to
> a small memory gain (a handful of pointers).
>
> Fixes: 4aa1f88ac13d ("vhost: add API to set max queue pairs")
> Cc: stable@dpdk.org
>
> Reported-by: Yu Jiang <yux.jiang@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Should this be documented in the API?
Otherwise, this looks ok to me.
--
David Marchand
prev parent reply other threads:[~2024-10-03 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:42 Maxime Coquelin
2024-10-03 6:47 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xJNpEa5AUK2f1YnzBsqREYXWxg1XEd03tG5eVrO=dV-Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).