From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86EA645A91; Thu, 3 Oct 2024 08:48:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B06F8402C9; Thu, 3 Oct 2024 08:48:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1EF1540273 for ; Thu, 3 Oct 2024 08:48:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727938081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DVt5Mnz57qCE6QAjXQuizR9F1fkimq+6BuSdhJwBdcY=; b=ig0LzKob7lcNWZxMlXdMMW7P8nu4d0IMptZolpAnTLrT9s1kXAgpDSv25zh6pTth8yoTD2 OsTZ0YS0ofqKuaRrAuPbFTNGrWTcAWCLMLjcr1nntmYwhqY3uxJFBoiPstWh+w9PJwuVah chEHVV6oRKDD5ukYXE+X/QdXTravmuw= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-7F-QAO7gPlKNZQrblxUJRA-1; Thu, 03 Oct 2024 02:48:00 -0400 X-MC-Unique: 7F-QAO7gPlKNZQrblxUJRA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5398cd108bcso295745e87.1 for ; Wed, 02 Oct 2024 23:48:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727938079; x=1728542879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DVt5Mnz57qCE6QAjXQuizR9F1fkimq+6BuSdhJwBdcY=; b=JF2BOnjaXuO/Tdqr9bKMyYIDzWQb1GddUCE29Ow/GTb5kRVqfXde5HVUT6GyCu9V15 2SkWd4hEvAKTP3B9MyJ3FdzQIIkcR+BCTZ4K/vkHAfeXR4Fl5w0OdIb0Pfr5tivu7Mb3 CmXGhmITA9/p3BCC+yvdKlBPvmNJ1OnBDYmgbhDlP1PyYKMKWfqWmScrcNMpIcd4f9XS IGfWgjOzcAYVJnE9k206f+uN8XiEE7FweQhEyF/DPiQjovs3YyuHkr/3bVAXZs3mlPN4 SO5XWlEfyc3kZHac6QVF13wlzWCSYIiMBpp5Ry+++ZnF7mOvU7vOU3bmVRhYNIK+hWw7 SLSw== X-Gm-Message-State: AOJu0YyqWIs5PD/tz/9lYQPO4hptplNA1UCbIp7YeFNYs13oF3/sGFzS eJXmu6FH5H7mjxs78utkc5r0ZtS/kwbfr86IXKCBSci/PkoIl4DTjcDyIwehuJhN4jyux63ooQn cF0yGKeeke52gaBnnSSC2LZOFwt51c4pIVtn9mPYVR0crs42ThI6q+yaf1l9M83vclYU8J51IPc lI57oUZeTfwIPkl2k= X-Received: by 2002:a05:6512:3f11:b0:536:54e9:3a63 with SMTP id 2adb3069b0e04-539a07a339bmr3079406e87.49.1727938078793; Wed, 02 Oct 2024 23:47:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOkqOQ2VCPgNuXyV77eh7sttQUB0Q3eS7QYpR9DSFKKe4qYg/08DF1JgvZv78pGwvuUqFCgVqixpSfTrBmfdE= X-Received: by 2002:a05:6512:3f11:b0:536:54e9:3a63 with SMTP id 2adb3069b0e04-539a07a339bmr3079390e87.49.1727938078239; Wed, 02 Oct 2024 23:47:58 -0700 (PDT) MIME-Version: 1.0 References: <20241002144208.2618714-1-maxime.coquelin@redhat.com> In-Reply-To: <20241002144208.2618714-1-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 3 Oct 2024 08:47:47 +0200 Message-ID: Subject: Re: [PATCH] vhost: restrict set max queue pair API to VDUSE To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, stable@dpdk.org, yux.jiang@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 2, 2024 at 4:42=E2=80=AFPM Maxime Coquelin wrote: > > In order to avoid breaking Vhost-user live-migration, we want the > rte_vhost_driver_set_max_queue_num API to only be effective with > VDUSE. > > Furthermore, this API is only really needed for VDUSE where the > device number of queues is defined by the backend. For Vhost-user, > this is defined by the frontend (e.g. QEMU), so the advantages of > restricting more the maximum number of queue pairs is limited to > a small memory gain (a handful of pointers). > > Fixes: 4aa1f88ac13d ("vhost: add API to set max queue pairs") > Cc: stable@dpdk.org > > Reported-by: Yu Jiang > Signed-off-by: Maxime Coquelin Should this be documented in the API? Otherwise, this looks ok to me. --=20 David Marchand