From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 799FAA3201 for <public@inbox.dpdk.org>; Mon, 21 Oct 2019 10:23:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D0E94C77; Mon, 21 Oct 2019 10:23:18 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 0D2A949DF for <dev@dpdk.org>; Mon, 21 Oct 2019 10:23:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571646196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+eWBqrm6PR+aOOK5eUCVyrRb0TnFlESp+kykTxba9/Y=; b=AnyaypdNQTEsgd8fUUpFI+6H0ZnJcZbqsc09o7heE+4UlNJiD+JRjdOWkamhvDZ0Lvq1jx hXTGs8hW0uu2julTjLnV565DofJCiooKnaFeDoGQ4ZZI1ifOeHDoq8rQ3QyGAQ/BAZmhks 1d9oXLLwDXd0xVEKrIEXFJK/ABRgIi4= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-Iy7omWPcN-uM4f0qO71b0g-1; Mon, 21 Oct 2019 04:23:15 -0400 Received: by mail-vk1-f199.google.com with SMTP id u123so5849568vkf.8 for <dev@dpdk.org>; Mon, 21 Oct 2019 01:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+eWBqrm6PR+aOOK5eUCVyrRb0TnFlESp+kykTxba9/Y=; b=LUnbJ8xoqjuFR6ItlVxTav6elFXlZGEv+VjL85f9SQFtWUU67soqvZBNu/JTufGTeQ 8B2dgqzfiWfTBTrzMnXLq8b9uB9R/evck0B6HjROil+VVPRwVmhTvUiaVr7FpoLuGd+e JADyGOnSXZGuTXfAbPlftBXgzuW3kWwJrGvWChFwALlSnBy25WcvqXjJDfKZtuIiFy// CL4tQn/f8z1vQeAokQVnQr0UJ/i5ZrCcyE7aQdN9/FN8uA0l1M3GjuE99VJmiift6Zan mjuiAlQE2qAhR7H9WRsji0e7AzK1dDnHaJEgxH1dyEr1BkgXmoDr3NnTs9qA0rTl7sLM zfQA== X-Gm-Message-State: APjAAAVV96yKbSto1B+AIQDkpZYElCmEnJYKxxai3TBec4LwzVJ4Po1T ijMz4PzEWOlr4Kn11EA8pYI3K8ZS1yxJ8SQzCZMv+UikBThDDlmZLL/s6IHFrPaqeEwt3fG2FD7 DKhNjux0YbsxMOfuUS3k= X-Received: by 2002:ab0:2716:: with SMTP id s22mr12235923uao.86.1571646194705; Mon, 21 Oct 2019 01:23:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDYPftUc++tF4NDkbRYfHlCy2iHH+Y8bEKWkeI+y8PiBJWW/lhNYFEeKe1aaoLgzZnZkDokBjkHRSRr4ECKHA= X-Received: by 2002:ab0:2716:: with SMTP id s22mr12235908uao.86.1571646194309; Mon, 21 Oct 2019 01:23:14 -0700 (PDT) MIME-Version: 1.0 References: <156646334762.14099.13593080473257757748.stgit@jrharri1-skx> <157046210105.10142.15291330038149009146.stgit@jrharri1-skx> <20191008083833.GB1856@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191008083833.GB1856@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Mon, 21 Oct 2019 10:23:03 +0200 Message-ID: <CAJFAV8xJRTrKvuZ5fX3upPfyFdrHfCyH_KO40nF6g=G8=0Ttrg@mail.gmail.com> To: Jim Harris <james.r.harris@intel.com> Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com> X-MC-Unique: Iy7omWPcN-uM4f0qO71b0g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 RESEND] eal: add tsc_hz to rte_mem_config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Oct 8, 2019 at 10:39 AM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Mon, Oct 07, 2019 at 08:28:21AM -0700, Jim Harris wrote: > > This ensures secondary processes never have to > > calculate the TSC rate themselves, which can be > > noticeable in VMs that don't have access to > > arch-specific detection mechanism (such as > > CPUID leaf 0x15 or MSR 0xCE on x86). > > > > Since rte_mem_config is now internal to the rte_eal > > library, we can add tsc_hz without ABI breakage > > concerns. > > > > Reduces rte_eal_init() execution time in a secondary > > process from 165ms to 66ms on my test system. > > > > Signed-off-by: Jim Harris <james.r.harris@intel.com> > > --- > This seems a good idea to me. > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> I wonder if we can get rid of eal_tsc_resolution_hz and just rely on the shared memory to get/store this info. Feel free to look at this later and send a followup patch :-). Applied, thanks. -- David Marchand