From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2D2745A68; Mon, 30 Sep 2024 17:39:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DA144027C; Mon, 30 Sep 2024 17:39:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E9F94014F for ; Mon, 30 Sep 2024 17:39:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727710742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q4jwfNmuYCWUoWYsd3JlEMFYbgf/ttfcU21B9X2zbFI=; b=Hv6n9wwQaHbW68Da9neGwZh9Y9I66zPGQW2HXTa8+J+4nOZkILcaZ7lEQgZKeDJFUesnDc dHK7ZzUscpMAOzG4Wh9hmyjqBAyLilkVd4kS5cBQbFy9NfJu8iy1qx4PUlysCnXFn9W8WM kspfuakllf6Q8g4e86+dHID16Xi6nqc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-5WJMwj9nNBCwIJ01CqV1Og-1; Mon, 30 Sep 2024 11:38:58 -0400 X-MC-Unique: 5WJMwj9nNBCwIJ01CqV1Og-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5399206172aso981992e87.1 for ; Mon, 30 Sep 2024 08:38:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727710737; x=1728315537; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q4jwfNmuYCWUoWYsd3JlEMFYbgf/ttfcU21B9X2zbFI=; b=QvOXifEUdL6ku4JpfHPHFoerxtN74MuJvCckRewJCZywcDg6lkXA3E2Oqf5E0ic/xd gPC4ptjmbKKJQNdAAC6WmuwiLlkMOQ4zpYkTlSzM1lvhKnpL4lomMBQi9CIDbA6Le3Y5 c3ieX6VLBfPDSAmbD7iUANlrJUaz3FXGmU/zHZ8Aix52a1kx1Wv7T2JnCvrbqJNevogi qAjFrzvcFLdew2Qm7bxiRUfe2sTRBFxjY+1x/TqAEZMbWaUw2BVCkjhnIndA2RaYWeq7 HcXMm+1JqPCZrAoN0KTNWyhEsOQi7HhcmlZyxa2/3QmbxBf6rGh3U6OJ8epynu7GD0jN COhw== X-Gm-Message-State: AOJu0Ywl7CaP/xSrlIiWqDMH0qvyjI+tMyLsQ75cTbWALitFHcjaK4zy lc9JU2Ogv1aDZTxmsIj/9gIPfLHRCoSixfUBBkEvwDYWxWj3lMRA0ObuZjTsK3nnhZw48S28V71 wZpO7/k5I41bwjjKstZvUHGIJ9sBGTg3QgaM/jTdOVmENkFwNSgx6kXsAO2jwr30Sf4l6dIV3v3 sbYvHNe3L1l5OZYi4= X-Received: by 2002:a05:6512:32c7:b0:52f:1a0:b49 with SMTP id 2adb3069b0e04-5389fc4834emr5910924e87.31.1727710737071; Mon, 30 Sep 2024 08:38:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGE6xQWNOznc9ZRKP5fD282LPffq+NLNjfUcYIIc6Kzi47a70eyhSINEBbWCq9apkKXE3uUZ9S1Lmx8D9M69PU= X-Received: by 2002:a05:6512:32c7:b0:52f:1a0:b49 with SMTP id 2adb3069b0e04-5389fc4834emr5910905e87.31.1727710736651; Mon, 30 Sep 2024 08:38:56 -0700 (PDT) MIME-Version: 1.0 References: <20240906141127.628873-1-bruce.richardson@intel.com> In-Reply-To: <20240906141127.628873-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 30 Sep 2024 17:38:44 +0200 Message-ID: Subject: Re: [PATCH 0/4] fix issues with using AVX-512 drivers on 32-bit To: Bruce Richardson , Ian Stokes Cc: dev@dpdk.org, Robin Jarry X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 4:11=E2=80=AFPM Bruce Richardson wrote: > > The AVX-512 copy code in multiple drivers was incorrect for 32-bit as it > assumed that each pointer was always 8B in size. > > Bruce Richardson (4): > net/i40e: fix AVX-512 pointer copy on 32-bit > net/ice: fix AVX-512 pointer copy on 32-bit > net/iavf: fix AVX-512 pointer copy on 32-bit > common/idpf: fix AVX-512 pointer copy on 32-bit > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 7 +++++++ > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 7 +++++++ > drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ > 4 files changed, 28 insertions(+) Sorry, not directly related to this series, but as I was checking some AVX512 patch, I suspect some drivers are missing runtime checks for availability of some AVX512 instructions: $ for meson in $(git grep -l __AVX512[^_]*__ 'drivers/**/meson.build'); do dir=3D$(dirname $meson); for flag in $(git grep -ho __AVX512[^_]*__ $dir | sort -u); do flag=3D${flag%%__}; flag=3D${flag##__}; git grep -ql rte_cpu_get_flag_enabled.RTE_CPUFLAG_$flag $dir || echo RTE_CPUFLAG_$flag check missing in $dir; done; done RTE_CPUFLAG_AVX512BW check missing in drivers/common/idpf RTE_CPUFLAG_AVX512DQ check missing in drivers/common/idpf RTE_CPUFLAG_AVX512F check missing in drivers/common/idpf RTE_CPUFLAG_AVX512VL check missing in drivers/net/i40e RTE_CPUFLAG_AVX512VL check missing in drivers/net/ice Maybe some flags are implictly available... worth a confirmation from Intel in any case from my pov. Thanks. --=20 David Marchand