From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05000A318B for ; Fri, 18 Oct 2019 06:10:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32F1B1C02F; Fri, 18 Oct 2019 06:10:55 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id B2EDD1C013 for ; Fri, 18 Oct 2019 06:10:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571371853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f7U0iJXjWSzuKpZrmVYtVYeWaDVgh/nouFz2Zhx2RoQ=; b=M63SYrXGRiQQ3wbqY68loe7fJO1LD0L0KUQ2JoiQ1LbgN4oNfkjoQOJD0otdqPyWa9KDsm NXs/9TgGFFDxPtqw5LM+Px5HxCmyXZNGoXn6Wtj1c4g7rTORVwdU8VjQGz4ZfOesJS+4yU Tf0wKfZ7MvOzmouNbvxtZdVv8qJkIWs= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-wW27ylNVN7a01I4DKJ2dbg-1; Fri, 18 Oct 2019 00:10:52 -0400 Received: by mail-vk1-f200.google.com with SMTP id q187so1859720vkq.4 for ; Thu, 17 Oct 2019 21:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZtQT7QZqVBGjmaOTktKINXjR+mKXYbQCVO/BCxc1tsE=; b=Fk3QiX+TvRCti+/9qRhVGkErKs7jVpq6JhFD8F7PJR1Is8F8FUCA6ZZJWOmXWGFcJn XmgchrvCe9K3LEl3otllDiYooE5r2xOpa4zegj5I3Gc+9psVIcQ1MySOteJH82pSb62r uEeYGPn8etabiPAXuyHaxw202eX1xk+wyQ7JMgVtKa/IPJ/WDv7EzBWcp5b2UwLRP/vB gKnZ3SuvCbEERCpLV8wv9yApu17cRNAG7V4Ce+BbtU19Qen9S5V+8G8oB7I5nygkCSq1 LtYa//6QvJOQ4lE+K6cO4rq1BL8oy1MGfC3cop0uT3xypF+i9H7R+9mIqilQO0NONHkj n5IA== X-Gm-Message-State: APjAAAX5WqcMI5Bwuh4d5BIJFYVVOwBfjXnr4a81S2ariwe96+LxNYMH FEOWhY3AwBZLJkc2uDGWFrlSXMUhOHyxILBbvEVtZV8tgJQvl/EWznsAtVjXS91Ub84xDGxKBon PmTqpxGdoLqzrqOZpgkw= X-Received: by 2002:a67:e88b:: with SMTP id x11mr4145513vsn.180.1571371851561; Thu, 17 Oct 2019 21:10:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNT7GffRD9GYh+GS5F6OgcqjqGk2YbRXIQeKOFt55vnw1V95Anbk2KZ3x8JufI5zsWKEjmJJm0GMRPRnxgPLw= X-Received: by 2002:a67:e88b:: with SMTP id x11mr4145507vsn.180.1571371851246; Thu, 17 Oct 2019 21:10:51 -0700 (PDT) MIME-Version: 1.0 References: <1568628062-31332-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: From: David Marchand Date: Fri, 18 Oct 2019 06:10:39 +0200 Message-ID: To: "Van Haaren, Harry" Cc: dev , "Rao, Nikhil" X-MC-Unique: wW27ylNVN7a01I4DKJ2dbg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] service: improve service run performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 7, 2019 at 5:37 PM Van Haaren, Harry wrote: > > > -----Original Message----- > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Monday, October 7, 2019 3:53 PM > > To: Van Haaren, Harry > > Cc: dev ; Rao, Nikhil > > Subject: Re: [dpdk-dev] [PATCH] service: improve service run performanc= e > > > > On Mon, Sep 16, 2019 at 12:01 PM Nikhil Rao wrot= e: > > > > > > For a valid service, the core mask of the service > > > is checked against the current core and the corresponding > > > entry in the active_on_lcore array is set or reset. > > > > > > Upto 8 cores share the same cache line for their > > > service active_on_lcore array entries since each entry is a uint8_t. > > > Some number of these entries also share the cache line with > > > the internal_flags member of struct rte_service_spec_impl, > > > hence this false sharing also makes the service_valid() check > > > expensive. > > > > > > Eliminate false sharing by moving the active_on_lcore array to > > > a per-core data structure. The array is now indexed by service id. Acked-by: Gage Eads > > > > Harry, any comments on this patch? > > > Looks good to me, thanks Nikhil & David for the ping; > > Acked-by: Harry van Haaren Applied, thanks. -- David Marchand