From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7567041C5F; Fri, 10 Feb 2023 12:55:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F23A540EE6; Fri, 10 Feb 2023 12:55:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A01B840EE6 for ; Fri, 10 Feb 2023 12:55:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676030132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=25nA5vwfYyr4NVOGz5mxqLpL4LlEwr7Ztmbeo9a8mkk=; b=XrztiyFz6AMB2JV2DRLxy/Nsm9KqAl0QqK6TpKq3IPsUYAZEXCShZA4lFWMWjAubimwb0C 4Bb6jnnyRy72VqJ0DTKwHHQbcaRyuJzgZxmfTf83O2za/TJSIU38MSiOBAWcNvyUDpw6tQ 1dsylgSnUIPxGBi4V/oMJgj12LS9unQ= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-530-5EegPMKFNvep4_sPoxW-VQ-1; Fri, 10 Feb 2023 06:55:31 -0500 X-MC-Unique: 5EegPMKFNvep4_sPoxW-VQ-1 Received: by mail-pf1-f198.google.com with SMTP id u18-20020a62ed12000000b00593cc641da4so2571971pfh.0 for ; Fri, 10 Feb 2023 03:55:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=25nA5vwfYyr4NVOGz5mxqLpL4LlEwr7Ztmbeo9a8mkk=; b=tcuEJc4DzuNVQNODE0iQCq+u0rOC7ZJ6gUMzJPPnAdtscgNZxbSfPPJ1e+Jd2D1fdT 9sEbXp2g/EIoKiV8O86AHXl6ZPNEcdXk81Sd/4vu3AXSPseMsM+ayb41gZB9xrXwoWOC QXEIdm4ws1Ez64ql2DRibwS0JQBgq89xSv7/8u+lDJEuar7u70lvkIftkbpKspk+tIoc q4tQ4+S17Jmpm5Fz4rlM93bgiuLWN3WHRWg/Btaf0YYcVlLtB3aGYFhpiqqFgyV5hxyu 77OzguKJqw1NPzgPKfTtmc2yVN8cLDGxBAu9rPEq+5rs1Hq+z3Vr2yOXKKwz5wfP6V9L yVVA== X-Gm-Message-State: AO0yUKXL+MJ26Qxni+b04lmaYZX+ESNmua3rxv/MJrHcDBrSJq3ZOXtI R7rmerBJeFS+tc6gP/NbaFgQxq+6GQGqw9lCYtsnQrzY/jn76rFDFnft70uWcn6KdGKI9R8Eb9L lKy88Akgic5hBWjj1PMk= X-Received: by 2002:a17:90a:ce8f:b0:230:89b2:fabd with SMTP id g15-20020a17090ace8f00b0023089b2fabdmr2223678pju.116.1676030130115; Fri, 10 Feb 2023 03:55:30 -0800 (PST) X-Google-Smtp-Source: AK7set9+Rim+pfstbapdpOkLFkMyBuzMB8LyG8iyOfazeFgh39uacpZtlCPd5AOLm81IUcetRe0eH2w10msQcIuEIh0= X-Received: by 2002:a17:90a:ce8f:b0:230:89b2:fabd with SMTP id g15-20020a17090ace8f00b0023089b2fabdmr2223672pju.116.1676030129825; Fri, 10 Feb 2023 03:55:29 -0800 (PST) MIME-Version: 1.0 References: <20230107151230.2539470-1-vfialko@marvell.com> <20230209132207.1994066-1-vfialko@marvell.com> In-Reply-To: From: David Marchand Date: Fri, 10 Feb 2023 12:55:18 +0100 Message-ID: Subject: Re: [PATCH v2] bus: fix leak for devices without driver To: Volodymyr Fialko Cc: Kevin Laatz , dev@dpdk.org, Bruce Richardson , =?UTF-8?Q?Morten_Br=C3=B8rup?= , jerinj@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 10:29 AM Kevin Laatz wrote: > > On 09/02/2023 13:22, Volodymyr Fialko wrote: > > During the bus scan, memory for device configuration is allocated. > > Currently, if a driver wasn't attached to the device during initialization, > > memory for that device will not be released at bus cleanup. > > This patch address this issue and releases the memory for all allocated > > devices. > > > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > > Cc: stable@dpdk.org > > > > Signed-off-by: Volodymyr Fialko > Acked-by: Kevin Laatz Applied, thanks. -- David Marchand