From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03107A0C53; Thu, 14 Oct 2021 09:04:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 804F840042; Thu, 14 Oct 2021 09:04:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 247A440041 for ; Thu, 14 Oct 2021 09:04:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634195072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0N7aPpYnZMbBLRyUTmiHlcIlKk+RF8K7ZrlM8eQqPhY=; b=XmXGE2ZRF+Fk/h4IQPPK1ouQFYpVYRBKZzjIfv414tAkUtNcOhVL6p/VX7xYUeHsLJN+Cl Apc5e4AxkYPZyFO5Kx0EULtKxXHXUnOGCl4TdJyg+B5zUv+Vujn8o58mDS6vkChistUmZO KiYi50DxiMluh8CD5tDvldCqZjHmi7g= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-g5HHgxLzPB6JvU8kFmN1bg-1; Thu, 14 Oct 2021 03:04:31 -0400 X-MC-Unique: g5HHgxLzPB6JvU8kFmN1bg-1 Received: by mail-lf1-f72.google.com with SMTP id c41-20020a05651223a900b003fdb648a156so1495809lfv.15 for ; Thu, 14 Oct 2021 00:04:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0N7aPpYnZMbBLRyUTmiHlcIlKk+RF8K7ZrlM8eQqPhY=; b=Sd5zg5FJHVd3XggxSH7fwZVNPhNC3V1sbWqTwcSEM8VZinJHjNsnf95z8yVOgEBSLc w4uHjGuSh0xuqflk/XTcP4dCmnWPjisc8gePr0SJTLD1h38YLPt35AwUVHfhuLlw47/F aS9ALKZMlhNLhsUUioh0hyayPB+ChgMEgRvcFpVZSke4m8UYiw7RgHdCEf0ivpHNtUZo 7+E0IUNwy8HRgT0tW7S82RdNzCerOhk+InmBG/09QSNDwlqihA1dv6Ns2jUIk0EUpHeJ foVIuygNroOgZGxknxaFi8+6zazJ1gXi4lWdYjwJkAY43R/tnR925rafaHmeoxE0L4wC KUsg== X-Gm-Message-State: AOAM530PdCSFBBwq4++thvyQ5rZrcRk1QE689qvpCSoD0be6eFh3F9ka q5tnyTSJ/7yd7qhj8HRIbMePH7JLpNxnhkl0H+IHfzE6pYOHmFSGIA1rlRkAmqRvNOytzBr1sax E6yCXMj+yquSElOe2Uwo= X-Received: by 2002:a2e:9588:: with SMTP id w8mr4215327ljh.81.1634195070007; Thu, 14 Oct 2021 00:04:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztIoKABUIjOMzYRfcwGaN63TO23npfocL03f7rYmyjqDpORy5WcKVeLaPK6VcLznmR3CqJU6gjTbCHTebSydc= X-Received: by 2002:a2e:9588:: with SMTP id w8mr4215297ljh.81.1634195069652; Thu, 14 Oct 2021 00:04:29 -0700 (PDT) MIME-Version: 1.0 References: <1633728526-197782-1-git-send-email-vladimir.medvedkin@intel.com> <47f6bf7f-259f-f376-3e23-a2b0c7b886b7@intel.com> In-Reply-To: <47f6bf7f-259f-f376-3e23-a2b0c7b886b7@intel.com> From: David Marchand Date: Thu, 14 Oct 2021 09:04:18 +0200 Message-ID: To: "Medvedkin, Vladimir" Cc: dev , "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/hash: fix buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Vladimir, On Wed, Oct 13, 2021 at 9:27 PM Medvedkin, Vladimir wrote: > > With patch applied, ASan reports another issue. > > Did you test your fix with ASan? > > > > You're right, for some reason ASAN wasn't enabled. > I applied patch and built running .ci/linux-build.sh, > also I build with CFLAGS + LDFLAGS. > > Bruce suggested to use meson options instead of using CFLAGS, so > meson configure build -Db_sanitize=address -Db_lundef=false > works fine. Well, yes, you can directly do this. I linked to my GHA patch in the bz, because I find it easier and reproducible to push fixes in GHA and get the result: no question about "did I enable ASan?" or "did I start the test correctly?". FYI, b_lundef seems necessary only with clang, gcc should be fine without it. IIUC, those compilers went with different choices on how to pull libasan (clang went with static, gcc went with shared). Hopefully, we will have something easier to use in DPDK with Zhihong work. > > I'll sent v2 for this. Thanks, I'll look at it. -- David Marchand